[X2Go-Commits] [x2goserver] 92/99: x2goserver/bin/x2goupdateoptionsstring: fix some Perl::Critic warnings.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2goserver.

commit 09b5078c4a253f77e7252e43bf0404f02e5af649
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Wed Dec 16 09:53:00 2020 +0100

    x2goserver/bin/x2goupdateoptionsstring: fix some Perl::Critic warnings.
---
 debian/changelog                       | 1 +
 x2goserver/bin/x2goupdateoptionsstring | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 36af5adf..9a23c5dd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -373,6 +373,7 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium
     - x2goserver/bin/x2goupdateoptionsstring: an equal sign or space character
       is mandatory after the -m or --mode switch.
     - X2Go/Server/Agent/NX/Options.pm: document key-value pair extraction.
+    - x2goserver/bin/x2goupdateoptionsstring: fix some Perl::Critic warnings.
   * debian/control:
     + Build-depend upon lsb-release for distro version detection.
   * debian/x2goserver.manpages:
diff --git a/x2goserver/bin/x2goupdateoptionsstring b/x2goserver/bin/x2goupdateoptionsstring
index 48c9d17f..9da8d6ec 100755
--- a/x2goserver/bin/x2goupdateoptionsstring
+++ b/x2goserver/bin/x2goupdateoptionsstring
@@ -50,7 +50,7 @@ use List::Util qw (max);
 use Encode qw (encode decode);
 
 # Convert data in ARGV.
-exit (Main (map { Encode::decode ("UTF-8", $_, (Encode::FB_CROAK | Encode::LEAVE_SRC)); } @ARGV));
+exit (Main (map { Encode::decode ('UTF-8', $_, (Encode::FB_CROAK | Encode::LEAVE_SRC)); } @ARGV));
 
 BEGIN {
 }
@@ -485,7 +485,7 @@ sub extract_data {
           my $value = $entry->{$key};
 
           if (defined ($value)) {
-            $ret .= '=' . $value;
+            $ret .= q{=} . $value;
           }
         }
       }
@@ -731,7 +731,7 @@ sub Main {
         $intermediate = apply_transformation ($intermediate, $cur_arg, $debug);
 
         if (!(defined ($intermediate))) {
-          print {*STDERR} 'Unable to apply transformation "' . $cur_arg . '"' . ", aborting.\n";
+          print {*STDERR} 'Unable to apply transformation "' . $cur_arg . q{"} . ", aborting.\n";
           $error_detected = 12;
           last;
         }
@@ -740,7 +740,7 @@ sub Main {
         my $extract = extract_data ($intermediate, $cur_arg, $debug, $base64);
 
         if (!(defined ($extract))) {
-          print {*STDERR} 'Unable to extract data for "' . $cur_arg . '"' . ", aborting.\n";
+          print {*STDERR} 'Unable to extract data for "' . $cur_arg . q{"} . ", aborting.\n";
           $error_detected = 13;
           last;
         }

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2goserver.git