[X2Go-Commits] [x2goserver] 31/99: X2Go/Server/Agent/NX/Options.pm: rework the lastly modified comment again, the changed explanation didn't match the reality.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2goserver.

commit 39c960208e3cb0c226541de23b11b3b38e48ee70
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Sun Nov 8 04:06:55 2020 +0100

    X2Go/Server/Agent/NX/Options.pm: rework the lastly modified comment again, the changed explanation didn't match the reality.
---
 X2Go/Server/Agent/NX/Options.pm | 5 ++---
 debian/changelog                | 2 ++
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/X2Go/Server/Agent/NX/Options.pm b/X2Go/Server/Agent/NX/Options.pm
index b0e6e612..9422b852 100644
--- a/X2Go/Server/Agent/NX/Options.pm
+++ b/X2Go/Server/Agent/NX/Options.pm
@@ -482,9 +482,8 @@ sub filter_option_modify {
       my $new_opt = { };
 
       # Don't add empty options as an empty string key with undef value; even
-      # though that's technically legit, we want to reserve this notation for
-      # the last display number element and rather represent this situation by
-      # an empty hash.
+      # though that's technically legit and would semantically fit the notion
+      # as well, we rather want to represent this situation by an empty hash.
       if (!(($needle_key) || (defined ($needle_value)))) {
         print {*STDERR} "Empty option addition/modification requested, this is deprecated. Adding empty hash.\n";
       }
diff --git a/debian/changelog b/debian/changelog
index 8de6381f..505b54f5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -240,6 +240,8 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium
       a different comment.
     - X2Go/Server/Agent/NX/Options.pm: avoid copying arrays if not necessary
       when passing to grep and map operations.
+    - X2Go/Server/Agent/NX/Options.pm: rework the lastly modified comment
+      again, the changed explanation didn't match the reality.
   * debian/control:
     + Build-depend upon lsb-release for distro version detection.
   * debian/x2goserver.manpages:

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2goserver.git