[X2Go-Commits] [x2goserver] 28/99: x2goserver/lib/x2goupdateoptionsstring: fix some Perl Critic warnings and silence others.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2goserver.

commit 83da25608167226f652911c9fe222cb5ce4af79e
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Sat Nov 7 12:51:36 2020 +0100

    x2goserver/lib/x2goupdateoptionsstring: fix some Perl Critic warnings and silence others.
---
 debian/changelog                       | 2 ++
 x2goserver/bin/x2goupdateoptionsstring | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index d85d7e91..98722c55 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -234,6 +234,8 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium
       compact_intermediate () function and its implications.
     - X2Go/Server/Agent/NX/Options.pm: fix some Perl Critic warnings and
       silence others.
+    - x2goserver/lib/x2goupdateoptionsstring: fix some Perl Critic warnings
+      and silence others.
   * debian/control:
     + Build-depend upon lsb-release for distro version detection.
   * debian/x2goserver.manpages:
diff --git a/x2goserver/bin/x2goupdateoptionsstring b/x2goserver/bin/x2goupdateoptionsstring
index 8bb6485f..a06a487f 100755
--- a/x2goserver/bin/x2goupdateoptionsstring
+++ b/x2goserver/bin/x2goupdateoptionsstring
@@ -73,7 +73,9 @@ sub sanitize_program_options {
   if (!($error_detected)) {
     $args = dclone ($args);
 
+    ## no critic (ControlStructures::ProhibitCStyleForLoops)
     for (my $cur_arg = shift (@{$args}); defined ($cur_arg); $cur_arg = shift (@{$args})) {
+    ## critic (ControlStructures::ProhibitCStyleForLoops)
       if (q{-} eq substr ($cur_arg, 0, 1)) {
         # Looks like an option so far. Let's continue scanning.
 
@@ -111,7 +113,7 @@ sub sanitize_program_options {
             last;
           }
           else {
-            print {*STDERR} "Unknown option encountered: " . $cur_arg . "; erroring out.\n";
+            print {*STDERR} q{Unknown option encountered: } . $cur_arg . "; erroring out.\n";
             $error_detected = 1;
             last;
           }
@@ -135,7 +137,9 @@ sub sanitize_program_options {
 # Main function, no code outside of it shall be executed.
 #
 # Expects @ARGV to be passed in.
+## no critic (NamingConventions::Capitalization)
 sub Main {
+## critic (NamingConventions::Capitalization)
   my @program_arguments = @_;
   my $error_detected = 0;
   my $found_separator = 0;

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2goserver.git