[X2Go-Commits] [x2goserver] 15/99: X2Go/Server/Agent/NX/Options.pm: document that duplicate keys in the input options string are possible and accepted, but actually discouraged and semantically redundant.

git-admin at x2go.org git-admin at x2go.org
Mon Dec 28 06:10:38 CET 2020


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2goserver.

commit 9aec86288f75aa8f83d661eca2156bd6c29301bf
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Sat Nov 7 02:11:53 2020 +0100

    X2Go/Server/Agent/NX/Options.pm: document that duplicate keys in the input options string are possible and accepted, but actually discouraged and semantically redundant.
---
 X2Go/Server/Agent/NX/Options.pm | 19 +++++++++++++++++--
 debian/changelog                |  3 +++
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/X2Go/Server/Agent/NX/Options.pm b/X2Go/Server/Agent/NX/Options.pm
index 8c669b8d..e0062cbb 100644
--- a/X2Go/Server/Agent/NX/Options.pm
+++ b/X2Go/Server/Agent/NX/Options.pm
@@ -777,8 +777,8 @@ If this is not the case, please report a bug.
 B<X2Go/NX Agent> options strings are fully documented in L<nxagent> and
 additional, linked places.
 
-This module is not concerned with the actual content of an options string,
-but merely its format.
+This module is not really concerned with the actual content of an options
+string, but mostly its format.
 
 An options string follows the form
 [[I<key>[C<=>I<value>,]]C<:>I<displaynumber>.
@@ -853,6 +853,21 @@ Quoting with any character is unsupported. Quotes and other grouping
 characters (like B<curly braces> [C<{}>]) are seen verbatim without any
 special meaning.
 
+=item *
+
+There are no provisions (other than the mentioned invalid characters) on the
+content of keys and values.
+
+Importantly, this also means that the same key can show up multiple times in
+the options string. Semantically, this is redundant, since only the last
+occurrence of a key (assuming the options string is parsed from left to right)
+will take any effect. Syntactically, it's completely legal, though.
+
+It is recommended to avoid duplicate keys in the input options string.
+
+Note that, due to the nature of the supported transformations, keys can not be
+duplicated with this module.
+
 =back
 
 =head1 TRANSFORMATIONS
diff --git a/debian/changelog b/debian/changelog
index b2a242dd..65507baf 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -208,6 +208,9 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium
       string" with "options string".
     - X2Go/Server/Agent/NX/Options.pm: replace occurrences of "option string"
       with "options string".
+    - X2Go/Server/Agent/NX/Options.pm: document that duplicate keys in the
+      input options string are possible and accepted, but actually discouraged
+      and semantically redundant.
   * debian/control:
     + Build-depend upon lsb-release for distro version detection.
   * debian/x2goserver.manpages:

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2goserver.git


More information about the x2go-commits mailing list