[X2Go-Commits] [nx-libs] 68/219: mi: Hush an almost certainly bogus warning

git-admin at x2go.org git-admin at x2go.org
Sat Sep 28 12:10:23 CEST 2019


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch 3.6.x
in repository nx-libs.

commit 28e42b3bd0d7fb5d5674acd256fed5e84903a271
Author: Ulrich Sibiller <uli42 at gmx.de>
Date:   Sat May 4 01:44:36 2019 +0200

    mi: Hush an almost certainly bogus warning
    
      commit 57e872301f5e836be2efb8f952f9c9711650b447
      Author: Adam Jackson <ajax at redhat.com>
      Date:   Thu Apr 5 13:07:09 2018 -0400
    
        mi: Hush an almost certainly bogus warning
    
        In file included from ../mi/miexpose.c:83:
        ../mi/miexpose.c: In function ‘miHandleExposures’:
        ../include/regionstr.h:174:22: warning: ‘expBox.y2’ may be used uninitialized in this function [-Wmaybe-uninitialized]
             (_pReg)->extents = *(_pBox);
             ~~~~~~~~~~~~~~~~~^~~~~~~~~~
        ../mi/miexpose.c:139:12: note: ‘expBox.y2’ was declared here
             BoxRec expBox;
                    ^~~~~~
    
        etc. It's initialized if (extents), and then only read if (extents),
        but gcc doesn't seem to figure that out. Whatever, bzero it to be
        explicit.
    
        Signed-off-by: Adam Jackson <ajax at redhat.com>
        Acked-by: Keith Packard <keithp at keithp.com>
---
 nx-X11/programs/Xserver/mi/miexpose.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nx-X11/programs/Xserver/mi/miexpose.c b/nx-X11/programs/Xserver/mi/miexpose.c
index 8e60f475e..274a8d4ce 100644
--- a/nx-X11/programs/Xserver/mi/miexpose.c
+++ b/nx-X11/programs/Xserver/mi/miexpose.c
@@ -151,7 +151,7 @@ miHandleExposures(pSrcDrawable, pDstDrawable,
 				   the window background
 				*/
     WindowPtr pSrcWin;
-    BoxRec expBox;
+    BoxRec expBox = { 0, };
     Bool extents;
 
     /* This prevents warning about pscr not being used. */

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git


More information about the x2go-commits mailing list