[X2Go-Commits] [pyhoca-gui] 03/10: Don't set minimum height for wxSpinCtrl widgets. Leave min-sizing to GTK+ as it might know better what minimum size is needed. This resolves Gtk-CRITICAL: for_size smaller than min-size (28 < 32) while measuring gadget (node entry, owner GtkSpinButton)

git-admin at x2go.org git-admin at x2go.org
Tue Jul 23 21:53:29 CEST 2019


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository pyhoca-gui.

commit 426085d3bd103fa4eef6ca6a11aff4bec752b381
Author: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
Date:   Tue Jul 23 17:04:09 2019 +0200

    Don't set minimum height for wxSpinCtrl widgets. Leave min-sizing to GTK+ as it might know better what minimum size is needed. This resolves Gtk-CRITICAL: for_size smaller than min-size (28 < 32) while measuring gadget (node entry, owner GtkSpinButton)
---
 debian/changelog               |  4 ++++
 pyhoca/wxgui/profilemanager.py | 14 +++++++-------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 547d366..1953a19 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,6 +14,10 @@ pyhoca-gui (0.5.0.9-0x2go1) UNRELEASED; urgency=medium
     - pyhoca/wxgui/printingprefs.py: Set _icons_location in constructor, not
       outside of the class definition. (It fails to set a local icon path
       if PyHoca-GUI runs in PYHOCAGUI_DEVELOPMENT mode).
+    - Don't set minimum height for wxSpinCtrl widgets. Leave min-sizing to
+      GTK+ as it might know better what minimum size is needed. This resolves
+      Gtk-CRITICAL: for_size smaller than min-size (28 < 32) while measuring
+      gadget (node entry, owner GtkSpinButton)
   * debian/control:
     + Drop python-notify alternative dependency, rely on the GTK-3 Notify
       GObject.
diff --git a/pyhoca/wxgui/profilemanager.py b/pyhoca/wxgui/profilemanager.py
index 753c0c7..18c72e5 100644
--- a/pyhoca/wxgui/profilemanager.py
+++ b/pyhoca/wxgui/profilemanager.py
@@ -510,7 +510,7 @@ class PyHocaGUI_ProfileManager(wx.Dialog):
         self.HostLabel.SetMinSize((-1, 16))
         self.Host.SetMinSize((220, self._textfield_height))
         self.SSHPortLabel.SetMinSize((-1, 16))
-        self.SSHPort.SetMinSize((65, self._textfield_height))
+        self.SSHPort.SetMinSize((65, -1))
         self.SSHKeyFileLabel.SetMinSize((-1, 16))
         self.SSHKeyFile.SetMinSize((220, self._textfield_height))
         self.SSHProxyUserLabel.SetMinSize((-1, 16))
@@ -518,7 +518,7 @@ class PyHocaGUI_ProfileManager(wx.Dialog):
         self.SSHProxyHostLabel.SetMinSize((-1, 16))
         self.SSHProxyHost.SetMinSize((220, self._textfield_height))
         self.SSHProxyPortLabel.SetMinSize((-1, 16))
-        self.SSHProxyPort.SetMinSize((65, self._textfield_height))
+        self.SSHProxyPort.SetMinSize((65, -1))
         self.SSHProxyKeyFile.SetMinSize((220, self._textfield_height))
         if X2GOCLIENT_OS == 'Windows':
             self.LinkSpeed.SetMinSize((425, self._textfield_height))
@@ -533,13 +533,13 @@ class PyHocaGUI_ProfileManager(wx.Dialog):
         self.Compression.SetMinSize((180, self._textfield_height))
         self.Compression.SetSelection(0)
         self.ImageQualityLabel.SetMinSize((120, 16))
-        self.ImageQuality.SetMinSize((180, self._textfield_height))
+        self.ImageQuality.SetMinSize((180, -1))
         self.DisplayTypeFullscreen.SetMinSize((-1, self._textfield_height))
         self.DisplayTypeMaximize.SetMinSize((-1, self._textfield_height))
-        self.ScreenWidth.SetMinSize((60, self._textfield_height))
-        self.ScreenHeight.SetMinSize((60, self._textfield_height))
+        self.ScreenWidth.SetMinSize((60, -1))
+        self.ScreenHeight.SetMinSize((60, -1))
         self.SetDisplayDPI.SetMinSize((-1, self._textfield_height))
-        self.DisplayDPI.SetMinSize((60, self._textfield_height))
+        self.DisplayDPI.SetMinSize((60, -1))
         self.EnableXinerama.SetMinSize((-1, self._textfield_height))
         self.DontSetKeyboard.SetMinSize((-1, self._textfield_height))
         self.AutoSetKeyboard.SetMinSize((-1, self._textfield_height))
@@ -555,7 +555,7 @@ class PyHocaGUI_ProfileManager(wx.Dialog):
         self.Arts.SetMinSize((-1, self._textfield_height))
         self.Esd.SetMinSize((-1, self._textfield_height))
         self.DefaultSoundPort.SetMinSize((-1, self._textfield_height))
-        self.SoundPort.SetMinSize((-1, self._textfield_height))
+        self.SoundPort.SetMinSize((-1, -1))
         self.ClientSidePrinting.SetMinSize((-1, self._textfield_height))
         self.SharedFolderPath.SetMinSize((220, self._textfield_height))
         self.SharedFoldersList.SetMinSize((-1, 90))

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/pyhoca-gui.git


More information about the x2go-commits mailing list