[X2Go-Commits] [pyhoca-gui] 04/09: wxgui/profilemanager.py: Capture failures that might occur when writing session profile configs back to disk.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository pyhoca-gui.

commit c836207e54446d6f935e6918da424ff7533b7d69
Author: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
Date:   Mon Dec 2 16:30:38 2019 +0100

    wxgui/profilemanager.py: Capture failures that might occur when writing session profile configs back to disk.
---
 pyhoca/wxgui/profilemanager.py | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/pyhoca/wxgui/profilemanager.py b/pyhoca/wxgui/profilemanager.py
index 3cf6281..2155421 100644
--- a/pyhoca/wxgui/profilemanager.py
+++ b/pyhoca/wxgui/profilemanager.py
@@ -2526,20 +2526,25 @@ class PyHocaGUI_ProfileManager(wx.Dialog):
                         self.session_profiles.update_value(self.profile_id, k, self.profile_config[k])
 
                 self.session_profiles.write_user_config = True
-                self.session_profiles.write()
-                self.profile_id = self.session_profiles.to_profile_id(self.profile_config['name'])
-
-                if self.action == 'ADD':
-                    self._PyHocaGUI.notifier.send(title=_('%s - profile added') % self.profile_config['name'],
-                                                  text=_('A new session profile has been added.'),
-                                                  icon='profile_add',
-                                                 )
-                elif self.action == 'EDIT':
-                    self._PyHocaGUI.notifier.send(title=_('%s - modified') % self.profile_config['name'],
-                                                  text=_('Changes to profile have been saved.'),
-                                                  icon='profile_save',
+                if self.session_profiles.write():
+                    self.profile_id = self.session_profiles.to_profile_id(self.profile_config['name'])
+
+                    if self.action == 'ADD':
+                        self._PyHocaGUI.notifier.send(title=_('%s - profile added') % self.profile_config['name'],
+                                                      text=_('A new session profile has been added.'),
+                                                      icon='profile_add',
+                                                     )
+                    elif self.action == 'EDIT':
+                        self._PyHocaGUI.notifier.send(title=_('%s - modified') % self.profile_config['name'],
+                                                      text=_('Changes to profile have been saved.'),
+                                                      icon='profile_save',
+                                                     )
+                    self._PyHocaGUI.register_available_server_sessions_by_profile_name(profile_name=self.profile_config['name'], re_register=True)
+                else:
+                    self._PyHocaGUI.notifier.send(title=_('%s - failed writing session profile') % self.profile_config['name'],
+                                                  text=_('There was a failure while saving the session profile configuration.'),
+                                                  icon='profile_error',
                                                  )
-                self._PyHocaGUI.register_available_server_sessions_by_profile_name(profile_name=self.profile_config['name'], re_register=True)
 
             try: wx.EndBusyCursor()
             except: pass

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/pyhoca-gui.git