[X2Go-Commits] [x2go-keyring] 03/04: t/keyids-complete.t: avoid using a subshell via pipes.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2go-keyring.

commit e5e6e2195f9e09e1929bc1722b71ff4b74dd8551
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Sun Aug 4 16:41:57 2019 +0200

    t/keyids-complete.t: avoid using a subshell via pipes.
---
 debian/changelog    | 1 +
 t/keyids-complete.t | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 75563aa..2be039b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -59,6 +59,7 @@ x2go-keyring (2019.08.04) UNRELEASED; urgency=medium
   * .gitignore: rework.
   * runtests: fix tempdir -> tmpdir typo.
   * t/keyids-complete.t: fix stupid while -r ... read typo.
+  * t/keyids-complete.t: avoid using a subshell via pipes.
   * debian/control:
     - Change maintainer to the mailing list.
     - Add the old package maintainer to the Uploaders field and myself.
diff --git a/t/keyids-complete.t b/t/keyids-complete.t
index 123d49c..47db68d 100755
--- a/t/keyids-complete.t
+++ b/t/keyids-complete.t
@@ -7,12 +7,12 @@ typeset -i fail='0'
 
 for keyring in 'x2go-maintainers' 'x2go-maintainers-removed-keys' 'active-keys' 'removed-keys'; do
   pushd "${keyring}" >'/dev/null'
-  find . -iname 'add-*' -print0 | while read -r -d '' key; do
+  while read -r -d '' key; do
     if ! grep -q "^${key} " 'index'; then
       echo "${keyring}: ${key} is not in index file."
       fail='1'
     fi
-  done
+  done < <(find . -iname 'add-*' -print0)
   popd >'/dev/null'
 done
 

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2go-keyring.git