[X2Go-Commits] [x2go-keyring] 20/47: t/no-expired.t: improve quoting.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2go-keyring.

commit 6e7bbf7df39d18abbb75522c9225574475c44dd3
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Sun Aug 4 14:03:29 2019 +0200

    t/no-expired.t: improve quoting.
---
 debian/changelog |  1 +
 t/no-expired.t   | 14 +++++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index a2885b2..364420a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -33,6 +33,7 @@ x2go-keyring (2014.07.09) UNRELEASED; urgency=medium
   * runtests: adapt to new layout.
   * t/keyids-complete.t: adapt to new layout.
   * t/no-expired.t: switch to bash.
+  * t/no-expired.t: improve quoting.
   * debian/control:
     - Change maintainer to the mailing list.
     - Add the old package maintainer to the Uploaders field and myself.
diff --git a/t/no-expired.t b/t/no-expired.t
index 0b55040..abce917 100755
--- a/t/no-expired.t
+++ b/t/no-expired.t
@@ -3,17 +3,17 @@
 set -e
 
 find_expired () {
-	k=$1
+	k="${1}"
 	gpg --no-options --no-auto-check-trustdb --no-default-keyring \
-		--keyring "./output/keyrings/$k" --list-keys --with-colons \
+		--keyring "./output/keyrings/${k}" --list-keys --with-colons \
 		| grep '^pub' \
-		| awk -F: --assign keyring=$1 \
+		| awk -F':' --assign keyring="${1}" \
 		'$2 == "e" {print keyring ":\t0x" $5 " expired on " $7}'
 }
 
-fail=0
-for keyring in x2go-maintainers.gpg x2go-keyring.gpg; do
-	find_expired $keyring
+fail='0'
+for keyring in 'x2go-maintainers.gpg' 'x2go-keyring.gpg'; do
+	find_expired "${keyring}"
 done
 
-exit $fail
+exit "${fail}"

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2go-keyring.git