[X2Go-Commits] [pale-moon] 08/24: Force expected crashes on unexpected magic values.

git-admin at x2go.org git-admin at x2go.org
Thu Apr 25 09:06:06 CEST 2019


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch upstream/28.4.1
in repository pale-moon.

commit 5ec124cf03f7380da68d6b1b5bcdf41ec7d5dbe1
Author: Nicolas B. Pierron <nicolas.b.pierron at nbp.name>
Date:   Thu Mar 21 21:28:10 2019 +0100

    Force expected crashes on unexpected magic values.
---
 js/public/Value.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/js/public/Value.h b/js/public/Value.h
index 01666ed..7c4f833 100644
--- a/js/public/Value.h
+++ b/js/public/Value.h
@@ -567,8 +567,11 @@ class MOZ_NON_PARAM alignas(8) Value
     }
 
     bool isMagic(JSWhyMagic why) const {
-        MOZ_ASSERT_IF(isMagic(), data.s.payload.why == why);
-        return isMagic();
+        if (!isMagic()) {
+            return false;
+        }
+        MOZ_RELEASE_ASSERT(data.s.payload.why == why);
+        return true;
     }
 
     JS::TraceKind traceKind() const {

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/pale-moon.git


More information about the x2go-commits mailing list