[X2Go-Commits] [x2gobroker] 02/06: x2gobroker.authmechs: Add FIXME about non-working~ inheritance among authmech classes.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2gobroker.

commit 932baa66fe7edefcca6e87f4923f9340bef31409
Author: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
Date:   Tue Sep 11 15:42:45 2018 +0200

    x2gobroker.authmechs: Add FIXME about non-working~ inheritance among authmech classes.
---
 x2gobroker/authmechs/base_authmech.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/x2gobroker/authmechs/base_authmech.py b/x2gobroker/authmechs/base_authmech.py
index dd6c667..2973e23 100644
--- a/x2gobroker/authmechs/base_authmech.py
+++ b/x2gobroker/authmechs/base_authmech.py
@@ -28,6 +28,13 @@ class X2GoBrokerAuthMech(object):
     authentication mechanisms go in here.
     """
 
+    ### FIXME: Currently we don't let the other authmech classes inherit
+    # from this class. Technically, this is ok as we override everything in
+    # here in the sub-classes anyway. However, this should be fixed...
+    #
+    # E.g. the unit tests fail if tests.X2GoBrokerAuthMech inherits from
+    # base.X2GoBrokerAuthMech. This needs some investigation.
+
     def authenticate(self, username, password, **kwargs):
         """\
         Dummy :func:`authenticate()` method of :class:`X2GoBrokerAuthMech`.

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2gobroker.git