[X2Go-Commits] [nx-libs] 94/108: XkbSendNames: fix use of uninitialised bytes valgrind error.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository nx-libs.

commit 018b2d0c63505960ba82b4ca1fac7852ee3d5115
Author: Ulrich Sibiller <uli42 at gmx.de>
Date:   Wed Jul 18 23:09:32 2018 +0200

    XkbSendNames: fix use of uninitialised bytes valgrind error.
    
      Backported-to-nx-by: Ulrich Sibiller <uli42 at gmx.de>
    
        commit 8a34d7a8532c7ca013e67307f3baf200167abb92
        Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira at nokia.com>
        Date:   Tue Feb 8 11:10:11 2011 +0200
    
          XkbSendNames: fix use of uninitialised bytes valgrind error.
    
          ==537== Syscall param writev(vector[...]) points to uninitialised byte(s)
          ==537==    at 0x4AB7154: writev (writev.c:51)
          ==537==    by 0x8935B: _XSERVTransWritev (Xtrans.c:912)
          ==537==    by 0x6C55F: FlushClient (io.c:924)
          ==537==    by 0x6CCF3: WriteToClient (io.c:846)
          ==537==    by 0xD51D3: XkbSendNames (xkb.c:3765)
          ==537==    by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825)
          ==537==    by 0x27B7B: Dispatch (dispatch.c:432)
          ==537==    by 0x205B7: main (main.c:291)
          ==537==  Address 0x55899f2 is 154 bytes inside a block of size 1,896 alloc'd
          ==537==    at 0x4834C48: malloc (vg_replace_malloc.c:236)
          ==537==    by 0xD47AF: XkbSendNames (xkb.c:3642)
          ==537==    by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825)
          ==537==    by 0x27B7B: Dispatch (dispatch.c:432)
          ==537==    by 0x205B7: main (main.c:291)
          ==537==  Uninitialised value was created by a heap allocation
          ==537==    at 0x4834C48: malloc (vg_replace_malloc.c:236)
          ==537==    by 0xD47AF: XkbSendNames (xkb.c:3642)
          ==537==    by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825)
          ==537==    by 0x27B7B: Dispatch (dispatch.c:432)
          ==537==    by 0x205B7: main (main.c:291)
    
          Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
          Reviewed-by: Oliver McFadden <oliver.mcfadden at nokia.com>
          Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira at nokia.com>
---
 nx-X11/programs/Xserver/xkb/xkb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nx-X11/programs/Xserver/xkb/xkb.c b/nx-X11/programs/Xserver/xkb/xkb.c
index 3de41c0..f601f04 100644
--- a/nx-X11/programs/Xserver/xkb/xkb.c
+++ b/nx-X11/programs/Xserver/xkb/xkb.c
@@ -3203,7 +3203,7 @@ char *			desc;
 	swapl(&rep->indicators);
     }
 
-    start = desc = (char *)malloc(length);
+    start = desc = (char *)calloc(1, length);
     if ( !start )
 	return BadAlloc;
     if (xkb->names) {

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git