[X2Go-Commits] [nx-libs] 12/23: Screen.c/Events.c: add some FIXMEs

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch 3.6.x
in repository nx-libs.

commit 82c4c28ea726444c355835a5a0850b9dd6865e9a
Author: Ulrich Sibiller <uli42 at gmx.de>
Date:   Tue Apr 10 23:34:14 2018 +0200

    Screen.c/Events.c: add some FIXMEs
---
 nx-X11/programs/Xserver/hw/nxagent/Events.c | 1 +
 nx-X11/programs/Xserver/hw/nxagent/Screen.c | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/nx-X11/programs/Xserver/hw/nxagent/Events.c b/nx-X11/programs/Xserver/hw/nxagent/Events.c
index 5e598f5..177860d 100644
--- a/nx-X11/programs/Xserver/hw/nxagent/Events.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Events.c
@@ -3248,6 +3248,7 @@ int nxagentHandleConfigureNotify(XEvent* X)
 
       pClient = wClient(pWinWindow);
 
+      /* FIXME: override_redirect is always FALSE here */
       if (X -> xconfigure.send_event || !nxagentWMIsRunning ||
                 X -> xconfigure.override_redirect)
       {
diff --git a/nx-X11/programs/Xserver/hw/nxagent/Screen.c b/nx-X11/programs/Xserver/hw/nxagent/Screen.c
index b374b20..39a5b77 100644
--- a/nx-X11/programs/Xserver/hw/nxagent/Screen.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Screen.c
@@ -1891,6 +1891,7 @@ N/A
     if (nxagentUserGeometry.flag & WidthValue || nxagentUserGeometry.flag & HeightValue)
       sizeHints.flags |= USSize;
 
+    /* FIXME: deprecated, replaced by XSetWmProperties() */
     XSetStandardProperties(nxagentDisplay,
                            nxagentDefaultWindows[pScreen->myNum],
                            nxagentWindowName,
@@ -1976,6 +1977,8 @@ N/A
                 deleteWMatom);
     #endif
 
+    /* FIXME: This doing the same thing in both cases. The
+       comments do not seem accurate (anymore?) */
     if (nxagentOption(Rootless) == False)
     {
       /*

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git