[X2Go-Commits] [nx-libs] 16/19: Loop.cpp: fix memleak happening with unknown tcp host

git-admin at x2go.org git-admin at x2go.org
Sat Dec 30 03:35:17 CET 2017


This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch 3.6.x
in repository nx-libs.

commit 9e8bd2e1b6029ef04dec424fefcdf8842a0daf0f
Author: Ulrich Sibiller <uli42 at gmx.de>
Date:   Wed Dec 27 21:13:39 2017 +0100

    Loop.cpp: fix memleak happening with unknown tcp host
    
    ==28424== 6 bytes in 1 blocks are definitely lost in loss record 1 of 7
    ==28424==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==28424==    by 0x541D4D9: strndup (strndup.c:43)
    ==28424==    by 0x4E8AD4B: ChannelEndPoint::getTCPHostAndPort(char**, long*) const (ChannelEndPoint.cpp:311)
    ==28424==    by 0x4EBE9CC: ConnectToRemote(ChannelEndPoint&) (Loop.cpp:6656)
    ==28424==    by 0x4EB0A4C: SetupProxyConnection() (Loop.cpp:3205)
    ==28424==    by 0x4EDC81A: handleNegotiationInLoop(int&, fd_set&, fd_set&, timeval&) (Loop.cpp:14308)
    ==28424==    by 0x4EAE40F: NXTransPrepare (Loop.cpp:2576)
    ==28424==    by 0x4EAA801: NXTransContinue (Loop.cpp:1610)
    ==28424==    by 0x4EB50C9: WaitCleanup() (Loop.cpp:4436)
    ==28424==    by 0x4EA9507: NXTransProxy (Loop.cpp:1235)
    ==28424==    by 0x400B2A: main (Main.c:111)
---
 nxcomp/src/Loop.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nxcomp/src/Loop.cpp b/nxcomp/src/Loop.cpp
index 1e77038..b0b778a 100644
--- a/nxcomp/src/Loop.cpp
+++ b/nxcomp/src/Loop.cpp
@@ -6482,6 +6482,7 @@ int PrepareProxyConnectionTCP(char** hostName, long int* portNum, int* timeout,
         cerr << "Error" << ": Unknown remote host '"
          << *hostName << "'.\n";
 
+    SAFE_FREE(*hostName);
     HandleCleanup();
   }
 

--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/nx-libs.git


More information about the x2go-commits mailing list