[X2Go-Commits] [x2go-keyring] 07/15: runtests: use more quotes and curly braces.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository x2go-keyring.

commit 06e8a4cf87e3e86fd6336f7c27ea4517c98fb8d2
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Sun Sep 18 04:47:12 2016 +0200

    runtests: use more quotes and curly braces.
---
 debian/changelog |    1 +
 runtests         |   30 +++++++++++++++---------------
 2 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index e3f13a3..d36ee97 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,7 @@ x2go-keyring (2014.07.09) UNRELEASED; urgency=medium
   * t/keyids-complete.t: even more quotes!
   * t/keyids-complete.t: use the last directory in the stack instead of the
     top-level directory.
+  * runtests: use more quotes and curly braces.
 
  -- Mike Gabriel <mike.gabriel at das-netzwerkteam.de>  Wed, 09 Jul 2014 20:10:47 +0200
 
diff --git a/runtests b/runtests
index 64959bd..75b96ed 100755
--- a/runtests
+++ b/runtests
@@ -1,33 +1,33 @@
 #!/bin/sh
 set -e
 
-fail=0
-total=0
+fail="0"
+total="0"
 
-for keyring in x2go-maintainers-gpg x2go-keyring-gpg; do
-	if [ ! -e output/keyrings/$keyring ]; then
-		echo "** $keyring does not exist, cannot run test suite" >&2
-		exit 1
+for keyring in "x2go-maintainers-gpg" "x2go-keyring-gpg"; do
+	if [ ! -e "output/keyrings/${keyring}" ]; then
+		echo "** ${keyring} does not exist, cannot run test suite" >&2
+		exit "1"
 	fi
 done
 
 export GNUPGHOME=`pwd`/gpghomedir
-mkdir "$GNUPGHOME"
-chmod 700 "$GNUPGHOME"
+mkdir "${GNUPGHOME}"
+chmod 700 "${GNUPGHOME}"
 
 for t in t/*.t; do
 	total=`expr $total + 1`
-	if ! $t; then
-		echo "test $t failed" >&2
-		fail=`expr $fail + 1`
+	if ! "${t}"; then
+		echo "test ${t} failed" >&2
+		fail=`expr "${fail}" + 1`
 	fi
 done
 
-rm -r "$GNUPGHOME"
+rm -r "${GNUPGHOME}"
 
-if [ "$fail" -gt 0 ]; then
-	echo "** failed $fail/$total tests" >&2
-	exit 1
+if [ "${fail}" -gt 0 ]; then
+	echo "** failed ${fail}/${total} tests" >&2
+	exit "1"
 else
 	echo "** all tests succeeded"
 fi

--
Alioth's /srv/git/code.x2go.org/x2go-keyring.git//..//_hooks_/post-receive-email on /srv/git/code.x2go.org/x2go-keyring.git