[X2Go-Commits] [maintenancescripts] 10/10: git/hooks/x2go-post-receive-close-bugs: more curly braces, quoting and backtick to $() changes.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository maintenancescripts.

commit b02a6f19dcce7edbd3e9b55122df2008d73acdec
Author: Mihai Moldovan <ionic at ionic.de>
Date:   Mon Feb 23 21:34:34 2015 +0100

    git/hooks/x2go-post-receive-close-bugs: more curly braces, quoting and backtick to $() changes.
---
 git/hooks/x2go-post-receive-close-bugs |   44 ++++++++++++++++----------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/git/hooks/x2go-post-receive-close-bugs b/git/hooks/x2go-post-receive-close-bugs
index 28217c9..24ae34a 100755
--- a/git/hooks/x2go-post-receive-close-bugs
+++ b/git/hooks/x2go-post-receive-close-bugs
@@ -27,45 +27,45 @@ BASEURL="http://code.x2go.org/gitweb?p=${GIT_REPO_NAME}"
 
 PROJECT="${GIT_REPO_NAME//.git/}"
 
-tempdir=`mktemp -d`
+tempdir="$(mktemp -d)"
 trap "rm -rf \"${tempdir}\"" EXIT
 
-send_mail() { # send_mail bugno revno diff_file
-    local bug="$1"
-    local fixed_in_version="$2"
-    local oldrev="$3"
-    local newrev="$4"
-    local diff="$5"
-    local from=$(git show -s --pretty='format:%cn <%ce>' `git rev-parse --verify ${newrev}^{commit}` |
-                 perl -CI -MEncode -e 'print Encode::encode("MIME-Q", <STDIN>)')
+function send_mail() { # send_mail bugno revno diff_file
+    local bug="${1}"
+    local fixed_in_version="${2}"
+    local oldrev="${3}"
+    local newrev="${4}"
+    local diff="${5}"
+    local from="$(git show -s --pretty='format:%cn <%ce>' "$(git rev-parse --verify "${newrev}^{commit}")" |
+                  perl -CI -MEncode -e 'print Encode::encode("MIME-Q", <STDIN>)')"
     (cat <<EOF
-From: $from
-To: $bug-submitter at bugs.x2go.org
-Cc: control at bugs.x2go.org, $bug at bugs.x2go.org
-Subject: X2Go issue (in src:$PROJECT) has been marked as closed
+From: ${from}
+To: ${bug}-submitter at bugs.x2go.org
+Cc: control at bugs.x2go.org, ${bug}@bugs.x2go.org
+Subject: X2Go issue (in src:${PROJECT}) has been marked as closed
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 Content-Transfer-Encoding: 8bit
 
-close #$bug
+close #${bug}
 thanks
 
 Hello,
 
-we are very hopeful that X2Go issue #$bug reported by you
-has been resolved in the new release ($version) of the
-X2Go source project »src:$PROJECT«.
+we are very hopeful that X2Go issue #${bug} reported by you
+has been resolved in the new release (${version}) of the
+X2Go source project »src:${PROJECT}«.
 
-You can view the complete changelog entry of src:$PROJECT ($version)
+You can view the complete changelog entry of src:${PROJECT} (${version})
 below, and you can use the following link to view all the code changes
-between this and the last release of src:$PROJECT.
+between this and the last release of src:${PROJECT}.
 
-    ${BASEURL};a=commitdiff;h=$(git rev-parse $newrev);hp=$(git rev-parse $oldrev)
+    ${BASEURL};a=commitdiff;h=$(git rev-parse ${newrev});hp=$(git rev-parse ${oldrev})
 
 If you feel that the issue has not been resolved satisfyingly, feel
 free to reopen this bug report or submit a follow-up report with
 further observations described based on the new released version
-of src:$PROJECT.
+of src:${PROJECT}.
 
 Thanks a lot for contributing to X2Go!!!
 
@@ -74,7 +74,7 @@ X2Go Git Admin (on behalf of the sender of this mail)
 
 ---
 EOF
-    cat "$diff") | /usr/sbin/sendmail -oi -t
+    cat "${diff}") | /usr/sbin/sendmail -oi -t
 }
 
 ## FIXME ## really go through this some time...

--
Alioth's /srv/git/_hooks_/post-receive-email on /srv/git/code.x2go.org/maintenancescripts.git