[X2Go-Commits] [python-x2go] 01/01: For reverse port forwardings use IPv4 localhost address only.

[git-admin at x2go.org]

This is an automated email from the git hooks/post-receive script.

x2go pushed a commit to branch master
in repository python-x2go.

commit 64ff151b666179a7982bcff04fb5be7e9d432e8d
Author: Mike Gabriel <mike.gabriel at das-netzwerkteam.de>
Date:   Sun Aug 31 17:09:12 2014 +0200

    For reverse port forwardings use IPv4 localhost address only.
---
 debian/changelog |    1 +
 x2go/rforward.py |    6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index eb01178..082aad5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -82,6 +82,7 @@ python-x2go (0.5.0.0-0x2go1) UNRELEASED; urgency=low
       python-gevent (which is available since Python gevent 1.0~). (Fixes:
       #588).
     - Use Xlib to detect client-side destop geometry.
+    - For reverse port forwardings use IPv4 localhost address only.
   * debian/control:
     + Add dependencies: python-requests, python-simplejson.
   * python-x2go.spec:
diff --git a/x2go/rforward.py b/x2go/rforward.py
index 070ac29..5246485 100644
--- a/x2go/rforward.py
+++ b/x2go/rforward.py
@@ -170,7 +170,7 @@ class X2GoRevFwTunnel(threading.Thread):
         """
         if self._accept_channels == False:
             self._accept_channels = True
-            self._requested_port = self.ssh_transport.request_port_forward('', self.server_port, handler=x2go_transport_tcp_handler)
+            self._requested_port = self.ssh_transport.request_port_forward('127.0.0.1', self.server_port, handler=x2go_transport_tcp_handler)
             self.logger('resumed thread: %s' % repr(self), loglevel=log.loglevel_DEBUG)
 
     def notify(self):
@@ -202,14 +202,14 @@ class X2GoRevFwTunnel(threading.Thread):
 
     def _request_port_forwarding(self):
         try:
-            self._requested_port = self.ssh_transport.request_port_forward('', self.server_port, handler=x2go_transport_tcp_handler)
+            self._requested_port = self.ssh_transport.request_port_forward('127.0.0.1', self.server_port, handler=x2go_transport_tcp_handler)
         except paramiko.SSHException:
             # if port forward request fails, we try to tell the server to cancel all foregoing port forward requests on 
             # self.server_port
             self.cancel_port_forward('', self.server_port)
             gevent.sleep(1)
             try:
-                self._requested_port = self.ssh_transport.request_port_forward('', self.server_port, handler=x2go_transport_tcp_handler)
+                self._requested_port = self.ssh_transport.request_port_forward('127.0.0.1', self.server_port, handler=x2go_transport_tcp_handler)
             except paramiko.SSHException, e:
                 if self.session_instance:
                     self.session_instance.HOOK_rforward_request_denied(server_port=self.server_port)

--
Alioth's /srv/git/_hooks_/post-receive-email on /srv/git/code.x2go.org/python-x2go.git