Hi Internationalization Team, I noticed that x2goclient is called "X2Go Client" in English, but the Help drop-down lists "About X2GO client". . There are 2 capitalization issues in that string: 1. The O is capitalized 2. The c is not. I decided that I would try to correct this one strhing, but that involves updating all the translations. As I was updating the translations for that one string, I noticed that there were some other strings where "X2GO" was in all capital letters for a few languages. So I decided to correct those as well. Although I only know English and a little bit of Spanish, I inferred that I should correct those strings because other strings in those same .ts files use "X2Go". Although I have commit access, I have attached a patch file. Please provide feedback. (I am very unfamiliar with the I18n process.) -Mike#2
On 28.06.2015 02:32 AM, Michael DePaulo wrote:
I noticed that x2goclient is called "X2Go Client" in English, but the Help drop-down lists "About X2GO client".
Looks like I've missed that... thanks.
I decided that I would try to correct this one strhing, but that involves updating all the translations.
You do not need to update all translations. In general, regenerating the translation files/templates will also update that string and mark it as fuzzy, so that translators know that this string changed and have to re-translate it.
As I was updating the translations for that one string, I noticed that there were some other strings where "X2GO" was in all capital letters for a few languages. So I decided to correct those as well. Although I only know English and a little bit of Spanish, I inferred that I should correct those strings because other strings in those same .ts files use "X2Go".
That's probably all the other places that I *did* catch. The general deal is this: as discussed last week at the Gathering, I need to update the translation files and have translators rework them, as a lot of strings changed or were added. Please go ahead and commit your change to the source file, but leave the translation files untouched. Mihai
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 28.06.2015 um 03:00 schrieb Mihai Moldovan:
On 28.06.2015 02:32 AM, Michael DePaulo wrote:
I noticed that x2goclient is called "X2Go Client" in English, but the Help drop-down lists "About X2GO client".
Looks like I've missed that... thanks.
Also, as per our "CI", it should be X2GoClient, not X2Go Client, IIRC. You might want to ping h1 just to make sure. - -Stefan - -- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVj7q4AAoJEG7d9BjNvlEZhUMH/i/f7EIfRHXbIK2vXsxgoAgf KcEOAmAfVO7ghB5SgPYpkt0kkkgYspnfJEVR3ExHVC/zaJj/UG9Q7xsHEtyjpqzC zF91KseXQIB7NbY3xBZAetAzI3NMlUUGRqlU23EnQjYMiHHr7AKQsCk8C7HWHvJK Qqi87w6hYOlm3VM9yLj6M3HQ4ZRsCAqlS9K0tTdfTKgbq1udTyOYqdqQqGXzJayp bj4gKk6181HZN+c5GLF2H6tUC8lXphDyiJyAX05Xzp0fRgu3uey4BCoRfNfZiIok GsJ78IDVnQ5ovIGf4LOJ7Ex+H8nVZ27i6rZUkyawPZ8i9M7JV1R/bSW871kuTGA= =67iX -----END PGP SIGNATURE-----
Hi Stefan, On So 28 Jun 2015 11:13:28 CEST, Stefan Baur wrote:
Am 28.06.2015 um 03:00 schrieb Mihai Moldovan:
On 28.06.2015 02:32 AM, Michael DePaulo wrote:
I noticed that x2goclient is called "X2Go Client" in English, but the Help drop-down lists "About X2GO client".
Looks like I've missed that... thanks.
Also, as per our "CI", it should be X2GoClient, not X2Go Client, IIRC. You might want to ping h1 just to make sure.
there have been various spellings around, but never X2GoClient AFAIR. The CI spelling (I desperately hope) currently is "X2Go Client". Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
-
Michael DePaulo -
Mihai Moldovan -
Mike Gabriel -
Stefan Baur