Hi Nito,

On Fr 08 Mai 2015 00:35:09 CEST, Nito Martinez wrote:

Package: nx-libs Version: 3.5.0.28

Description:

The attached patch fixes some compilation errors when the following
macros are enabled: (TEST/DEBUG/DUMP). See the lines:

#undef TEST #undef DEBUG ...

and the conditinal ifdefs

#ifdef TEST #ifdef DEBUG ...

which are normally not compiled.

During debugging and testing when these macros gets activated, there
are some compilation errors, which need to be manually fixed each
time the Macros are enabled. This patch tries to leverage that error.

The patch does not affect code outside of those ifdef, and only
provides developer support.

Regards,

Nito

We (people from X2Go and Arctica) changed the nx-libs development
workflow a bit, recently:

Now, we normally file pull requests (even internally in our team,
except for small fixes) against the nx-libs 3.6.x branch on Github.
All greater code changes happen for nx-libs 3.6.x first and then get
backported to 3.5.0.x later (or not at all). All major commits/change
shall reveive a code review and approval of another dev on the team.

So, the initial bug tracking / pull request tracking for nx-libs has
been relocated to Github. Bugs for nx-libs on the X2Go bug tracker are
for marking PRs or commits worth of being backported to the 3.5.0.x
branch (which is handled by the X2Go devs, mainly Mihai Moldovan at
the time being).

Basic splitup of workload: Arctica Project context maintains nx-libs
3.6.x, X2Go context maintains nx-libs 3.5.0.x.

Also, Mihai fixed several TEST/DEBUG/DUMP issues on both branches
(3.5.0.x and 3.6.x). It may well be that the fixes you provide here
already exist on 3.5.0.x/HEAD (haven't checked that)?

Thus, could you do these following steps:

o rebase your patch against nx-libs 3.6.x branch o clone https://github.com/ArcticaProject/nx-libs o create a pr/<describe-what-your-code-does> branch on your account o file a PR against ArcticaProject/nx-libs 3.6.x branch o wait for Ionic or me to review

In the future, I'd be happy to welcome you as another potential pull
request reviewer, so we can distribute the workload even better. Once
I see your PR, I will grant you write/commit access to nx-libs on
github.com/ArcticaProject.

Greets, Mike

DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...

Processing control commands:

tags -1 fixed-upstream Bug #866 [nx-libs] Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support) Added tag(s) fixed-upstream. fixed -1 3.5.99.0 Bug #866 [nx-libs] Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support) There is no source info for the package 'nx-libs' at version '3.5.99.0' with architecture '' Unable to make a source version for version '3.5.99.0' Marked as fixed in versions 3.5.99.0. forwarded -1 https://github.com/ArcticaProject/nx-libs/pull/26 Bug #866 [nx-libs] Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support) Set Bug forwarded-to-address to 'https://github.com/ArcticaProject/nx-libs/pull/26'.

-- 866: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=866 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems