Bug#742: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0
Package: x2goclient Version: 4.0.3.0
When trying to figure out why I get 'Object::connect: No such slot ONMainWindow::slotSndTunOk(int)' in the debugging output of X2Go Client for Windows 4.0.3.0, I bumped onto a common error: Argument mismatch between function call and function definition. That prevents slotSndTunOk() from ever executing.
slotStartParec() depends on slotSndTunOk() to execute parec. Executing parec was needed due to a PulseAudio's bug as explained in http://x2go-dev.x2go.narkive.com/wNgRoxTO/parec
One peculiar thing is that after fixing that mismatch, which enabled parec to execute, x2goclient became extremely sluggish. The only way to revert things back to normal was to prevent parec from ever executing. It seems that parec in not needed now that X2Go Client uses PulseAudio 5.0.
The attached patch saves x2goclient from calling slotStartParec() once per second unnecessarily.
Dept. of Applied Informatics, University of Macedonia George Trakatelis
Control: tag -1 patch
Hi George, hi Mike#2,
On Mi 14 Jan 2015 20:05:46 CET, George Trakatelis wrote:
When trying to figure out why I get 'Object::connect: No such slot ONMainWindow::slotSndTunOk(int)' in the debugging output of X2Go Client for Windows 4.0.3.0, I bumped onto a common error: Argument mismatch between function call and function definition. That prevents slotSndTunOk() from ever executing.
slotStartParec() depends on slotSndTunOk() to execute parec. Executing parec was needed due to a PulseAudio's bug as explained in http://x2go-dev.x2go.narkive.com/wNgRoxTO/parec
One peculiar thing is that after fixing that mismatch, which enabled parec to execute, x2goclient became extremely sluggish. The only way to revert things back to normal was to prevent parec from ever executing. It seems that parec in not needed now that X2Go Client uses PulseAudio 5.0.
The attached patch saves x2goclient from calling slotStartParec() once per second unnecessarily.
thanks for providing this patch, George.
@Mike#2: I know that the component owner concept is not yet in
place... But do you feel like taking over bug triaging for X2Go Client
completely (as offered in one of your previous mails). If no, please
me (and others) no via x2go-project ML (because then we need to find a
way of triaging X2Go Client bugs ASAP). If you still volunteer for
this task, feel free to ping me for feedback whenever needed.
From now on, I will hold my feet still for incoming patches if they
don't address pyhoca-gui, pyhoca-cli, python-x2go, x2gobroker or
nx-libs. I will be so free and tag bugs with "patch" whenever I spot a
bug that ships a patch.
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Hi guys,
1st, sorry for not replying earlier. Right now I am trying to manage my inbox better. Ever since I subscribed to the fedora-devel-list & cygwin lists, my inbox has been overloaded.
On Thu, Jan 15, 2015 at 4:04 AM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
Control: tag -1 patch
Hi George, hi Mike#2,
On Mi 14 Jan 2015 20:05:46 CET, George Trakatelis wrote:
[...]
The attached patch saves x2goclient from calling slotStartParec() once per second unnecessarily. thanks for providing this patch, George.
Thanks!
I'll test the patch for regressions. If there are none, I will commit it. (I will however delete that 1 line rather than comment it out.)
@Mike#2: I know that the component owner concept is not yet in place... But do you feel like taking over bug triaging for X2Go Client completely (as offered in one of your previous mails). If no, please me (and others) no via x2go-project ML (because then we need to find a way of triaging X2Go Client bugs ASAP). If you still volunteer for this task, feel free to ping me for feedback whenever needed.
From now on, I will hold my feet still for incoming patches if they don't address pyhoca-gui, pyhoca-cli, python-x2go, x2gobroker or nx-libs. I will be so free and tag bugs with "patch" whenever I spot a bug that ships a patch.
Mike [...]
Yes, I'll take over this role.
-Mike#2
Processing control commands:
tag -1 patch Bug #742 [x2goclient] Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0 Added tag(s) patch.
-- 742: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=742 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
Processing control commands:
close -1 4.0.3.2 Bug #742 [x2goclient] Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0 There is no source info for the package 'x2goclient' at version '4.0.3.2' with architecture '' Unable to make a source version for version '4.0.3.2' Marked as fixed in versions 4.0.3.2. Bug #742 [x2goclient] Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0 Marked Bug as done
-- 742: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=742 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
-
George Trakatelis -
Michael DePaulo -
Mike Gabriel -
owner＠bugs.x2go.org