Hi All: Stefan asked if I would be willing to help porting some Qt4 projects (x2gclient and X2GoDesktopSharing) to Qt5. He gave me links to the git repositories for these two projects which I have downloaded and have build under Qt 5.9.1.
There were only minimal changes to the DesktopSharing program and virtually no changes to the client system at all.
So any way I've got a clean build of both.
I have no idea of your testing regimes or code submission guidelines, so I'd appreciate someone letting me know what's next.
Any ways, I'm glad to help.
-rick
-- Rick Gregory rgregory@gbgsoft.com www.gbgsoft.com 647-483-3488 800-413-3691
On 09/08/2017 08:26 PM, rgregory wrote:
There were only minimal changes to the DesktopSharing program and virtually no changes to the client system at all.
Well, besides package management, I'm sure. Did you take a stab at that?
I have no idea of your testing regimes or code submission guidelines, so I'd appreciate someone letting me know what's next.
Please attach patches to bug #864.
Mihai
Hi Mihai - I tried submitting 2 patches but received the following message:
<submit@bugs.x2go.org>: 148.251.201.107 does not like recipient. Remote host said: 550 5.1.1<submit@ymir.das-netzwerkteam.de>: Recipient address rejected: User unknown in local recipient table Giving up on 148.251.201.107.
Also, I'm not quite sure what you mean by package management. Do you mean something like qpm? https://www.qpm.io/
-rick
On 17-09-08 05:31 PM, Mihai Moldovan wrote:
On 09/08/2017 08:26 PM, rgregory wrote:
There were only minimal changes to the DesktopSharing program and virtually no changes to the client system at all. Well, besides package management, I'm sure. Did you take a stab at that?
I have no idea of your testing regimes or code submission guidelines, so I'd appreciate someone letting me know what's next. Please attach patches to bug #864.
Mihai
-- Rick Gregory rgregory@gbgsoft.com www.gbgsoft.com 647-483-3488 800-413-3691
On 09/11/2017 04:15 PM, rgregory wrote:
Hi Mihai - I tried submitting 2 patches but received the following message:
<submit@bugs.x2go.org>: 148.251.201.107 does not like recipient. Remote host said: 550 5.1.1 <submit@ymir.das-netzwerkteam.de>: Recipient address rejected: User unknown in local recipient table Giving up on 148.251.201.107.
submit@bugs.x2go.org is for new bugs and requires correct (pseudo) headers to be set. To attach patches to an existing report, simply write an email or reply to bugno@bugs.x2go.org (e.g., in this instance, 864@bugs.x2go.org.)
Also, I'm not quite sure what you mean by package management. Do you mean something like qpm? https://www.qpm.io/
We build packages for a lot of distributions. Currently, Qt4 is hardcoded in debian/{control,rules}, x2goclient.spec and at least the Makefile. That's probably the real grind.
Mihai
Hi,
On Mo 11 Sep 2017 21:33:29 CEST, Mihai Moldovan wrote:
On 09/11/2017 04:15 PM, rgregory wrote:
Hi Mihai - I tried submitting 2 patches but received the following message:
<submit@bugs.x2go.org>: 148.251.201.107 does not like recipient. Remote host said: 550 5.1.1 <submit@ymir.das-netzwerkteam.de>:
Recipient address rejected: User unknown in local recipient table Giving up on 148.251.201.107.submit@bugs.x2go.org is for new bugs and requires correct (pseudo)
headers to be set. To attach patches to an existing report, simply write an email
or reply to bugno@bugs.x2go.org (e.g., in this instance, 864@bugs.x2go.org.)Also, I'm not quite sure what you mean by package management. Do you mean something like qpm? https://www.qpm.io/
We build packages for a lot of distributions. Currently, Qt4 is hardcoded in debian/{control,rules}, x2goclient.spec and at least the Makefile. That's probably the real grind.
For the .deb packages, Debian-wise, I propose dropping wheezy support
and making sure that X2Go Client builds against Qt5 in Debian jessie
(afaik, that should be doable).
Ubuntu-wise, Qt5 was available in Ubuntu 14.04 already, as well, not
sure how complete the packaging was at that time. Ubuntu trusty is the
oldest .deb-based distro to support, I guess. So, if you can get X2Go
CLient to build against Qt5 from Ubuntu 14.04, then the packaging
should be trivial.
Alternatively, one could build-depend on Qt5 _or_ Qt4 in
debian/control, let the build script setup the build env (if Qt5 is
available, then pull-in Qt5, otherwise pull-in Qt4), then test what's
available and build against what's availeble via X2Go Client's Makefile.
For RPM-based distros, the x2goclient.spec can be if-claused heavily
to support both build paths (Qt4 and Qt5).
Needs some patient to get that fiddled together, but it's doable.
Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
On 09/12/2017 10:02 AM, Mike Gabriel wrote:
For the .deb packages, Debian-wise, I propose dropping wheezy support
and making sure that X2Go Client builds against Qt5 in Debian jessie
(afaik, that should be doable).
Wheezy is still supported through Debian LTS for the next year.
Alternatively, one could build-depend on Qt5 _or_ Qt4 in
debian/control, let the build script setup the build env (if Qt5 is
available, then pull-in Qt5, otherwise pull-in Qt4), then test what's
available and build against what's availeble via X2Go Client's Makefile.
I have a setup that automatically can depend upon a choice from debian/rules. It's hackishly, but so far has been working good to either build the MATE bindings against GTK+ 2 or 3.
I guess I will employ the same scheme here as well.
For RPM-based distros, the x2goclient.spec can be if-claused heavily
to support both build paths (Qt4 and Qt5).
Yeah, but there's no current RPM-based distro we still support that doesn't have Qt5, IIRC. We can switch to Qt5 unconditionally there I guess.
Mihai
-
Mihai Moldovan -
Mike Gabriel -
rgregory