Package: nx-libs Version: 3.5.0.16 Tags: patch
I've been seeing the parallel build issues in nx-libs mentioned recently. Tracking the build closer, it looks like a lot is getting built during the "make depend" stage:
depending in lib/X11... make[5]: Entering directory `/builddir/build/BUILD/nx-libs-HEAD/nx-X11/lib/X11' cd ../../../nxcomp && /builddir/build/BUILD/nx-libs-HEAD/my_configure
(I've set CONFIGURE to point to my_configure following the opensuse buildserver rpm specfile)
Now, why is this happening?
In nx-X11/lib/X11/Makefile there are deps like:
depend:: $(NX_XCOMPLIBTARGET)
Which triggers a build of nxcomp. These come from nx-X11/lib/X11/Imakefile and are complete nonsense - why are we building things during the depend stage? Removing those exposes the lack of proper build dependencies between NX_X11, Xcomp, and Xcompext (and what the previous depend hack was trying to work around).
The attached patch I believe fixes both of these issues, and hopefully fixes the parallel make issue as well. It's been building fine for me now.
-- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder Office FAX: 303-415-9702 3380 Mitchell Lane orion@nwra.com Boulder, CO 80301 http://www.nwra.com
Hi Orion, hi Reinhard,
On Fr 14 Dez 2012 19:18:37 CET Orion Poplawski wrote:
[...]
The attached patch I believe fixes both of these issues, and
hopefully fixes the parallel make issue as well. It's been building
fine for me now.
Reinhard, can you test the patch attached to this bug on your 32 core
-j20 builder machine?
Greets, Mike
--
DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
On Fri, Dec 14, 2012 at 11:11 PM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
Hi Orion, hi Reinhard,
On Fr 14 Dez 2012 19:18:37 CET Orion Poplawski wrote:
[...]
The attached patch I believe fixes both of these issues, and hopefully fixes the parallel make issue as well. It's been building fine for me now.
Reinhard, can you test the patch attached to this bug on your 32 core -j20 builder machine?
The patch itself is not minimal. However, I think it touches the critical part. Based on Orions proposed patch, I have edit debian/patches/031_nx-X11_parallel-make.full.patch, which I think is broken.
The first build seems to succeed, but I want to do a few additional tests before pushing to git.
Thanks Orion for pushing in the right direction, I think your approach is correct.
-- regards, Reinhard
rtag #87 pending thanks
Hi Reinhard, hi Orion,
On Sa 15 Dez 2012 14:24:34 CET Reinhard Tartler wrote:
On Fri, Dec 14, 2012 at 11:11 PM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
Hi Orion, hi Reinhard,
On Fr 14 Dez 2012 19:18:37 CET Orion Poplawski wrote:
[...]
The attached patch I believe fixes both of these issues, and hopefully fixes the parallel make issue as well. It's been building fine for me now.
Reinhard, can you test the patch attached to this bug on your 32 core -j20 builder machine?
The patch itself is not minimal. However, I think it touches the critical part. Based on Orions proposed patch, I have edit debian/patches/031_nx-X11_parallel-make.full.patch, which I think is broken.
The first build seems to succeed, but I want to do a few additional tests before pushing to git.
Thanks Orion for pushing in the right direction, I think your approach is correct.
I have added a closure for this issue to the changelog: http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=f2011a718adfab50d05...
The issue itself got fixed by this commit: http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=d123923a501758cace3...
Good work you guys!!!
Mike
--
DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
-
Mike Gabriel -
Orion Poplawski -
Reinhard Tartler