Package: <x2goserver> Body: Package: <x2goserver> Version: <Not exactly sure where to check. Please let me know> Not sure, if this is a real bug. But it seems to have been an issue before (See here: https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=227)
Surprisingly, without any known changes, we suddenly receive a new error when establishing previously error free connections. The following error appears in the client (similar to the one described here in 2014: https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=227) , however the connection is established as usual without any apparent problems.
So why does this annoying error message appear and how can it be fixed?
*Connection failed. Cannot create remote file ~templatemate3/.x2go/ssh/key.TJ4977 - SCP: Warning: status code 1 received: scp: ~templatemate3/.x2go/ssh: No such file or directory* Let me know if you need any further info.
Client and Server running Ubuntu 18-04 LTS
Thank you!
Is this similar issue probably related? Can we narrow down the reason for this bug? I can reproduce it on at least 2 different remote instances of Ubuntu, however I have only one client machine to test from at present. https://bugzilla.redhat.com/show_bug.cgi?id=1057871#c19
Am Sa., 14. Dez. 2019 um 19:10 Uhr schrieb Alexanderstr Miete < alexstrbonn@gmail.com>:
Package: <x2goserver> Body: Package: <x2goserver> Version: <Not exactly sure where to check. Please let me know> Not sure, if this is a real bug. But it seems to have been an issue before (See here: https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=227)
Surprisingly, without any known changes, we suddenly receive a new error when establishing previously error free connections. The following error appears in the client (similar to the one described here in 2014: https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=227) , however the connection is established as usual without any apparent problems.
So why does this annoying error message appear and how can it be fixed?
*Connection failed. Cannot create remote file ~templatemate3/.x2go/ssh/key.TJ4977 - SCP: Warning: status code 1 received: scp: ~templatemate3/.x2go/ssh: No such file or directory* Let me know if you need any further info.
Client and Server running Ubuntu 18-04 LTS
Thank you!
x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Control: forwarded -1 https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1856795 Control: reassign -1 x2goclient 4.1.2.1 Control: close -1
Is this similar issue probably related? Can we narrow down the reason for this bug? I can reproduce it on at least 2 different remote instances of Ubuntu, however I have only one client machine to test from at present. https://bugzilla.redhat.com/show_bug.cgi?id=1057871#c19
Ubuntu applied a series of patches to fix a CVE in their libssh package and broke scp support as part of that.
Please check the attached bug report.
Nothing to do for us here, unfortunately.
Mihai
Interesting. Thanks for the update. I also notice that no sound via standard PulseAudio (which previously worked) is transmitted to the client anymore from any remote machine (default port 4713, SSH port forwarding). Is that related to this bug here too? https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1856795 or something else that requires looking into?
Am Mi., 18. Dez. 2019 um 04:38 Uhr schrieb Mihai Moldovan <ionic@ionic.de>:
Control: forwarded -1 https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1856795 Control: reassign -1 x2goclient 4.1.2.1 Control: close -1
- On 12/16/19 7:42 PM, Alexanderstr Miete wrote:
Is this similar issue probably related? Can we narrow down the reason for this bug? I can reproduce it on at least 2 different remote instances of Ubuntu, however I have only one client machine to test from at present. https://bugzilla.redhat.com/show_bug.cgi?id=1057871#c19
Ubuntu applied a series of patches to fix a CVE in their libssh package and broke scp support as part of that.
Please check the attached bug report.
Nothing to do for us here, unfortunately.
Mihai
Interesting. Thanks for the update. I also notice that no sound via standard PulseAudio (which previously worked) is transmitted to the client anymore from any remote machine (default port 4713, SSH port forwarding). Is that related to this bug here too? https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1856795 or something else that requires looking into?
Very likely, yes. We use scp to transfer some files (including the cookie file), so if scp is broken within libssh that'll fail to work as well.
Mihai
tag #1428 pending fixed #1428 4.1.2.2 thanks Hello, X2Go issue #1428 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=ce559d1 The issue will most likely be fixed in src:x2goclient (4.1.2.2). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit ce559d163a943737fe4160f7233925df2eee1f9a Author: Mihai Moldovan <ionic@ionic.de> Date: Fri Dec 20 20:27:31 2019 +0100 src/sshprocess.cpp: strip ~/, ~user{,/}, ${HOME}{,/} and $HOME{,/} from destination paths in scp mode. Fixes: #1428. This was already necessary for pascp (PuTTY-based Windows solution for Kerberos support), but newer libssh versions with the CVE-2019-14889 also interpret paths as literal strings. diff --git a/debian/changelog b/debian/changelog index 504d6ae..9f84281 100644 --- a/debian/changelog +++ b/debian/changelog @@ -135,6 +135,11 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium sound weird first, but this behavior is consistent between all applications - tray icons can be clicked via either button and will always trigger a context menu. Let X2Go Client behave the same way. + - src/sshprocess.cpp: strip ~/, ~user{,/}, ${HOME}{,/} and $HOME{,/} from + destination paths in scp mode. Fixes: #1428. This was already necessary + for pascp (PuTTY-based Windows solution for Kerberos support), but newer + libssh versions with the CVE-2019-14889 also interpret paths as literal + strings. * debian/control: + Add build-depend on pkg-config. * x2goclient.spec:
Processing commands for control@bugs.x2go.org:
tag #1428 pending Bug #1428 [x2goclient] Connection failed. Cannot create remote file Bug #1429 [x2goclient] Tilde expansion no longer performed by libssh after CVE-2019-14889 Added tag(s) pending. Added tag(s) pending. fixed #1428 4.1.2.2 Bug #1428 [x2goclient] Connection failed. Cannot create remote file Bug #1429 [x2goclient] Tilde expansion no longer performed by libssh after CVE-2019-14889 There is no source info for the package 'x2goclient' at version '4.1.2.2' with architecture '' Unable to make a source version for version '4.1.2.2' Marked as fixed in versions 4.1.2.2. Marked as fixed in versions 4.1.2.2. thanks Stopping processing here.
1428: bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1428 1429: bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1429 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
Hi, On Fr 20 Dez 2019 20:32:49 CET, Mihai Moldovan wrote:
tag #1428 pending fixed #1428 4.1.2.2 thanks
Hello,
X2Go issue #1428 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at:
http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=ce559d1
The issue will most likely be fixed in src:x2goclient (4.1.2.2).
light+love X2Go Git Admin (on behalf of the sender of this mail)
commit ce559d163a943737fe4160f7233925df2eee1f9a Author: Mihai Moldovan <ionic@ionic.de> Date: Fri Dec 20 20:27:31 2019 +0100
src/sshprocess.cpp: strip ~/, ~user{,/}, ${HOME}{,/} and
$HOME{,/} from destination paths in scp mode. Fixes: #1428.
This was already necessary for pascp (PuTTY-based Windows solution for Kerberos support), but newer libssh versions with the CVE-2019-14889 also interpret paths as literal strings.
diff --git a/debian/changelog b/debian/changelog index 504d6ae..9f84281 100644 --- a/debian/changelog +++ b/debian/changelog @@ -135,6 +135,11 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium sound weird first, but this behavior is consistent between all applications - tray icons can be clicked via either button and will always trigger a context menu. Let X2Go Client behave the same way.
- src/sshprocess.cpp: strip ~/, ~user{,/}, ${HOME}{,/} and $HOME{,/} from
necessarydestination paths in scp mode. Fixes: #1428. This was already
support), but newerfor pascp (PuTTY-based Windows solution for Kerberos
as literallibssh versions with the CVE-2019-14889 also interpret paths
* debian/control:strings.
- Add build-depend on pkg-config.
- x2goclient.spec:
Please note that I am currently working on getting this libssh/CVE-2019-14889 robustness patch into Debian [done] and Ubuntu [pending]. Mike -- DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
Hallo Mike, wie siehts mit der Fehlfunktion der Tonübertragung unter Win 10 nach dem großen Update aus? Die Fehlermeldung, die ich geposted habe, scheint darauf zu beruhen, dass Pulseaudio kein sicheres Verzeichnis anlegen kann. Konntest Du das Problem auch lösen? LG Daniel Hi Mike could you also find a workaround for the pulseaudio issue on latest Win 10 ? Sound does not work in X2Go because Pulseaudio can't create a safe directory. Yours Daniel (I am no expert and need to use the win binary, but the nightly build before christmas still didn't work). Sent from MailDroid -----Original Message----- From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de> To: Mihai Moldovan <ionic@ionic.de>, 1428@bugs.x2go.org Cc: 1429@bugs.debian.org, 1428-submitter@bugs.x2go.org Sent: Mi., 25 Dez. 2019 21:25 Subject: [X2Go-Dev] Bug#1428: Bug#1428: X2Go issue (in src:x2goclient) has been marked as pending for release Hi, On Fr 20 Dez 2019 20:32:49 CET, Mihai Moldovan wrote:
tag #1428 pending fixed #1428 4.1.2.2 thanks
Hello,
X2Go issue #1428 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at:
http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=ce559d1
The issue will most likely be fixed in src:x2goclient (4.1.2.2).
light+love X2Go Git Admin (on behalf of the sender of this mail)
commit ce559d163a943737fe4160f7233925df2eee1f9a Author: Mihai Moldovan <ionic@ionic.de> Date: Fri Dec 20 20:27:31 2019 +0100
src/sshprocess.cpp: strip ~/, ~user{,/}, ${HOME}{,/} and
$HOME{,/} from destination paths in scp mode. Fixes: #1428.
This was already necessary for pascp (PuTTY-based Windows solution for Kerberos support), but newer libssh versions with the CVE-2019-14889 also interpret paths as literal strings.
diff --git a/debian/changelog b/debian/changelog index 504d6ae..9f84281 100644 --- a/debian/changelog +++ b/debian/changelog @@ -135,6 +135,11 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium sound weird first, but this behavior is consistent between all applications - tray icons can be clicked via either button and will always trigger a context menu. Let X2Go Client behave the same way.
- src/sshprocess.cpp: strip ~/, ~user{,/}, ${HOME}{,/} and $HOME{,/} from
necessarydestination paths in scp mode. Fixes: #1428. This was already
support), but newerfor pascp (PuTTY-based Windows solution for Kerberos
as literallibssh versions with the CVE-2019-14889 also interpret paths
* debian/control:strings.
- Add build-depend on pkg-config.
- x2goclient.spec:
Please note that I am currently working on getting this libssh/CVE-2019-14889 robustness patch into Debian [done] and Ubuntu [pending]. Mike -- DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
Hi Daniel,
On Mi 25 Dez 2019 22:43:10 CET, info wrote:
Hi Mike could you also find a workaround for the pulseaudio issue on
latest Win 10 ? Sound does not work in X2Go because Pulseaudio can't create a safe directory. Yours Daniel (I am no expert and need to use the win binary, but the nightly
build before christmas still didn't work).
Redirecting (via Cc:) your question to Michael DePaulo (aka Mike#2 in
the X2Go Project, whereas I am Mike#1).
;-)
DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
Hi Mike#1,
I'm assuming this is about the email thread "Pulseaudio issue latest Win 10."
I see that Ionic just added PulseAudio 13.0 to x2goclient-contrib.git (but not x2goclient.git itself yet). https://code.x2go.org/gitweb?p=x2goclient-contrib.git;a=commit;h=83848f5b86b... And I see that he used the OBS to build it like I did: https://build.opensuse.org/project/show/home:Ionic:branches:home:mikedep333:...
I also found this commit that was added to the pulseaudio master branch (after 13.0) on 2020-01-20. It might be a fix: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/97d0eda2562af07b...
-Mike
On Thu, Jan 2, 2020 at 8:30 AM Mike Gabriel < mike.gabriel@das-netzwerkteam.de> wrote:
Hi Daniel,
On Mi 25 Dez 2019 22:43:10 CET, info wrote:
Hi Mike could you also find a workaround for the pulseaudio issue on latest Win 10 ? Sound does not work in X2Go because Pulseaudio can't create a safe directory. Yours Daniel (I am no expert and need to use the win binary, but the nightly build before christmas still didn't work).
Redirecting (via Cc:) your question to Michael DePaulo (aka Mike#2 in the X2Go Project, whereas I am Mike#1).
;-)
Mike
DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
I'm assuming this is about the email thread "Pulseaudio issue latest Win 10."
I see that Ionic just added PulseAudio 13.0 to x2goclient-contrib.git (but not x2goclient.git itself yet). https://code.x2go.org/gitweb?p=x2goclient-contrib.git;a=commit;h=83848f5b86b...
Yep, I haven't seen any new builds yet so decided to fork and work on it. I build 13.0 within Leap 15.1 and got rid of the aggregate stuff that now breaks due to the repository using multibuilds... or something like that.
The change for X2Go Client is stashed in my repo, but not pushed yet, because Jenkins is currently broken/down. Upstream bug that I ran into without knowing beforehand: https://issues.jenkins-ci.org/browse/JENKINS-60857
I hope that the new weekly build released today will fix that. We won't have new builds until that's fixed. Thought about making a list post announcing that, but given that they expect a new build today it didn't sound reasonable.
And I see that he used the OBS to build it like I did: https://build.opensuse.org/project/show/home:Ionic:branches:home:mikedep333:...
I also found this commit that was added to the pulseaudio master branch (after 13.0) on 2020-01-20. It might be a fix: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/97d0eda2562af07b...
Oh, thanks. Backporting that shouldn't be difficult, so I guess I should do that?
Mihai
On Sun, Jan 26, 2020 at 10:58 AM Mihai Moldovan <ionic@ionic.de> wrote:
- On 1/26/20 4:15 PM, Mike DePaulo wrote:
I'm assuming this is about the email thread "Pulseaudio issue latest Win 10."
I see that Ionic just added PulseAudio 13.0 to x2goclient-contrib.git (but not x2goclient.git itself yet). https://code.x2go.org/gitweb?p=x2goclient-contrib.git;a=commit;h=83848f5b86b...
Yep, I haven't seen any new builds yet so decided to fork and work on it. I build 13.0 within Leap 15.1 and got rid of the aggregate stuff that now breaks due to the repository using multibuilds... or something like that.
OBS may provide pulseaudio with newer dependencies (DLLs from dependent packages). I don't think it rebuilds it IIRC, just the download script downloads newer deps.
Pulseaudio will never get a newer version build on OBS unless I myself work on it (or someone else does on their fork.) (If OBS supports collaborative development now on repos, I'd very much like to do that.)
The change for X2Go Client is stashed in my repo, but not pushed yet, because Jenkins is currently broken/down. Upstream bug that I ran into without knowing beforehand: https://issues.jenkins-ci.org/browse/JENKINS-60857
I hope that the new weekly build released today will fix that. We won't have new builds until that's fixed. Thought about making a list post announcing that, but given that they expect a new build today it didn't sound reasonable.
Yeah. A common workaround is to replace the pulseaudio folder under C:\Program Files (x86)\x2goclient\ with the newer version (same for VcXsrv), unless the args to launch it have changed. I often test it that way before I make a commit to x2goclient.git.
And I see that he used the OBS to build it like I did: https://build.opensuse.org/project/show/home:Ionic:branches:home:mikedep333:...
I also found this commit that was added to the pulseaudio master branch (after 13.0) on 2020-01-20. It might be a fix: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/97d0eda2562af07b...
Oh, thanks. Backporting that shouldn't be difficult, so I guess I should do that?
I recommend backporting the patch.
Mihai
-Mike
OBS may provide pulseaudio with newer dependencies (DLLs from dependent packages). I don't think it rebuilds it IIRC, just the download script downloads newer deps.
The pulseaudio-dependencies aggregate is unneeded and actually harmful nowadays. Instead of copying the dependencies into your own repository via an aggregate, you can build directly against the additional repositories. AFAIK, OBS will make sure that it's up-to-date, including rebuilds if dependencies change.
The download script looks weird... it just fetches the git repository and repackages it. Probably useful for testing manual builds, but it isn't used automatically anywhere.
Pulseaudio will never get a newer version build on OBS unless I myself work on it (or someone else does on their fork.) (If OBS supports collaborative development now on repos, I'd very much like to do that.)
I keep wondering about that... is X2Go really the only user of PulseAudio on Windows? Or do the other users just stay on the old 1.0 version (whatever it was) from 10 years ago?
But yeah, that's why I forked and updated it. OBS supports collaborative development in general though, so we could just use one repo. I didn't mean to do this privately. :)
I recommend backporting the patch.
Okay, will do so later and update the contrib repository. Luckily I won't have to also update the dependencies.
Mihai
Okay, will do so later and update the contrib repository. Luckily I won't have to also update the dependencies.
Done.
Daniel, if you care to test, please replace the files in your Windows 10 client's pulse subdirectory with these files: https://code.x2go.org/gitweb?p=x2goclient-contrib.git;a=tree;f=pulse/13.0-lp...
Does the issue persist with the updated version?
Providing a full new nightly build will be difficult unless I downgrade Jenkins, which I'd prefer not to. Still waiting on the Jenkins project to provide a new, working weekly release.
Mihai
close #1428 thanks
Hello,
we are very hopeful that X2Go issue #1428 reported by you has been resolved in the new release (4.1.2.2) of the X2Go source project »src:x2goclient«.
You can view the complete changelog entry of src:x2goclient (4.1.2.2) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient.
http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=e70a27961cf391406c13e52fa54f4731fa8ca189;hp=84dcac55b72c6c09f2cdddcd5bde5137a441223d
If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient.
Thanks a lot for contributing to X2Go!!!
light+love X2Go Git Admin (on behalf of the sender of this mail)
X2Go Component: src:x2goclient Version: 4.1.2.2-0x2go1 Status: RELEASE Timestamp: 1581543720 Date: Wed, 12 Feb 2020 22:42:00 +0100 Fixes: 1307 1320 1393 1418 1425 1428 Changes: x2goclient (4.1.2.2-0x2go1) RELEASED; urgency=medium . [ Oleksandr Shneyder ]
Processing commands for control@bugs.x2go.org:
close #1428 Bug #1428 [x2goclient] Connection failed. Cannot create remote file Bug #1429 [x2goclient] Tilde expansion no longer performed by libssh after CVE-2019-14889 Marked Bug as done Marked Bug as done thanks Stopping processing here.
1428: bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1428 1429: bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1429 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems