On 11.02.2015 12:30 AM, Orion Poplawski wrote:

...

Dear all

The X2Go project is proud to announce a new release of the X2Go component ,,cups-x2go''.

[...]

• cups-x2go.spec:
  • Pull-in packaging stuff from Jan Engelhardt's .spec files on https://build.opensuse.org/package/view_file/X11:RemoteDesktop:x2go.
  • Make package arch-any, not noarch. I don't understand the reason for this change, it seems clearly to be a noarch

On 02/10/2015 01:24 PM, Mihai Moldovan wrote: package.

Please take that up with Mike#1 and Jan, as the original authors.

I'm willing to revert the patch, because the package clearly looks noarch. Jan probably forgot the statement and Mike#1 just pulled it over. I'm just guessing, though.

Also, FYI:

• on Fedora ssh is in openssh-clients.

Thanks. Does that hold for all versions?

• cups backends go in %{_prefix}/lib, not %_libexecdir

Thanks again. This seems to also hold for OpenSUSE. Printer vendors seem to prefer libexec for their backends/drivers, just like Apple does. We should probably follow what the Linux distros do, though.

• You install the cups-x2go with 755:

install -pm755 cups-x2go %{buildroot}%{_prefix}/lib/cups/backend/

then change it to 700 in %files:

%attr(0700,root,root) %_libexecdir/cups/backend/cups-x2go

Is there any reason for it to be 700? I see other stuff in that directory is a mix:

Yes, quoting from https://build.opensuse.org/package/view_file/X11:RemoteDesktop:x2go/cups-x2g...

# The cups-x2go backends wants root permissions. So give it to them. # http://www.cups.org/documentation.php/doc-1.4/man-backend.html says: # “Backends without world execute permissions are run as the root user. # Otherwise, the backend is run using the unprivileged user account, # typically "lp".”

This is still true for CUPS 2.0.

I think the permissions are fine here.

• I have no idea about non-Fedora/RHEL distros, but %defattr() is no longer needed for any modern (RHEL5+) rpm systems.

This is just my personal habit, but I like being more verbose better than not to define something. If it's OK with you, I'll keep the %deffattr macros.

• Alsi, in Fedora, you should not own directories own by other packages that it requires. I have:

%files %doc ChangeLog COPYING README.txt %{_prefix}/lib/cups/backend/cups-x2go %config(noreplace) %{_sysconfdir}/cups/cups-x2go.conf %{_datadir}/ppd/cups-x2go/ %{_datadir}/x2go/

Good catch, thank you. Additionally, we're missing the documentation. I'll merge that in.

Btw: the other components are scheduled for release some time after Thursday. If you find the time, please take a swift look beforehand.

Mihai

Hi Mihai, hi Orion,

On Mi 11 Feb 2015 00:30:45 CET, Orion Poplawski wrote:

On 02/10/2015 01:24 PM, Mihai Moldovan wrote:

...

Dear all

The X2Go project is proud to announce a new release of the X2Go component ,,cups-x2go''.

New gains of this version of ,,cups-x2go'' are:

o better RPM package support

X2Go Component: cups-x2go Version: 3.0.1.1 Status: RELEASE Date: Tue, 10 Feb 2015 20:03:16 +0100 Changes: cups-x2go (3.0.1.1) RELEASED; urgency=low . [ Mike Gabriel ]

• New upstream version (3.0.1.1):
  • Rename LICENSE.txt to COPYING.
• cups-x2go.spec:
  • Pull-in packaging stuff from Jan Engelhardt's .spec files on https://build.opensuse.org/package/view_file/X11:RemoteDesktop:x2go.

...

 + Make package arch-any, not noarch.

I don't understand the reason for this change, it seems clearly to
be a noarch package.

see
https://jenkins.x2go.org:8443/view/CUPS/job/cups-x2go+nightly+sles-11.3/1/co...

""" (rpmlint says:) [ 19s] ... checking filelist [ 19s] cups-x2go: "/usr/lib64/cups" is not allowed in a noarch package. [ 19s] cups-x2go: "/usr/lib64/cups/backend" is not allowed in a
noarch package. [ 19s] cups-x2go: "/usr/lib64/cups/backend/cups-x2go" is not allowed
in a noarch package. """

Also, FYI:

• on Fedora ssh is in openssh-clients.
• cups backends go in %{_prefix}/lib, not %_libexecdir
• You install the cups-x2go with 755:

install -pm755 cups-x2go %{buildroot}%{_prefix}/lib/cups/backend/

then change it to 700 in %files:

%attr(0700,root,root) %_libexecdir/cups/backend/cups-x2go

Is there any reason for it to be 700? I see other stuff in that directory is a mix:

-rwxr-xr-x. 1 root root 149216 Sep 23 06:37 bluetooth -rwx------. 1 root root 23648 Oct 22 03:30 dnssd

• I have no idea about non-Fedora/RHEL distros, but %defattr() is no longer needed for any modern (RHEL5+) rpm systems.
• Alsi, in Fedora, you should not own directories own by other packages that it requires. I have:

%files %doc ChangeLog COPYING README.txt %{_prefix}/lib/cups/backend/cups-x2go %config(noreplace) %{_sysconfdir}/cups/cups-x2go.conf %{_datadir}/ppd/cups-x2go/ %{_datadir}/x2go/

It seems, that Mihai has started working on this, but builds are
currently failing, it seems. So let's wait for him to figure things out.

Mike

DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...