Hi Uli, (Re-Cc:ing the x2go-dev mailing list to keep Mihai in the loop).
On Mi 03 Jun 2015 14:15:47 CEST, Ulrich Sibiller wrote:
On Wed, Jun 3, 2015 at 12:03 PM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
Ooops. Duplicate work here (a little, but maybe not, because your fixes target specific bugs, so they are valuable for the 3.5.0.x branch, see below)
I don't think that we have wasted time. I needed the first fix anyway (without it can add a new mode with xrandr --newmode, but you cannot remove the mode again with xrandr --rmode) ... And having those fixes in 3.5.x is important.
Yes, I think that was not duplicate work either. Thanks for tracking
those issues down.
I have been working on randr extension 1.5 for nx-libs yesterday and today. https://github.com/ArcticaProject/nx-libs/issues/48#issuecomment-107380480
You state that it is not trivial. I can imagine that the restructed build system and some newly added macros are problematic. What other obstacles did you find so far?
I am still working on the patch rebasing itself (no test build, yet).
I want to keep the diff as minimal as possible, but the X.Org devs
re-formatted their files, so the patches got polluted with a lot of
white space overhead. I am now through with re-editing all files
(yawn... boring task) and will start test-building (fixing macros et
al.) tomorrow. (My notebook died yesterday and I am on my old notebook
now, so things got delayed here).
I will soon push stuff to a branch, but until now the changes are local on my notebook only (work-in-progress).
I am keen on seeing this. Randr 1.5 adds concepts that might simplify my randr code.
I'll be as fast as I can to get something usable out.
For 3.5.0.x -> @Ionic: please use the above commit URL from Uli to pull-in the randr fixes into 3.5.0.x.
backport. Also, is it ok to mark the fixes by a comment as I did or should this information better be moved to the commit log?
They'd better go into the commit log, I'd say.
So then I will create some separate patches. @Ionic: Please delay your pull until I have done that. I think I will create a new branch for them.
@Mihai: I guess, you haven't got the above info. Please wait with
3.5.0.x (or, if ok with you, re-do).
Greets, Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
On Thu, Jun 4, 2015 at 9:52 AM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
I am still working on the patch rebasing itself (no test build, yet). I want to keep the diff as minimal as possible, but the X.Org devs re-formatted their files, so the patches got polluted with a lot of white space overhead. I am now through with re-editing all files (yawn... boring task) and will start test-building (fixing macros et al.) tomorrow. (My notebook died yesterday and I am on my old notebook now, so things got delayed here).
keithp is mentioning a tool called x-indent-all.sh in this commit log: http://cgit.freedesktop.org/xorg/xserver/commit/randr/rrmode.c?id=9838b7032e...
I think you could use that tool to convert the _existing_ randr code and after that the diffs to the current code should be much easier to handle.
I'll be as fast as I can to get something usable out.
Thank you!
@Mihai: I guess, you haven't got the above info. Please wait with 3.5.0.x (or, if ok with you, re-do).
I've already forwarded the previous mail to him.
Uli
On 04.06.2015 09:52 AM, Mike Gabriel wrote:
So then I will create some separate patches. @Ionic: Please delay your pull until I have done that. I think I will create a new branch for them.
@Mihai: I guess, you haven't got the above info. Please wait with
3.5.0.x (or, if ok with you, re-do).
I have been busy with other stuff yesterday, so didn't backport anything yet. Tried fixing the reported keyboard issue on OS X when using Kerberos. While doing this anyway, I also changed the wrapper for commands from sh to bash in x2goclient and added bash a dependency to x2goserver.
I'm hoping this fixes some problems for users who did not set bash (or something mostly bash-compatible) as their main shell, but am not too convinced it was an all-quash.
Mihai
Hi Mihai,
here is the pull request with the backports: https://github.com/ArcticaProject/nx-libs/pull/50
Uli
On Thu, Jun 4, 2015 at 2:51 PM, Mihai Moldovan <ionic@ionic.de> wrote:
On 04.06.2015 09:52 AM, Mike Gabriel wrote:
So then I will create some separate patches. @Ionic: Please delay your pull until I have done that. I think I will create a new branch for them.
@Mihai: I guess, you haven't got the above info. Please wait with 3.5.0.x (or, if ok with you, re-do).
I have been busy with other stuff yesterday, so didn't backport anything yet. Tried fixing the reported keyboard issue on OS X when using Kerberos. While doing this anyway, I also changed the wrapper for commands from sh to bash in x2goclient and added bash a dependency to x2goserver.
I'm hoping this fixes some problems for users who did not set bash (or something mostly bash-compatible) as their main shell, but am not too convinced it was an all-quash.
Mihai
On 13.06.2015 10:54 PM, Ulrich Sibiller wrote:
here is the pull request with the backports: https://github.com/ArcticaProject/nx-libs/pull/50
Thanks. Please don't forget to provide a tarball of your current progress.
Mihai
On Sat, Jun 13, 2015 at 11:08 PM, Mihai Moldovan <ionic@ionic.de> wrote:
On 13.06.2015 10:54 PM, Ulrich Sibiller wrote:
here is the pull request with the backports: https://github.com/ArcticaProject/nx-libs/pull/50
Thanks. Please don't forget to provide a tarball of your current progress.
I am currently working on that, stay tuned
Uli
PS: Sorry for the empty mail, pushed the wrong button...
-
Mihai Moldovan -
Mike Gabriel -
Ulrich Sibiller -
Ulrich Sibiller