Control: close -1 4.0.3.2
On Sat, Jan 24, 2015 at 6:30 PM, Michael DePaulo <mikedep333@gmail.com> wrote: [...]
On Mi 14 Jan 2015 20:05:46 CET, George Trakatelis wrote:
[...]
The attached patch saves x2goclient from calling slotStartParec() once per second unnecessarily. thanks for providing this patch, George.
Thanks!
I'll test the patch for regressions. If there are none, I will commit it. (I will however delete that 1 line rather than comment it out.)
I tested it successfully on XP 32-bit and on Windows 8.1 64-bit. So I applied it (after deleting that one commented out line.)
Also, I did not bother to update the changelog because I feel this is a very minor change, and I do not want to bombard users with too many details in the changelog. I will confirm on x2go-project that doing so is OK.
Thanks,
-Mike#2
On 25.01.2015 01:11 AM, Michael DePaulo wrote:
Also, I did not bother to update the changelog because I feel this is a very minor change, and I do not want to bombard users with too many details in the changelog. I will confirm on x2go-project that doing so is OK.
Please do document the change. This is make it easier to find out when this "feature"/workaround has been removed, should the removal ever cause problems in the future. This is especially useful for non-coders, who do not wish to dig through git archives in order to track a problem down.
Mihai
On Sat, Jan 24, 2015 at 10:47 PM, Mihai Moldovan <ionic@ionic.de> wrote:
On 25.01.2015 01:11 AM, Michael DePaulo wrote:
Also, I did not bother to update the changelog because I feel this is a very minor change, and I do not want to bombard users with too many details in the changelog. I will confirm on x2go-project that doing so is OK.
Please do document the change. This is make it easier to find out when this "feature"/workaround has been removed, should the removal ever cause problems in the future. This is especially useful for non-coders, who do not wish to dig through git archives in order to track a problem down.
Mihai
Done. Thanks.
-Mike