Package: x2goserver Version: 4.1.0.0-0~1215~ubuntu14.04.1 Severity: wishlist
Hi,
In Ubuntu before 15.04, and Debian jessie, the DESKTOP_SESSION for GNOME Flashback is actually "gnome-fallback". In particular, this name is found in /etc/upstart-xsessions while "gnome-flashback" is not, which prevents Upstart user sessions from being enabled. ("gnome-session --session=gnome-flashback is still the correct command, though.)
Furthermore, recent (Ubuntu >= 13.10, Debian jessie) login managers also export XDG_CURRENT_DESKTOP using the value of the DesktopNames field from the session file. This variable is starting to gain wide use by applications that care about the desktop environment they run under.
I can write a patch that adds all this information to x2goruncommand in the existing format. However it occurs to me that it might make more sense to parse the files in /usr/share/xsessions and use the information directly instead of duplicating it. Please let me know which you'd prefer to see.
-- Ryan Tandy - Programmer/Analyst rtandy@sd63.bc.ca School District 63 (Saanich) +1 250 652 7385
Hi Ryan,
On Do 29 Jan 2015 19:17:40 CET, Ryan Tandy wrote:
Package: x2goserver Version: 4.1.0.0-0~1215~ubuntu14.04.1 Severity: wishlist
Hi,
In Ubuntu before 15.04, and Debian jessie, the DESKTOP_SESSION for
GNOME Flashback is actually "gnome-fallback". In particular, this
name is found in /etc/upstart-xsessions while "gnome-flashback" is
not, which prevents Upstart user sessions from being enabled.
("gnome-session --session=gnome-flashback is still the correct
command, though.)Furthermore, recent (Ubuntu >= 13.10, Debian jessie) login managers
also export XDG_CURRENT_DESKTOP using the value of the DesktopNames
field from the session file. This variable is starting to gain wide
use by applications that care about the desktop environment they run
under.I can write a patch that adds all this information to x2goruncommand
in the existing format. However it occurs to me that it might make
more sense to parse the files in /usr/share/xsessions and use the
information directly instead of duplicating it. Please let me know
which you'd prefer to see.
x2goruncommand actually requires a complete rewrite (and has to be
based on freedesktop.org specs).
Until that happens, let's hard-code this stuff. Please provide your patch.
Thanks! Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Control: tags -1 + patch
Hi! Sorry it's taken me so long to get back to you about this.
On Thu, Feb 05, 2015 at 11:31:05AM +0000, Mike Gabriel wrote:
On Do 29 Jan 2015 19:17:40 CET, Ryan Tandy wrote:
I can write a patch that adds all this information to x2goruncommand in the existing format. However it occurs to me that it might make more sense to parse the files in /usr/share/xsessions and use the information directly instead of duplicating it. Please let me know which you'd prefer to see.
x2goruncommand actually requires a complete rewrite (and has to be based on freedesktop.org specs).
Until that happens, let's hard-code this stuff. Please provide your patch.
Well, I started doing that, but it ended up being a lot less work (and a lot shorter code) to just take the settings from the session files. :)
Please consider the attached patch. It makes x2goruncommand behave more like GDM/LightDM for GNOME-ish sessions.
Testing GNOME Flashback on recent Ubuntu requires a couple of patches to Ubuntu packages, which I'm working on getting accepted. Details on Launchpad:
https://bugs.launchpad.net/ubuntu/+source/gnome-session/+bug/1251281/comment... https://launchpad.net/~rtandy/+archive/ubuntu/flashback/+packages
The gnome-session patch is applicable to Jessie too, but I think it's too late in the freeze to get it accepted now. :(
Many thanks for your work on X2Go!
-- Ryan Tandy - Programmer/Analyst rtandy@sd63.bc.ca School District 63 (Saanich) 250-652-7385
On 17.03.2015 08:11 PM, Ryan Tandy wrote:
Control: tags -1 + patch
Hi! Sorry it's taken me so long to get back to you about this.
On Thu, Feb 05, 2015 at 11:31:05AM +0000, Mike Gabriel wrote:
On Do 29 Jan 2015 19:17:40 CET, Ryan Tandy wrote:
I can write a patch that adds all this information to x2goruncommand in the existing format. However it occurs to me that it might make more sense to parse the files in /usr/share/xsessions and use the information directly instead of duplicating it. Please let me know which you'd prefer to see.
x2goruncommand actually requires a complete rewrite (and has to be based on freedesktop.org specs).
Until that happens, let's hard-code this stuff. Please provide your patch.
Well, I started doing that, but it ended up being a lot less work (and a lot shorter code) to just take the settings from the session files. :)
Please consider the attached patch. It makes x2goruncommand behave more like GDM/LightDM for GNOME-ish sessions.
This looks interesting, but does it work for non-Ubuntu/Debian systems, too? Especially old(er) ones like SLE{S,D} 11, EPEL 5 etc.?
Mihai
Hi,
On Fri, Mar 20, 2015 at 05:48:49AM +0100, Mihai Moldovan wrote:
This looks interesting, but does it work for non-Ubuntu/Debian systems, too? Especially old(er) ones like SLE{S,D} 11, EPEL 5 etc.?
Tested on CentOS 5 and 6 successfully. CentOS 7 seems to not include the GNOME Flashback components, so I couldn't test there.
I wasn't able to get X2Go working at all on OpenSuSE 11. :/ Looks like packages.x2go.org doesn't carry 11 any more? Works on OpenSuSE 12, although the GNOME fallback desktop seems to be affected by a few bugs. I didn't test OpenSuSE 13, but glancing at the repo it looks like they retired the fallback/gnome-panel packages like RHEL7 did.
The patch I sent before exports XDG_CURRENT_DESKTOP needlessly in environments that have no value for it (e.g. older GNOME 2). Should be harmless, but even so I'm attaching a corrected patch and interdiff since the previous one.
The approach probably extends to non-GNOME desktops too, but I don't know when I would have time to go through and test them all...
-- Ryan Tandy - Programmer/Analyst rtandy@sd63.bc.ca School District 63 (Saanich) 250-652-7385
Processing control commands:
tags -1 + patch Bug #774 [x2goserver] please set DESKTOP_SESSION and XDG_CURRENT_DESKTOP like local sessions Added tag(s) patch.
-- 774: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=774 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
-
Mihai Moldovan -
Mike Gabriel -
owner＠bugs.x2go.org -
Ryan Tandy