The -o and -g options cause installation failure in unprivileged build environments, and provide no benefit for root either, because files will be owned by the installing user anyway. --- Can we please stop with the -o and -g madness? Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 07428f6..3c90c45 100755 --- a/Makefile +++ b/Makefile @@ -23,9 +23,9 @@ SRC_DIR=$(CURDIR) SHELL=/bin/bash -INSTALL_DIR=install -d -o root -g root -m 755 -INSTALL_FILE=install -o root -g root -m 644 -INSTALL_PROGRAM=install -o root -g root -m 755 +INSTALL_DIR=install -dm 755 +INSTALL_FILE=install -m 644 +INSTALL_PROGRAM=install -m 755 CC ?= gcc CFLAGS += -fPIE -- 1.7.10.4
Hi Jan, On Sa 16 Feb 2013 04:12:08 CET Jan Engelhardt wrote:
The -o and -g options cause installation failure in unprivileged build environments, and provide no benefit for root either, because files will be owned by the installing user anyway.
Can we please stop with the -o and -g madness?
Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile index 07428f6..3c90c45 100755 --- a/Makefile +++ b/Makefile @@ -23,9 +23,9 @@ SRC_DIR=$(CURDIR) SHELL=/bin/bash
-INSTALL_DIR=install -d -o root -g root -m 755 -INSTALL_FILE=install -o root -g root -m 644 -INSTALL_PROGRAM=install -o root -g root -m 755 +INSTALL_DIR=install -dm 755 +INSTALL_FILE=install -m 644 +INSTALL_PROGRAM=install -m 755
CC ?= gcc CFLAGS += -fPIE
1.7.10.4
I would really appreciate if he could start using X2Go BTS for submitting patches. With this patch I have a hard time to find out to what X2Go component to apply it... 1. Send your patches to ,,submit@bugs.x2go.org''. 2. Find a good subject... 3. And put these lines at the top of the mail body: Package: <Git-project name> Version: HEAD Tag: patch <your patch description / long description> 4. And then add the patch as attachment to your mail. Attachments are much easier to handle than inline patch code. As I still have no clue what X2Go component this patch is for, may I ask you to follow the above procedure for this very patch? Thanks, Mike -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
On Saturday 2013-02-16 17:17, Mike Gabriel wrote:
The -o and -g options cause installation failure in unprivileged build environments, and provide no benefit for root either, because files will be owned by the installing user anyway.
I would really appreciate if he could start using X2Go BTS for submitting patches. With this patch I have a hard time to find out to what X2Go component to apply it...
Sounds like a direly needed improvement in git-send-email. (Because it would have been obvious with git-request-pull)
- And then add the patch as attachment to your mail. Attachments are much easier to handle than inline patch code.
And prone to authorship getting lost, I would argue. Only git:// is sane, I gather, and therefore:
The following changes since commit 5231ba48183cc603a5193400884dd01b360491ba:
Add load balancing support. (2013-02-14 06:26:41 +0100)
are available in the git repository at:
git://git.inai.de/x2gobroker master
for you to fetch changes up to 920234126441688eef34f48a650fd3a2e90630af:
build: avoid using install -o/-g (2013-02-16 04:10:39 +0100)
Jan Engelhardt (1): build: avoid using install -o/-g
Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Hi Jan,
On Sa 16 Feb 2013 17:35:59 CET Jan Engelhardt wrote:
On Saturday 2013-02-16 17:17, Mike Gabriel wrote:
The -o and -g options cause installation failure in unprivileged build environments, and provide no benefit for root either, because files will be owned by the installing user anyway.
I would really appreciate if he could start using X2Go BTS for submitting patches. With this patch I have a hard time to find out to what
X2Go component to apply it...Sounds like a direly needed improvement in git-send-email. (Because it would have been obvious with git-request-pull)
- And then add the patch as attachment to your mail. Attachments are much easier to handle than inline patch code.
And prone to authorship getting lost, I would argue. Only git:// is sane, I gather, and therefore:
The following changes since commit 5231ba48183cc603a5193400884dd01b360491ba:
Add load balancing support. (2013-02-14 06:26:41 +0100)
are available in the git repository at:
git://git.inai.de/x2gobroker master
for you to fetch changes up to 920234126441688eef34f48a650fd3a2e90630af:
build: avoid using install -o/-g (2013-02-16 04:10:39 +0100)
Jan Engelhardt (1): build: avoid using install -o/-g
Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Cherry-picked to x2gobroker.git, branch=master.
I'd still be happy if you reported patches / git cherry-pickings to X2Go BTS.
Greets, Mike
--
DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
-
Jan Engelhardt -
Mike Gabriel