Package: x2goclient Version: 4.1.0 Tag: patch
When you launch a session using .desktop file (session saved as a launcher in the desktop) you can't see the tray icon though you choose this option in x2go settings
Attaching patch to solve this issue.
tag #316 moreinfo tag #316 - patch thanks
Hi Ricardo,
On Fr 04 Okt 2013 13:33:56 CEST, Ricardo Díaz Martín wrote:
Package: x2goclient Version: 4.1.0 Tag: patch
When you launch a session using .desktop file (session saved as a launcher in the desktop) you can't see the tray icon though you choose this option in x2go settings
Attaching patch to solve this issue.
I have looked at your patch (and the concept behind it) more closely.
Your current patch will break setups where people launch X2Go Client
via a .desktop file and expect no traces of X2Go Client to be seen on
screen apart from the session itself.
Suggestions: introduce a new cmdline option --tray-icon. This Option
activates the tray icon even if it is disabled in the
~/.x2goclient/settings file. In combination with --hide the
--tray-icon command then makes the tray icon visible for hidden X2Go
Client instances.
How about that?
Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Processing commands for control@bugs.x2go.org:
tag #316 moreinfo Bug #316 [x2goclient] Can't see session icon in shadow sessions Added tag(s) moreinfo. tag #316 - patch Bug #316 [x2goclient] Can't see session icon in shadow sessions Ignoring request to alter tags of bug #316 to the same tags previously set thanks Stopping processing here.
Please contact me if you need assistance.
316: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=316 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
tag #316 moreinfo tag #316 - patch
Hi Mike,
Yes, I think the way you said will be better. So I'm going to add this command line option and make a new patch ;-)
2013/10/29 Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
tag #316 moreinfo tag #316 - patch thanks
Hi Ricardo,
On Fr 04 Okt 2013 13:33:56 CEST, Ricardo Díaz Martín wrote:
Package: x2goclient
Version: 4.1.0 Tag: patch
When you launch a session using .desktop file (session saved as a launcher in the desktop) you can't see the tray icon though you choose this option in x2go settings
Attaching patch to solve this issue.
I have looked at your patch (and the concept behind it) more closely. Your current patch will break setups where people launch X2Go Client via a .desktop file and expect no traces of X2Go Client to be seen on screen apart from the session itself.
Suggestions: introduce a new cmdline option --tray-icon. This Option activates the tray icon even if it is disabled in the ~/.x2goclient/settings file. In combination with --hide the --tray-icon command then makes the tray icon visible for hidden X2Go Client instances.
How about that?
Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.**de<mike.gabriel@das-netzwerkteam.de>, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.**de/freebusy/m.gabriel%40das-** netzwerkteam.de.xfb<https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb>
Processing commands for control@bugs.x2go.org:
tag #316 moreinfo Bug #316 [x2goclient] Can't see session icon in shadow sessions Ignoring request to alter tags of bug #316 to the same tags previously set tag #316 - patch Bug #316 [x2goclient] Can't see session icon in shadow sessions Ignoring request to alter tags of bug #316 to the same tags previously set Hi Mike, Unknown command or malformed arguments to command. Yes, I think the way you said will be better. So I'm going to add this Unknown command or malformed arguments to command. command line option and make a new patch ;-) Unknown command or malformed arguments to command. 2013/10/29 Mike Gabriel <mike.gabriel@das-netzwerkteam.de> Unknown command or malformed arguments to command.
tag #316 moreinfo Unknown command or malformed arguments to command. Too many unknown commands, stopping here.
Please contact me if you need assistance.
316: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=316 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
Hi Ricardo,
On Mi 30 Okt 2013 08:14:09 CET, Ricardo Díaz Martín wrote:
Yes, I think the way you said will be better. So I'm going to add this command line option and make a new patch ;-)
Cool.
Thanks! Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
tag #316 - patch
Mike,
Attaching the new patch.
Now there is new command line parameter --tray-icon for x2goclient. When x2goclient find this parameter tray icon will be shown (also when --hide parameter is present too).
When x2goclient asking about create desktop icon in hide mode there is a new checkbox to set if desktop launcher is going to show tray icon or not (default is not).
So take a look and tell me something about.
Cheers!
2013/10/30 Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Hi Ricardo,
On Mi 30 Okt 2013 08:14:09 CET, Ricardo Díaz Martín wrote:
Yes, I think the way you said will be better. So I'm going to add this
command line option and make a new patch ;-)
Cool.
Thanks!
Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.**de<mike.gabriel@das-netzwerkteam.de>, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.**de/freebusy/m.gabriel%40das-** netzwerkteam.de.xfb<https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb>
Processing commands for control@bugs.x2go.org:
tag #316 - patch Bug #316 [x2goclient] Can't see session icon in shadow sessions Ignoring request to alter tags of bug #316 to the same tags previously set Mike, Unknown command or malformed arguments to command. Attaching the new patch. Unknown command or malformed arguments to command. Now there is new command line parameter --tray-icon for x2goclient. When Unknown command or malformed arguments to command. x2goclient find this parameter tray icon will be shown (also when --hide Unknown command or malformed arguments to command. parameter is present too). Unknown command or malformed arguments to command. Too many unknown commands, stopping here.
Please contact me if you need assistance.
316: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=316 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
-
Mike Gabriel -
owner＠bugs.x2go.org -
Ricardo Díaz Martín