Hello,
as you know, I made some changes in X2Go Client code. Especially important is that X2Go Client do not open for every reverse tunnel a new ssh connection any more. To make it possible, I made some improvements in libssh. The patch is already accepted by libssh team and Mike will take care about linux packages.
The libssh patch for reverse connections is here: http://code.x2go.org/releases/libssh/libssh-0.5.x-accept-forward.patch
I have also found another one issue with libssh, however I have not yet an answer from libssh team if they will accept this patch. It is very important for Mac Client to use libssh with this patch. In other case you can expect the poor performance of X2Go Client.
You can find a patch here: http://code.x2go.org/releases/libssh/libssh-0.5.x-unblock.patch
To be able build current X2Go Client code on Mac or Windows you also need a libssh with this two patches.
@Michael DePaulo. Please apply this two patches on your libssh source tree. If you don't want to build libssh by yourself, you can use binaries built by me:
http://code.x2go.org/releases/libssh/libssh-0.5.5.zip
@Clemens Lang. If you build libssh using brew, you can do next:
- uninstall old version of libssh $brew uninstall libssh
$cd $(brew --prefix) $brew update
get available libssh vesrions $brew versions libssh
switch to libssh-0.5.5 $git checkout 91e973b Library/Formula/libssh.rb
edit formula $brew edit libssh
add libssh patches before def install:
def patches [
"http://code.x2go.org/releases/libssh/libssh-0.5.x-accept-forward.patch", "http://code.x2go.org/releases/libssh/libssh-0.5.x-unblock.patch" ] end
after that you can build libssh as usual: $brew install libssh
regards Alex
Oleksandr Shneyder | Email: o.shneyder@phoca-gmbh.de phoca GmbH | Tel. : 0911 - 14870374 0 Bräuhausgasse 9 | Fax. : 0911 - 14870374 9 D-82205 Gilching | Mobil: 0163 - 49 64 461
Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder
Amtsgericht München | http://www.phoca-gmbh.de HRB 196 658 | http://www.x2go.org USt-IdNr.: DE281977973
On Fri, Jan 24, 2014 at 9:14 AM, Oleksandr Shneyder < o.shneyder@phoca-gmbh.de> wrote:
To be able build current X2Go Client code on Mac or Windows you also need a libssh with this two patches.
@Michael DePaulo. Please apply this two patches on your libssh source tree. If you don't want to build libssh by yourself, you can use binaries built by me:
Thanks, I'll use these binaries in x2goclient 4.0.1.3 win32 (and probably in 4.0.2.0 win32).
FYI: I plan to have x2goclient 4.0.1.3 win32 built by the end of Sunday.
-Mike
On Fri, Jan 24, 2014 at 9:20 AM, Michael DePaulo <mikedep333@gmail.com> wrote:
On Fri, Jan 24, 2014 at 9:14 AM, Oleksandr Shneyder <o.shneyder@phoca-gmbh.de> wrote:
To be able build current X2Go Client code on Mac or Windows you also need a libssh with this two patches.
@Michael DePaulo. Please apply this two patches on your libssh source tree. If you don't want to build libssh by yourself, you can use binaries built by me:
Thanks, I'll use these binaries in x2goclient 4.0.1.3 win32 (and probably in 4.0.2.0 win32).
FYI: I plan to have x2goclient 4.0.1.3 win32 built by the end of Sunday.
-Mike
Hi Alex,
libssh.dll depends on zlib1.dll. Can you please provide or link me to the zlib1.dll that should be used?
In the x2go win32 build instructions, it says to copy libssh.dll only. libssh 0.5.3 on the kde windows site only contains libssh.dll. However, your 0.5.5 build contains both libssh.dll & libssh_threads.dll . Do I need libssh_threads.dll as well?
Thanks Mike#2
Hello Mike,
http://gnuwin32.sourceforge.net/downlinks/zlib.php
You don't need libssh_threads.dll
regards, Alex
Am 25.01.2014 01:41, schrieb Michael DePaulo:
On Fri, Jan 24, 2014 at 9:20 AM, Michael DePaulo <mikedep333@gmail.com> wrote:
On Fri, Jan 24, 2014 at 9:14 AM, Oleksandr Shneyder <o.shneyder@phoca-gmbh.de> wrote:
To be able build current X2Go Client code on Mac or Windows you also need a libssh with this two patches.
@Michael DePaulo. Please apply this two patches on your libssh source tree. If you don't want to build libssh by yourself, you can use binaries built by me:
Thanks, I'll use these binaries in x2goclient 4.0.1.3 win32 (and probably in 4.0.2.0 win32).
FYI: I plan to have x2goclient 4.0.1.3 win32 built by the end of Sunday.
-Mike
Hi Alex,
libssh.dll depends on zlib1.dll. Can you please provide or link me to the zlib1.dll that should be used?
In the x2go win32 build instructions, it says to copy libssh.dll only. libssh 0.5.3 on the kde windows site only contains libssh.dll. However, your 0.5.5 build contains both libssh.dll & libssh_threads.dll . Do I need libssh_threads.dll as well?
Thanks Mike#2
X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
--
Oleksandr Shneyder | Email: o.shneyder@phoca-gmbh.de phoca GmbH | Tel. : 0911 - 14870374 0 Bräuhausgasse 9 | Fax. : 0911 - 14870374 9 D-82205 Gilching | Mobil: 0163 - 49 64 461
Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder
Amtsgericht München | http://www.phoca-gmbh.de HRB 196 658 | http://www.x2go.org USt-IdNr.: DE281977973
On Fri, Jan 24, 2014 at 9:20 AM, Michael DePaulo <mikedep333@gmail.com> wrote:
On Fri, Jan 24, 2014 at 9:14 AM, Oleksandr Shneyder <o.shneyder@phoca-gmbh.de> wrote:
To be able build current X2Go Client code on Mac or Windows you also need a libssh with this two patches.
@Michael DePaulo. Please apply this two patches on your libssh source tree. If you don't want to build libssh by yourself, you can use binaries built by me:
Thanks, I'll use these binaries in x2goclient 4.0.1.3 win32 (and probably in 4.0.2.0 win32).
FYI: I plan to have x2goclient 4.0.1.3 win32 built by the end of Sunday.
-Mike
Hi Alex,
Sorry to resuscitate an old thread, but this thread is directly relevant.
Bug 448 was introduced as a Windows-specific regression when the Windows builds switched from KDE's 0.5.3 libssh build to your libssh 0.5.5 build.
Could you please rebuild libssh with the patch listed in 448? I can confirm that it applies cleanly to libssh 0.5.5 with your 2 patches applied.
(Note: I did try to build libssh 0.5.5 myself, but ran into an issue specifying the ZLIB_INCLUDE_DIR with CMAKE. If you already have the libssh build environment setup, it would be much easier if you could just rebuild with this 1 addtl patch.)
-Mike#2
Hi Mike,
You can disable ZLIB in libssh (we didn't really need it) in DefineOptions.cmake
You can find the libssh package with all patches applied hier: http://code.x2go.org/releases/libssh-with-pagent.patch/libssh-0.5.5.zip
regards, Alex
Am 17.03.2014 05:23, schrieb Michael DePaulo:
On Fri, Jan 24, 2014 at 9:20 AM, Michael DePaulo <mikedep333@gmail.com> wrote:
On Fri, Jan 24, 2014 at 9:14 AM, Oleksandr Shneyder <o.shneyder@phoca-gmbh.de> wrote:
To be able build current X2Go Client code on Mac or Windows you also need a libssh with this two patches.
@Michael DePaulo. Please apply this two patches on your libssh source tree. If you don't want to build libssh by yourself, you can use binaries built by me:
Thanks, I'll use these binaries in x2goclient 4.0.1.3 win32 (and probably in 4.0.2.0 win32).
FYI: I plan to have x2goclient 4.0.1.3 win32 built by the end of Sunday.
-Mike
Hi Alex,
Sorry to resuscitate an old thread, but this thread is directly relevant.
Bug 448 was introduced as a Windows-specific regression when the Windows builds switched from KDE's 0.5.3 libssh build to your libssh 0.5.5 build.
Could you please rebuild libssh with the patch listed in 448? I can confirm that it applies cleanly to libssh 0.5.5 with your 2 patches applied.
(Note: I did try to build libssh 0.5.5 myself, but ran into an issue specifying the ZLIB_INCLUDE_DIR with CMAKE. If you already have the libssh build environment setup, it would be much easier if you could just rebuild with this 1 addtl patch.)
-Mike#2
--
Oleksandr Shneyder | Email: o.shneyder@phoca-gmbh.de phoca GmbH | Tel. : 0911 - 14870374 0 Ludwig-Feuerbach-str. 18 | Fax. : 0911 - 14870374 9 D-90489 Nürnberg | Mobil: 0163 - 49 64 461
Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder
Amtsgericht München | http://www.phoca-gmbh.de HRB 196 658 | http://www.x2go.org USt-IdNr.: DE281977973
Hi Alex, hi all,
On Fr 24 Jan 2014 15:14:03 CET, Oleksandr Shneyder wrote:
[...]
thanks for providing this information. Two minor comments from my side...
TL;DR; There will be two release branches for X2Go Client for an
undefined amount of time... (4.0.1.x and 4.0.2.x).
The windows builds and Mac OS X builds will switch to 4.0.2.x soon.
Different for Linux distros. For distros that do not have a libssh
version containing the patch that Alex referred to in his post,
package maintainers have to use x2goclient 4.0.1.x.
For distros that have a libssh with multiple-port-rev-forwarding
support, please use x2goclient 4.0.2.x.
Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Hi Alex,
You can find a patch here: http://code.x2go.org/releases/libssh/libssh-0.5.x-unblock.patch
The patch has an unnecessary patch block in it (extra line feed). This
brings up a topic about patch cleanliness that becomes important for
X2Go Client now that we have to maintain two release branches for some
time...
I have just split up X2Go Client into two branches (main development
branch on Git master and a release/4.0.1.x Git branch).
Until all current distros have the required libssh patch, I will
release two versions of X2Go Client (4.0.1.x / Baikal LTS /
release/4.0.1.x Git branch) and 4.0.2.x (Stable release / Git master).
Completely new features will only go into the Stable release branch
(4.0.2.x / Git master).
Bugfixes will go into release/4.0.1.x branch and be cherry-picked to
the master branch.
@Alex and all patch contributors: In order to be able to maintain
these two release series I need very clean commits/patches on X2Go
Client code while we are in this dual release phase. I will only
cherry-pick patches between branches if they are very very clean. This
means: no indentation changes where it is not necessary, no whitespace
fixes, no new empty lines, etc.
Thanks!!!
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
-
Michael DePaulo -
Mike Gabriel -
Oleksandr Shneyder