package: x2goserver priority: wishlist tags: patch
This is a proposal patch for a MySQL session storage database backend for X2Go Server.
I did this simply because :
- I'm not used to PostgreSQL and much more skilled with MySQL
- I do believe MySQL is pretty common on Linux and is widely spread so I guess this can be useful for many other people willing to build a strong TCE setup and not willing to dig into PostgreSQL
- I find it a lot easier to build a multi-master replication scenario with MySQL than with PostgreSQL (but as I said, I'm much more skilled wih MySQL)
This backend is tightly inspired by the PostgreSQL backend and work exactly the same so this is a drop in replacement for it, til now, all my tests seems to work correctly, feel free to test by yourself and report errors.
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
Alex,
please check if this patch fulfills all the requirements you mentioned off-list; if not, please comment and advise Walid what he needs to add/change.
Kind Regards, Stefan Baur
Am 13.01.2017 um 17:55 schrieb Walid MOGHRABI:
package: x2goserver priority: wishlist tags: patch
This is a proposal patch for a MySQL session storage database backend for X2Go Server.
I did this simply because :
- I'm not used to PostgreSQL and much more skilled with MySQL
- I do believe MySQL is pretty common on Linux and is widely spread so I guess this can be useful for many other people willing to build a strong TCE setup and not willing to dig into PostgreSQL
- I find it a lot easier to build a multi-master replication scenario with MySQL than with PostgreSQL (but as I said, I'm much more skilled wih MySQL)
This backend is tightly inspired by the PostgreSQL backend and work exactly the same so this is a drop in replacement for it, til now, all my tests seems to work correctly, feel free to test by yourself and report errors.
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
-- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243
Ho, I just saw that I forgot to mention that MySQL support for Perl::DBI must be installed. It is not with the x2goserver package and I didn't find how to add it as a dependency in the sources (I probably didn't search too far to be honest ...)
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
----- Mail original -----
De: "Stefan Baur" <X2Go-ML-1@baur-itcs.de> À: "Oleksandr Shneyder" <o.shneyder@phoca-gmbh.de>, 1135@bugs.x2go.org Envoyé: Vendredi 13 Janvier 2017 18:03:50 Objet: [X2Go-Dev] Bug#1135: Bug#1135: MySQL Database backend support
Alex,
please check if this patch fulfills all the requirements you mentioned off-list; if not, please comment and advise Walid what he needs to add/change.
Kind Regards, Stefan Baur
Am 13.01.2017 um 17:55 schrieb Walid MOGHRABI:
package: x2goserver priority: wishlist tags: patch
This is a proposal patch for a MySQL session storage database backend for X2Go Server.
I did this simply because :
- I'm not used to PostgreSQL and much more skilled with MySQL
- I do believe MySQL is pretty common on Linux and is widely spread so I guess this can be useful for many other people willing to build a strong TCE setup and not willing to dig into PostgreSQL
- I find it a lot easier to build a multi-master replication scenario with MySQL than with PostgreSQL (but as I said, I'm much more skilled wih MySQL)
This backend is tightly inspired by the PostgreSQL backend and work exactly the same so this is a drop in replacement for it, til now, all my tests seems to work correctly, feel free to test by yourself and report errors.
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
-- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243
x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
package: x2goclient priority: wishlist tags: patch
This is a proposal patch in order to add support for randomly picked backround image from a directory.
I did this because I'd like to have my TCEs load different pictures each time they're on a bit like the welcome picture on Windows 10. This patch only check if the --background parameter is a directory and if so, pick randomly a SVG file from it.
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
package: x2goclient priority: wishlist tags: patch
This is a proposal patch in order to let the RDP client use the credentials used at broker auth login so that users can enter them only once in broker mode.
This patch also add support for --close-disconnect in broker mode + RDP
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
Hi Walid,
On Mi 31 Mai 2017 16:40:49 CEST, Walid MOGHRABI wrote:
package: x2goclient priority: wishlist tags: patch
This is a proposal patch in order to let the RDP client use the
credentials used at broker auth login so that users can enter them
only once in broker mode.This patch also add support for --close-disconnect in broker mode + RDP
I just looked at your patch.
Requests before patch can get accepted:
Please split up the RDP broker creds as session creds from the
--close-disconnect change.Please let the cmdline option start with --broker-...
--broker-use-creds-for-sessionDon't limit this functionality to RDP sessions only. It is
useful for all sorts of session types (X2Go, DirectRDP, DirectXDMCP if already in (there were
rumours about such a new feature)).
Thanks for your work on X2Go, Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
I'll take your requests into account but just to clarify :
- Please split up the RDP broker creds as session creds from the --close-disconnect change.
This little fix is related to this support since, in that particular case which is broker mode + RDP session + --close-disconnect activated, you couldn't have a one time authentication (at broker auth). For that "one time auth" to work, I need a way to pass broker credentials to the session and to close the client at the end of the session in order to force a re-auth at broker login. Without the --close-disconnect fix, I can pass my credentials to the RDP session but when finishing the session, I'm still on the broker page with my session list and I don't re-auth which is what I wanted. I can easily split these patches since they are quite clearly separated but I thought they were related to the same need that's why I kept them together.
- Please let the cmdline option start with --broker-...
--broker-use-creds-for-session
ok
- Don't limit this functionality to RDP sessions only. It is useful for all sorts of session types (X2Go, DirectRDP, DirectXDMCP if already in (there were rumours about such a new feature)).
Well, I'm not aware of XDMCP and have nothing under my hand to test it. This patch affect RDP sessions only in fact because X2Go sessions have heir own way to pass credentials from broker to x2go server with the intermediate key auth so using this method for this kind of session is purely useless. On the other hand, RDP sessions have no such key authentication available so it is necessary to pass credentials as plaintext to xfreerdp/rdesktop because in the case of the broker mode only, when clicking on the session profile, the client is waiting for the credentials but you are not prompted for them so the client stay stuck in an unusable situation. So really, this is a "broker + RDP only" method that's why I precised this was for RDP only in order not to confuse users who might think this could be used for any type of connection.
I'll modify the cmdline option name and wait for your comments on my precisions.
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
----- Mail original -----
De: "Mike Gabriel" <mike.gabriel@das-netzwerkteam.de> À: "Walid MOGHRABI" <w.moghrabi@servicemagic.eu>, 1183@bugs.x2go.org Envoyé: Mercredi 31 Mai 2017 21:58:28 Objet: Re: [X2Go-Dev] Bug#1183: Pass broker creds to RDP client as plaintext
Hi Walid,
On Mi 31 Mai 2017 16:40:49 CEST, Walid MOGHRABI wrote:
package: x2goclient priority: wishlist tags: patch
This is a proposal patch in order to let the RDP client use the credentials used at broker auth login so that users can enter them only once in broker mode.
This patch also add support for --close-disconnect in broker mode + RDP
I just looked at your patch.
Requests before patch can get accepted:
- Please split up the RDP broker creds as session creds from the --close-disconnect change.
- Please let the cmdline option start with --broker-...
--broker-use-creds-for-session
- Don't limit this functionality to RDP sessions only. It is useful for all sorts of session types (X2Go, DirectRDP, DirectXDMCP if already in (there were rumours about such a new feature)).
Thanks for your work on X2Go, Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
HI Walid,
On Do 01 Jun 2017 10:46:55 CEST, Walid MOGHRABI wrote:
I'll take your requests into account but just to clarify :
- Please split up the RDP broker creds as session creds from the --close-disconnect change.
This little fix is related to this support since, in that particular
case which is broker mode + RDP session + --close-disconnect
activated, you couldn't have a one time authentication (at broker
auth). For that "one time auth" to work, I need a way to pass broker
credentials to the session and to close the client at the end of the
session in order to force a re-auth at broker login. Without the --close-disconnect fix, I can pass my credentials to the
RDP session but when finishing the session, I'm still on the broker
page with my session list and I don't re-auth which is what I wanted. I can easily split these patches since they are quite clearly
separated but I thought they were related to the same need that's
why I kept them together.
Please split off the change for --close-disconnect into a separate commit.
- Please let the cmdline option start with --broker-...
--broker-use-creds-for-session
ok
- Don't limit this functionality to RDP sessions only. It is useful for all sorts of session types (X2Go, DirectRDP, DirectXDMCP if already in (there were rumours about such a new feature)).
Well, I'm not aware of XDMCP and have nothing under my hand to test it. This patch affect RDP sessions only in fact because X2Go sessions
have heir own way to pass credentials from broker to x2go server
with the intermediate key auth so using this method for this kind of
session is purely useless. On the other hand, RDP sessions have no such key authentication
available so it is necessary to pass credentials as plaintext to
xfreerdp/rdesktop because in the case of the broker mode only, when
clicking on the session profile, the client is waiting for the
credentials but you are not prompted for them so the client stay
stuck in an unusable situation. So really, this is a "broker + RDP only" method that's why I
precised this was for RDP only in order not to confuse users who
might think this could be used for any type of connection.I'll modify the cmdline option name and wait for your comments on my
precisions.
IMHO, the --broker-use-creds-for-session could be a nice and cheap
alternative to setting up x2gobroker-agent based authentication. So,
it would be nice to have it working for X2Go and RDP sessions.
Thanks, Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
package: x2goclient priority: wishlist tags: patch
This is a proposal patch in order to use the credentials used at broker auth login so that users can enter them only once in broker mode.
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
package: x2goclient priority: wishlist tags: patch
This is a proposal patch in order to enable --close-disconnect option for RDP sessions in broker mode.
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
Hi,
Any news on this ?
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
----- Mail original -----
De: "Walid MOGHRABI" <w.moghrabi@servicemagic.eu> À: submit@bugs.x2go.org Envoyé: Lundi 5 Juin 2017 12:22:38 Objet: [X2Go-Dev] Bug#1186: --close-disconnect fix for RDP sessions in broker mode
package: x2goclient priority: wishlist tags: patch
This is a proposal patch in order to enable --close-disconnect option for RDP sessions in broker mode.
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
Hi,
Any news on this ?
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
----- Mail original -----
De: "Walid MOGHRABI" <w.moghrabi@servicemagic.eu> À: submit@bugs.x2go.org Envoyé: Lundi 5 Juin 2017 12:21:31 Objet: [X2Go-Dev] Bug#1185: broker use creds for sessions
package: x2goclient priority: wishlist tags: patch
This is a proposal patch in order to use the credentials used at broker auth login so that users can enter them only once in broker mode.
Regards, Walid Moghrabi
TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
-
Mike Gabriel -
Stefan Baur -
Walid MOGHRABI