Hi all,
yesterday I have been working on the C++ code in x2godesktopsharing.
To make sure that x2godesktopsharing really gets shutdown on
x2goterminate-session, I have added a script to the x2godesktopsharing
package that detects the corresponding x2godesktopsharing process for
a given session $X2GO_SESSION. This script
,,x2godesktopsharing-terminate" will be exectuted by
,,x2goterminate-session".
This brought up the next question: how do we want to handle
x2godesktopsharing while a session is suspended. This older versions
of X2go (I think) this has been possible. I consider this as a
security problem and something that most users do not want. Imagine
the scenario:
o start x2go session o start x2godesktopsharing o allow user foo to share your desktop and remember this setting permanently (via .x2godesktopsharing/settings) o suspend your session (and x2godesktopsharing continues to offer desktop sharing... :-( ) o user foo tries to connect to your desktop while you are away (while your session is suspended o -> this is YUK!
So what I have done is this:
o on session suspend, terminate x2godesktopsharing and remember that it was running, place a server-side empty file ,,resume-desktopsharing'' into
$HOME/.x2go/C-$X2GO_SESSION/o on session resume, check if that file is there and if so, launch a new instance of x2godesktopsharing, with sharing mode set to disabled.
Feedback, comments?
Mike
PS: I have just looked at my commits from yesterday and it feels like
I should rename the provided scripts in this way:
x2godesktopsharing-terminate -> x2goterminate-desktopsharing x2godesktopsharing-suspend -> x2gosuspend-desktopsharing etc.
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Op 29-09-11 08:23, Mike Gabriel schreef:
Hi all,
yesterday I have been working on the C++ code in x2godesktopsharing.
Great! How is the status at the moment, does it work correct?
To make sure that x2godesktopsharing really gets shutdown on x2goterminate-session, I have added a script to the x2godesktopsharing package that detects the corresponding x2godesktopsharing process for a given session $X2GO_SESSION. This script ,,x2godesktopsharing-terminate" will be exectuted by ,,x2goterminate-session".
This brought up the next question: how do we want to handle x2godesktopsharing while a session is suspended. This older versions of X2go (I think) this has been possible. I consider this as a security problem and something that most users do not want. Imagine the scenario:
o start x2go session o start x2godesktopsharing o allow user foo to share your desktop and remember this setting permanently (via .x2godesktopsharing/settings) o suspend your session (and x2godesktopsharing continues to offer desktop sharing... :-( ) o user foo tries to connect to your desktop while you are away (while your session is suspended o -> this is YUK!
I don't understand why you see this a problem. The user has given this right to foo.
As a sysadmin, I would like to do my work even when the user has gone for a lunch or something like that. When there are programs open like Mozilla or OOo, it's problematic to start them from another session.
With regards, Paul.
-- Paul van der Vlis Linux systeembeheer, Groningen http://www.vandervlis.nl
This brought up the next question: how do we want to handle x2godesktopsharing while a session is suspended. This older versions of X2go (I think) this has been possible. I consider this as a security problem and something that most users do not want.
I haven't used x2godesktopsharing, don't know what options it has, but the remote control software we use at work displays a dialog asking the user if the incoming connection should be allowed or not. Perhaps that could be added as a configurable option to x2godesktopsharing.
Cheers, Daniel
Hi all,
On Fr 30 Sep 2011 18:56:41 CEST Daniel Lindgren wrote:
This brought up the next question: how do we want to handle x2godesktopsharing while a session is suspended. This older versions of X2go (I think) this has been possible. I consider this as a security problem and something that most users do not want.
I haven't used x2godesktopsharing, don't know what options it has, but the remote control software we use at work displays a dialog asking the user if the incoming connection should be allowed or not. Perhaps that could be added as a configurable option to x2godesktopsharing.
Such a functionality is already there.
The code looks currently quite ok (Paul asked for it) and seems to
work here. However, it depends on x2goserver 3.0.99.6 that we are
still collecting test results for.
Greets, mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
-
Daniel Lindgren -
Mike Gabriel -
Paul van der Vlis