Package: x2goclient Version: 4.0.1.1
This email was sent to x2go-dev mailling list, but since it also refers a Bug, I am also filling a bug report
Hi
I'm developing a program that will use X2Go software. I dont want users to notice they are using any other program besides my own.
I have two problems right now:
A) X2GoClient Using SHADOW mode with "--hide" does not work. The interface waits for selection of Display (usually ":0") and, since there's no input from user (there's no window) the program does not show anything. There are possible ways of fixing/improving this situation: -allow user to set the default display on sessions' file -create one flag and run program like these: "x2goclient --hide --sessionid=xxx --select-first-display"
Anyway, i modified the code of x2goclient/onmainwindow.cpp and added these lines: l4348:..if( shadowSession ) l4349:....slotShadowSess(); Compiled the program, and now i can run "./x2goclient --hide --sessionid=xxx" and the window will show up. This is NOT a fix, this is a nasty workaround. It wontn show the list even when the "hide" flag is not present.
B) X2GoDesktopSharing Just the icon on SystemTray. If we could pass a flag like "--no-icon" would be great
I could do these simple changes on my own, but i rather see this changes on the official code.
Thanks, Marco Dinis
Control: retitle -1 Make shadow sessions work with --hide option Control: tag -1 moreinfo Control: clone -1 -2 Control: reassign -2 x2godesktopsharing Control: retitle -2 Add --no-icon cmdline option to x2godesktopsharing Control: severity -2 wishlist
Hi Marco,
with this mail I split up your report into to separate bug reports.
One for x2goclient, one for x2godesktopsharing...
On Di 26 Nov 2013 17:01:41 CET, marcoandredinis wrote:
I'm developing a program that will use X2Go software. I dont want users to notice they are using any other program besides my own.
I have two problems right now:
A) X2GoClient Using SHADOW mode with "--hide" does not work. The interface waits for selection of Display (usually ":0") and, since there's no input from user (there's no window) the program does not show anything. There are possible ways of fixing/improving this situation: -allow user to set the default display on sessions' file -create one flag and run program like these: "x2goclient --hide --sessionid=xxx --select-first-display"
Anyway, i modified the code of x2goclient/onmainwindow.cpp and added these lines: l4348:..if( shadowSession ) l4349:....slotShadowSess(); Compiled the program, and now i can run "./x2goclient --hide --sessionid=xxx" and the window will show up. This is NOT a fix, this is a nasty workaround. It wontn show the list even when the "hide" flag is not present.
Please provide a patch for what you did.
Please improve your patch so it is not a workaround anymore. I guess,
I agree with you, that the X2Go Client window should pop up, if there
are more than one sharable desktops to select from. If there is only
one sharable desktop, this should be auto-selected. Can you code that
into X2Go Client, please?
B) X2GoDesktopSharing Just the icon on SystemTray. If we could pass a flag like "--no-icon" would be great
This part will be handled in a separate bug. I will reply to this once
the separate bug is created in X2Go BTS.
I could do these simple changes on my own, but i rather see this changes on the official code.
Let's try to get your needs into upstream code...
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Hi
I'm sending the patch.
However this is not the final fix. There are 2 modes: full access and only view. Right now it starts full access. That decision could be made using the session info. For example, create the command SHADOWFULL
On Wed, Nov 27, 2013 at 10:46 AM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
Control: retitle -1 Make shadow sessions work with --hide option Control: tag -1 moreinfo Control: clone -1 -2 Control: reassign -2 x2godesktopsharing Control: retitle -2 Add --no-icon cmdline option to x2godesktopsharing Control: severity -2 wishlist
Hi Marco,
with this mail I split up your report into to separate bug reports. One for x2goclient, one for x2godesktopsharing...
On Di 26 Nov 2013 17:01:41 CET, marcoandredinis wrote:
I'm developing a program that will use X2Go software. I dont want users to notice they are using any other program besides my own.
I have two problems right now:
A) X2GoClient Using SHADOW mode with "--hide" does not work. The interface waits for selection of Display (usually ":0") and, since there's no input from user (there's no window) the program does not show anything. There are possible ways of fixing/improving this situation: -allow user to set the default display on sessions' file -create one flag and run program like these: "x2goclient --hide --sessionid=xxx --select-first-display"
Anyway, i modified the code of x2goclient/onmainwindow.cpp and added these lines: l4348:..if( shadowSession ) l4349:....slotShadowSess(); Compiled the program, and now i can run "./x2goclient --hide --sessionid=xxx" and the window will show up. This is NOT a fix, this is a nasty workaround. It wontn show the list even when the "hide" flag is not present.
Please provide a patch for what you did.
Please improve your patch so it is not a workaround anymore. I guess, I agree with you, that the X2Go Client window should pop up, if there are more than one sharable desktops to select from. If there is only one sharable desktop, this should be auto-selected. Can you code that into X2Go Client, please?
B) X2GoDesktopSharing Just the icon on SystemTray. If we could pass a flag like "--no-icon" would be great
This part will be handled in a separate bug. I will reply to this once the separate bug is created in X2Go BTS.
I could do these simple changes on my own, but i rather see this changes on the official code.
Let's try to get your needs into upstream code...
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Any news on implementing this?
On Thu, Nov 28, 2013 at 10:16 AM, Marco André Dinis < marcoandredinis@gmail.com> wrote:
Hi
I'm sending the patch.
However this is not the final fix. There are 2 modes: full access and only view. Right now it starts full access. That decision could be made using the session info. For example, create the command SHADOWFULL
Control: retitle -1 Make shadow sessions work with --hide option Control: tag -1 moreinfo Control: clone -1 -2 Control: reassign -2 x2godesktopsharing Control: retitle -2 Add --no-icon cmdline option to x2godesktopsharing Control: severity -2 wishlist
Hi Marco,
with this mail I split up your report into to separate bug reports. One for x2goclient, one for x2godesktopsharing...
On Di 26 Nov 2013 17:01:41 CET, marcoandredinis wrote:
I'm developing a program that will use X2Go software. I dont want users to notice they are using any other program besides my own.
I have two problems right now:
A) X2GoClient Using SHADOW mode with "--hide" does not work. The interface waits for selection of Display (usually ":0") and, since there's no input from user (there's no window) the program does not show anything. There are possible ways of fixing/improving this situation: -allow user to set the default display on sessions' file -create one flag and run program like these: "x2goclient --hide --sessionid=xxx --select-first-display"
Anyway, i modified the code of x2goclient/onmainwindow.cpp and added these lines: l4348:..if( shadowSession ) l4349:....slotShadowSess(); Compiled the program, and now i can run "./x2goclient --hide --sessionid=xxx" and the window will show up. This is NOT a fix, this is a nasty workaround. It wontn show the list even when the "hide" flag is not present.
Please provide a patch for what you did.
Please improve your patch so it is not a workaround anymore. I guess, I agree with you, that the X2Go Client window should pop up, if there are more than one sharable desktops to select from. If there is only one sharable desktop, this should be auto-selected. Can you code that into X2Go Client, please?
B) X2GoDesktopSharing Just the icon on SystemTray. If we could pass a flag like "--no-icon" would be great
This part will be handled in a separate bug. I will reply to this once
On Wed, Nov 27, 2013 at 10:46 AM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote: the
separate bug is created in X2Go BTS.
I could do these simple changes on my own, but i rather see this changes on the official code.
Let's try to get your needs into upstream code...
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Control: tag -1 patch Control: tag -1 - moreinfo
Hi Marco,
this is still pending due to ENOTIME. Sorry. It won't get lost as long
as it is in our bugtracker...
Mike
On Mo 09 Dez 2013 12:03:34 CET, Marco André Dinis wrote:
Any news on implementing this?
On Thu, Nov 28, 2013 at 10:16 AM, Marco André Dinis < marcoandredinis@gmail.com> wrote:
Hi
I'm sending the patch.
However this is not the final fix. There are 2 modes: full access and only view. Right now it starts full access. That decision could be made using the session info. For example, create the command SHADOWFULL
Control: retitle -1 Make shadow sessions work with --hide option Control: tag -1 moreinfo Control: clone -1 -2 Control: reassign -2 x2godesktopsharing Control: retitle -2 Add --no-icon cmdline option to x2godesktopsharing Control: severity -2 wishlist
Hi Marco,
with this mail I split up your report into to separate bug reports. One for x2goclient, one for x2godesktopsharing...
On Di 26 Nov 2013 17:01:41 CET, marcoandredinis wrote:
I'm developing a program that will use X2Go software. I dont want users to notice they are using any other program besides my own.
I have two problems right now:
A) X2GoClient Using SHADOW mode with "--hide" does not work. The interface waits for selection of Display (usually ":0") and, since there's no input from user (there's no window) the program does not show anything. There are possible ways of fixing/improving this situation: -allow user to set the default display on sessions' file -create one flag and run program like these: "x2goclient --hide --sessionid=xxx --select-first-display"
Anyway, i modified the code of x2goclient/onmainwindow.cpp and added these lines: l4348:..if( shadowSession ) l4349:....slotShadowSess(); Compiled the program, and now i can run "./x2goclient --hide --sessionid=xxx" and the window will show up. This is NOT a fix, this is a nasty workaround. It wontn show the list even when the "hide" flag is not present.
Please provide a patch for what you did.
Please improve your patch so it is not a workaround anymore. I guess, I agree with you, that the X2Go Client window should pop up, if there are more than one sharable desktops to select from. If there is only one sharable desktop, this should be auto-selected. Can you code that into X2Go Client, please?
B) X2GoDesktopSharing Just the icon on SystemTray. If we could pass a flag like "--no-icon" would be great
This part will be handled in a separate bug. I will reply to this once
On Wed, Nov 27, 2013 at 10:46 AM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote: the
separate bug is created in X2Go BTS.
I could do these simple changes on my own, but i rather see this changes on the official code.
Let's try to get your needs into upstream code...
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Processing control commands:
retitle -1 Make shadow sessions work with --hide option Bug #349 [x2goclient] Tag: patch Changed Bug title to 'Make shadow sessions work with --hide option' from 'Tag: patch' tag -1 moreinfo Bug #349 [x2goclient] Make shadow sessions work with --hide option Added tag(s) moreinfo. clone -1 -2 Bug #349 [x2goclient] Make shadow sessions work with --hide option Bug 349 cloned as bug 350 reassign -2 x2godesktopsharing Bug #350 [x2goclient] Make shadow sessions work with --hide option Bug reassigned from package 'x2goclient' to 'x2godesktopsharing'. No longer marked as found in versions 4.0.1.1. Ignoring request to alter fixed versions of bug #350 to the same values previously set retitle -2 Add --no-icon cmdline option to x2godesktopsharing Bug #350 [x2godesktopsharing] Make shadow sessions work with --hide option Changed Bug title to 'Add --no-icon cmdline option to x2godesktopsharing' from 'Make shadow sessions work with --hide option' severity -2 wishlist Bug #350 [x2godesktopsharing] Add --no-icon cmdline option to x2godesktopsharing Severity set to 'wishlist' from 'normal'
-- 349: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=349 350: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=350 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
Processing control commands:
tag -1 patch Bug #349 [x2goclient] Make shadow sessions work with --hide option Added tag(s) patch. tag -1 - moreinfo Bug #349 [x2goclient] Make shadow sessions work with --hide option Removed tag(s) moreinfo.
-- 349: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=349 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
Processing control commands:
tag -1 wontfix Bug #350 [x2godesktopsharing] Add --no-icon cmdline option to x2godesktopsharing Added tag(s) wontfix. close -1 Bug #350 [x2godesktopsharing] Add --no-icon cmdline option to x2godesktopsharing Marked Bug as done
-- 350: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=350 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
-
Marco André Dinis -
marcoandredinis＠gmail.com
-
Mike Gabriel -
owner＠bugs.x2go.org