Hi,
by way of an introduction: I maintain the x11/x2go-client package on pkgsrc (<https://pkgsrc.se/x11/x2go-client>).
The package has a few patches, which you may be interested in.
While updating to 4.1.2.3, I stumbled over a build problem: In <https://gitlab.x2go.org/x2go/client/x2goclient/-/commit/fc2db75ab86889cdde6448c4e6e5a25c431d212d>, the MAKEOVERRIDES variable is supposedly set to a list of make variables that are safe to propagate to sub-make processes.*
I find that this breaks the build, since gmake (v4.4.1 here) interprets the first word ("SHELL") as target, which it cannot find. Coincidentally, the Arch package <https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=x2goclient> also has a sed(1) command that cleans out the lists.
What was the motivation of the change? And where does it actually work?
Cheerio, Hauke
-- The ASCII Ribbon Campaign Hauke Fath () No HTML/RTF in email Institut für Nachrichtentechnik /\ No Word docs in email TU Darmstadt Respect for open standards Ruf +49-6151-16-21344
-- The ASCII Ribbon Campaign Hauke Fath () No HTML/RTF in email Institut für Nachrichtentechnik /\ No Word docs in email TU Darmstadt Respect for open standards Ruf +49-6151-16-21344
Hi Hauke,
On Fr 23 Feb 2024 16:43:10 UTC, Hauke Fath (SPG) wrote:
Hi,
by way of an introduction: I maintain the x11/x2go-client package on
pkgsrc (<https://pkgsrc.se/x11/x2go-client>).The package has a few patches, which you may be interested in.
Definitely, can you send merge requests via
https://gitlab.x2go.org/x2go/client/x2goclient/ ?
While updating to 4.1.2.3, I stumbled over a build problem: In
<https://gitlab.x2go.org/x2go/client/x2goclient/-/commit/fc2db75ab86889cdde6448c4e6e5a25c431d212d>, the MAKEOVERRIDES variable is supposedly set to a list of make variables that are safe to propagate to sub-make
processes.*I find that this breaks the build, since gmake (v4.4.1 here)
interprets the first word ("SHELL") as target, which it cannot find.
Coincidentally, the Arch package
<https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=x2goclient>
also has a sed(1) command that cleans out the lists.
Please also propose a patch via our gitlab. Thanks.
What was the motivation of the change? And where does it actually work?
Cheerio, Hauke
DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
On 2024-02-28 13:50, Mike Gabriel wrote:
The package has a few patches, which you may be interested in.
Definitely, can you send merge requests via https://gitlab.x2go.org/x2go/client/x2goclient/ ?
Once I have access, I could...
Cheerio, Hauke
-- The ASCII Ribbon Campaign Hauke Fath () No HTML/RTF in email Institut für Nachrichtentechnik /\ No Word docs in email TU Darmstadt Respect for open standards Ruf +49-6151-16-21344
On Mi 28 Feb 2024 13:58:52 CET, Hauke Fath (SPG) wrote:
On 2024-02-28 13:50, Mike Gabriel wrote:
The package has a few patches, which you may be interested in.
Definitely, can you send merge requests via
https://gitlab.x2go.org/x2go/client/x2goclient/ ?Once I have access, I could...
You should have access now!
DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
Hi Hauke,
On Mo 04 Mär 2024 15:41:48 UTC, Mike Gabriel wrote:
On Mi 28 Feb 2024 13:58:52 CET, Hauke Fath (SPG) wrote:
On 2024-02-28 13:50, Mike Gabriel wrote:
The package has a few patches, which you may be interested in.
Definitely, can you send merge requests via
https://gitlab.x2go.org/x2go/client/x2goclient/ ?Once I have access, I could...
You should have access now!
Mike
Have you managed to get access to our GitLab, yet? Looking forward to
your patches.
DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de