Hi $LIST,
dpkg -L x2gothinclient-minidesktop | grep -i ".svg$" tells me there are two SVG files in this package:
/etc/x2go/x2gothinclient-minidesktop_background.svg /usr/share/backgrounds/x2go/x2gothinclient-minidesktop_background.svg
And according to md5sum, they have the same hash (0f71c9af27b94364625047c0675c69a0), so they are identical.
Is this file really needed in two locations, and why isn't one of them a symlink?
Kind Regards, Stefan Baur
-- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243
Hi Stefan,
On Fr 18 Jan 2019 20:57:41 CET, Stefan Baur wrote:
Hi $LIST,
dpkg -L x2gothinclient-minidesktop | grep -i ".svg$" tells me there are two SVG files in this package:
/etc/x2go/x2gothinclient-minidesktop_background.svg /usr/share/backgrounds/x2go/x2gothinclient-minidesktop_background.svg
And according to md5sum, they have the same hash (0f71c9af27b94364625047c0675c69a0), so they are identical.
Is this file really needed in two locations, and why isn't one of them a symlink?
First, that background file discussed here is the desktop-base
background. Not X2Go Client's inner background.
The idea was (long time ago), to provide a background SVG in
/etc/x2go, symlink it to
/usr/share/backgrounds/x2go/x2gothinclient-minidesktop_background.svg
and then replace the system's default desktop-base background by
/usr/share/backgrounds/x2go/x2gothinclient-minidesktop_background.svg
(which is a symlink to a file in /etc/x2go/.
This has been a bad idea, as I reckon today. It can introduce all
sorts of breakages, if the SVG file in /etc/x2go/ is bogus.
Furthermore, the symlinking code in
debian/x2gothinclient-minidesktop.links was possibly bad, too. Not
100% sure with some more testing.
Today, I would propose another approach: install a background image to
/usr/share/backgrounds/x2go/, make it be the default desktop-base
background and remove it from /etc/x2go/ entirely.
If people want to override the default background image, they need to
use update-alternatives and fiddle with desktop-base themselves.
Before I start working on a patch, let me know what you think.
Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
Am 21.01.19 um 12:52 schrieb Mike Gabriel:
This has been a bad idea, as I reckon today. It can introduce all sorts of breakages, if the SVG file in /etc/x2go/ is bogus.
Furthermore, the symlinking code in debian/x2gothinclient-minidesktop.links was possibly bad, too. Not 100% sure with some more testing.
Today, I would propose another approach: install a background image to /usr/share/backgrounds/x2go/, make it be the default desktop-base background and remove it from /etc/x2go/ entirely.
If people want to override the default background image, they need to use update-alternatives and fiddle with desktop-base themselves.
Before I start working on a patch, let me know what you think.
As you know - or well, you probably noticed from the questions I've asked on IRC and on this list lately - ;-), I've been working on getting a TCE-Live-based MMD ready for use (or at least polished up enough that it might catch the eye and interest of a commercial sponsor ...).
In doing so, I noticed a few other peculiarities as well. Maybe they stem from you not knowing better at the time, maybe they are the way they are because that's just how things need to be with an NFS-based MMD. And maybe I just don't know enough about MATE to fully grasp what you did ...
So maybe we should agree on a time slot and show our findings to each other and work out a plan, not only for this issue, but for the general future of MMD (or TCE-MMD-Live in particular)?
Kind Regards, Stefan Baur
-- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243
Hi Stefan,
On Mo 21 Jan 2019 13:20:46 CET, Stefan Baur wrote:
Am 21.01.19 um 12:52 schrieb Mike Gabriel:
This has been a bad idea, as I reckon today. It can introduce all sorts of breakages, if the SVG file in /etc/x2go/ is bogus.
Furthermore, the symlinking code in debian/x2gothinclient-minidesktop.links was possibly bad, too. Not 100% sure with some more testing.
Today, I would propose another approach: install a background image to /usr/share/backgrounds/x2go/, make it be the default desktop-base background and remove it from /etc/x2go/ entirely.
If people want to override the default background image, they need to use update-alternatives and fiddle with desktop-base themselves.
Before I start working on a patch, let me know what you think.
As you know - or well, you probably noticed from the questions I've asked on IRC and on this list lately - ;-), I've been working on getting a TCE-Live-based MMD ready for use (or at least polished up enough that it might catch the eye and interest of a commercial sponsor ...).
In doing so, I noticed a few other peculiarities as well. Maybe they stem from you not knowing better at the time, maybe they are the way they are because that's just how things need to be with an NFS-based MMD. And maybe I just don't know enough about MATE to fully grasp what you did ...
So maybe we should agree on a time slot and show our findings to each other and work out a plan, not only for this issue, but for the general future of MMD (or TCE-MMD-Live in particular)?
Ping me on IRC and we find a date for sticking our heads together...
;-)
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
On Mon, Jan 21, 2019 at 12:57 PM Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
Today, I would propose another approach: install a background image to /usr/share/backgrounds/x2go/, make it be the default desktop-base background and remove it from /etc/x2go/ entirely.
If people want to override the default background image, they need to use update-alternatives and fiddle with desktop-base themselves.
Why not take the systemd approach and check /etc/x2go first. If there's a background image, take that, else falls back to /usr/share/something.
Uli
Hi,
On Mo 21 Jan 2019 14:45:44 CET, Ulrich Sibiller wrote:
On Mon, Jan 21, 2019 at 12:57 PM Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
Today, I would propose another approach: install a background image to /usr/share/backgrounds/x2go/, make it be the default desktop-base background and remove it from /etc/x2go/ entirely.
If people want to override the default background image, they need to use update-alternatives and fiddle with desktop-base themselves.
Why not take the systemd approach and check /etc/x2go first. If there's a background image, take that, else falls back to /usr/share/something.
Uli
the desktop-base package does not work like that. It expects
/usr/share/images/desktop-base/desktop-background to be a symlink to
$SOMETHING_USABLE_AS_BACKGROUND.
Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
-
Mike Gabriel -
Stefan Baur -
Ulrich Sibiller