Bug#948: X2Go Client fails to create xinerama.conf if screen coordinates have negative values
Package: x2goclient Version: 4.0.5.0 Severity: normal
Hi,
X2Go Client sometimes fails to create the xinerama.conf file in the
server-side X2Go Session directory. This only happens, if screen
coordinates have negative values (which happens when software-side
swapping the client-side monitor layout via xrandr calls).
See error log below (from x2goclient --debug).
Mike
"""
x2go-DEBUG-../src/sshprocess.cpp:199> Executing remote command via
SshProcess object 4: "export DISPLAY=:50;printf '\''-959 -599 1920
1200\n961 -599 1920 1200'\'' >
$HOME/.x2go/C-localadmin-50-1443008544_stDMATE_dp24/xinerama.conf"
x2go-DEBUG-../src/sshprocess.cpp:204> Running
masterCon->addChannelConnection(this,
'"e8c82b86-ae92-4b9b-b5ca-2384cde8ed41"', '"bash -c 'echo
"X2GODATABEGIN:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41"; export
PATH="/usr/local/bin:/usr/bin:/bin"; export DISPLAY=:50;printf
'\''-959 -599 1920 1200\n961 -599 1920 1200'\'' > $HOME/.x2go"');
x2go-DEBUG-../src/sshmasterconnection.cpp:1284> Locking SSH channel
connection MUTEX.
x2go-DEBUG-../src/sshmasterconnection.cpp:1286> Passing new channel
conenction object to channelConnections.
x2go-DEBUG-../src/sshmasterconnection.cpp:1288> Unlocking SSH channel
connection MUTEX.
x2go-DEBUG-../src/sshmasterconnection.cpp:1476> Creating new channel.
x2go-DEBUG-../src/sshmasterconnection.cpp:1480> New channel:0x7fd99c0125a0
x2go-DEBUG-../src/sshmasterconnection.cpp:1511> Executing remote:
"bash -c 'echo "X2GODATABEGIN:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41";
export PATH="/usr/local/bin:/usr/bin:/bin"; export DISPLAY=:50;printf
'\''-959 -599 1920 1200\n961 -599 1920 1200'\'' >
$HOME/.x2go/C-localadmin-50-1443008544_stDMATE_dp24/xinerama.conf;
echo "X2GODATAEND:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41";'"
x2go-DEBUG-../src/sshmasterconnection.cpp:1534> New exec channel created.
x2go-DEBUG-../src/sshmasterconnection.cpp:1638> EOF on channel
0x7fd99c0125a0; SshProcess object: 4
x2go-DEBUG-../src/sshmasterconnection.cpp:1706> EOF sent.
x2go-DEBUG-../src/sshmasterconnection.cpp:1710> Channel closed.
x2go-DEBUG-../src/sshprocess.cpp:517> SSH finished: raw output
(stdout): "X2GODATABEGIN:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41
X2GODATAEND:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41
"
x2go-DEBUG-../src/sshprocess.cpp:523> Have stderr only, something must
be wrong.
x2go-DEBUG-../src/sshprocess.cpp:528> SSH finished: false - "bash:
Zeile 0: printf: -9: Ungültige Option
printf: Gebrauch: printf [-v var] Format [Argumente]
" (4).
"""
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Wäre interessant, was mein neuer Code in dem Fall macht. Ich vermute, der käme da mit klar. ;-)
Uli
On Thu, Sep 24, 2015 at 12:13 PM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
Package: x2goclient Version: 4.0.5.0 Severity: normal
Hi,
X2Go Client sometimes fails to create the xinerama.conf file in the server-side X2Go Session directory. This only happens, if screen coordinates have negative values (which happens when software-side swapping the client-side monitor layout via xrandr calls).
See error log below (from x2goclient --debug).
Mike
""" x2go-DEBUG-../src/sshprocess.cpp:199> Executing remote command via SshProcess object 4: "export DISPLAY=:50;printf '\''-959 -599 1920 1200\n961 -599 1920 1200'\'' > $HOME/.x2go/C-localadmin-50-1443008544_stDMATE_dp24/xinerama.conf" x2go-DEBUG-../src/sshprocess.cpp:204> Running masterCon->addChannelConnection(this, '"e8c82b86-ae92-4b9b-b5ca-2384cde8ed41"', '"bash -c 'echo "X2GODATABEGIN:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41"; export PATH="/usr/local/bin:/usr/bin:/bin"; export DISPLAY=:50;printf '\''-959 -599 1920 1200\n961 -599 1920 1200'\'' > $HOME/.x2go"'); x2go-DEBUG-../src/sshmasterconnection.cpp:1284> Locking SSH channel connection MUTEX. x2go-DEBUG-../src/sshmasterconnection.cpp:1286> Passing new channel conenction object to channelConnections. x2go-DEBUG-../src/sshmasterconnection.cpp:1288> Unlocking SSH channel connection MUTEX. x2go-DEBUG-../src/sshmasterconnection.cpp:1476> Creating new channel.
x2go-DEBUG-../src/sshmasterconnection.cpp:1480> New channel:0x7fd99c0125a0
x2go-DEBUG-../src/sshmasterconnection.cpp:1511> Executing remote: "bash -c 'echo "X2GODATABEGIN:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41"; export PATH="/usr/local/bin:/usr/bin:/bin"; export DISPLAY=:50;printf '\''-959 -599 1920 1200\n961 -599 1920 1200'\'' > $HOME/.x2go/C-localadmin-50-1443008544_stDMATE_dp24/xinerama.conf; echo "X2GODATAEND:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41";'"
x2go-DEBUG-../src/sshmasterconnection.cpp:1534> New exec channel created.
x2go-DEBUG-../src/sshmasterconnection.cpp:1638> EOF on channel 0x7fd99c0125a0; SshProcess object: 4 x2go-DEBUG-../src/sshmasterconnection.cpp:1706> EOF sent. x2go-DEBUG-../src/sshmasterconnection.cpp:1710> Channel closed. x2go-DEBUG-../src/sshprocess.cpp:517> SSH finished: raw output (stdout): "X2GODATABEGIN:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41 X2GODATAEND:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41 " x2go-DEBUG-../src/sshprocess.cpp:523> Have stderr only, something must be wrong. x2go-DEBUG-../src/sshprocess.cpp:528> SSH finished: false - "bash: Zeile 0: printf: -9: Ungültige Option printf: Gebrauch: printf [-v var] Format [Argumente] " (4).
"""
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Am 24.09.2015 um 12:17 schrieb Ulrich Sibiller:
Wäre interessant, was mein neuer Code in dem Fall macht. Ich vermute, der käme da mit klar. ;-) *ahem*.
English, please, when you reply to the list. ;-)
- -Stefan
BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQEcBAEBCAAGBQJWA86iAAoJEG7d9BjNvlEZkrIH/3Z167g+MSVYMFdSTqUeXv0o HES4M8sfezM245I7Y+I4fwUwowenD+MPBXZTQ+LyAyDQascBhrthL8pst1jO5qi6 7vXcFdNPTwDj0uiWyV/JWmDiz37pggusfmnYEste3igByEd6d9FDCzzWaomdL4eY djUJ+8v4gFju4jK20rdC/dOArzp5GcWgED+OMI4a+pEf8rV9i1PPAAu1I66yKb+2 t1PRsjH1+JOA/Cs3V3Tj7XlekDij2OGmlzzEAX5SBNdVLZz7c9OXWIX6hvjxpvcX AaZsVEtr8nxnFvbkrfERyYDRox+n2dNZ9WfIUHhC2sD2lT9wPLiUM/LHrJJ45CE= =y7ez -----END PGP SIGNATURE-----
Hi Ulrich,
On Do 24 Sep 2015 12:17:24 CEST, Ulrich Sibiller wrote:
Wäre interessant, was mein neuer Code in dem Fall macht. Ich vermute, der käme da mit klar. ;-)
Uli
Indeed. Once you have provided a PR on Github, I will merge the new
Xinerama code into nx-libs 3.6.x.
However, for now we need to get X2Go Client fixed (for legacy reasons).
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
On Do 24 Sep 2015 12:13:35 CEST, Mike Gabriel wrote:
x2go-DEBUG-../src/sshmasterconnection.cpp:1511> Executing remote:
"bash -c 'echo "X2GODATABEGIN:e8c82b86-ae92-4b9b-b5ca-2384cde8ed41";
export PATH="/usr/local/bin:/usr/bin:/bin"; export
DISPLAY=:50;printf '\''-959 -599 1920 1200\n961 -599 1920 1200'\'' >
Little shell experiment:
""" [mike@minobo ~]$ printf '1 2 3 4\n' 1 2 3 4 [mike@minobo ~]$ printf "1 2 3 4\n" 1 2 3 4 [mike@minobo ~]$ printf "1 -2 3 4\n" 1 -2 3 4 [mike@minobo ~]$ printf "1 2 -3 4\n" 1 2 -3 4 [mike@minobo ~]$ printf "-1 2 3 4\n" bash: printf: -1: invalid option printf: usage: printf [-v var] format [arguments] [mike@minobo ~]$ printf "-1 -2 3 4\n" bash: printf: -1: invalid option printf: usage: printf [-v var] format [arguments] [mike@minobo ~]$ printf '-1 2 3 4\n' bash: printf: -1: invalid option printf: usage: printf [-v var] format [arguments] [mike@minobo ~]$ printf ' -1 2 3 4\n' -1 2 3 4 """
Obviously, the printf command is "buggy" somehow, because it should
not interpret the "-1" in
printf "-1 2 3 4\n"
as command line parameter.
I will think about filing a bug against Debian's coreutils package.
Mike
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Am 24.09.2015 um 13:14 schrieb Mike Gabriel:
Obviously, the printf command is "buggy" somehow, because it should not interpret the "-1" in
printf "-1 2 3 4\n"
as command line parameter.
I will think about filing a bug against Debian's coreutils package.
Some tools require a "--" as a "no more parameters ahead" delimiter if you intend to use values that start with "-".
Did you try this?
printf -- "-1 2 3 4\n"
(Not on a Linux machine right now, so can't try it myself)
- -Stefan
BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQEcBAEBCAAGBQJWA9vYAAoJEG7d9BjNvlEZ828H/3DtmPEeCphKXrTO5tQRjMGh ar6MIs0bc1mzbESc0IIkNTk9qhQFE++UlsDw3kbe7kiLKtUjyPWyscaEzaRxG8fu FU45pVgkZmLjT5jPkH2e0rXtzqdoh7tsLxUBGrCWLpwmpissuFQy+vCFE8FFJEJ2 yMjf1G2DPWHn8oS7kYfEPRiXHQWjFA8o3T6/eSwaBEpBCn7QWUZEUxczHfKrkFzk HMqjDMBigjTxN3W6npt9UDFphpTtDbCzlLjzipxLPKSRiQDhTxbdN+9sbY9v85RT 05XMEoU7mWrFyPoWDH7FSK1cEsWum7yyGQdolnEhj6+x1wkv4SgZle87bsjcDvE= =tuKd -----END PGP SIGNATURE-----
-
Mike Gabriel -
Stefan Baur -
Ulrich Sibiller