Package: x2goserver Version: 4.0.1.20
When a username is rejected by the 'valid username' test (see separate bug report<https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1229>), the session doesn't fail, but simply seems to hang, giving no feedback about the problem, nor, as far as I can see, reporting anything in the logs.
To reproduce, attempt to log in using a username such as '123x'. The session doesn't complete the setup, leaving the user at a blank screen.
Suggestion: a user-visible error message should be produced, and an informative message sent to the system log.
Best wishes,
Norman
-- Norman Gray : https://nxg.me.uk
Control: tag -1 -pending Control: notfixed -1 4.0.1.21
On 10/27/2017 07:02 PM, Norman Gray wrote:
Package: x2goserver Version: 4.0.1.20
When a username is rejected by the 'valid username' test (see separate bug report<https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1229>), the session doesn't fail, but simply seems to hang, giving no feedback about the problem, nor, as far as I can see, reporting anything in the logs.
To reproduce, attempt to log in using a username such as '123x'. The session doesn't complete the setup, leaving the user at a blank screen.
Suggestion: a user-visible error message should be produced, and an informative message sent to the system log.
I've tried catching errors while inserting values into the database, but it turns out that doing this is not easily possible, since the current code relies on brute-force adding of new DB entries and ignoring errors until it succeeds. If a hard error occurs that will make any insertion fail, of course this will loop forever.
I'll need to implement something more sophisticated that detects hard errors which will always lead to failures.
Mihai
Processing control commands:
tag -1 -pending Bug #1230 [x2goserver] x2go fails unhelpfully when a session fails to start Removed tag(s) pending. notfixed -1 4.0.1.21 Bug #1230 [x2goserver] x2go fails unhelpfully when a session fails to start There is no source info for the package 'x2goserver' at version '4.0.1.21' with architecture '' Unable to make a source version for version '4.0.1.21' No longer marked as fixed in versions 4.0.1.21.
-- 1230: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1230 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
tag #1230 pending fixed #1230 4.0.1.23 thanks Hi! X2Go issue #1230 (src:x2goserver) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=7a76b291 The issue will most likely be fixed in src:x2goserver (4.0.1.23). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 7a76b291ed589775ee5d84c34b677fd621ce6d11 Author: Mihai Moldovan <ionic@ionic.de> Date: Thu Jan 4 06:16:51 2018 +0100 x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport instead of duplicating the same code everywhere. Fixes: #1230. Also, rely on it returning a valid value and try at most 10 times to fetch a usable port value, then error out and make the session startup or resumption fail. diff --git a/debian/changelog b/debian/changelog index 818e823e..f8582d47 100644 --- a/debian/changelog +++ b/debian/changelog @@ -51,6 +51,11 @@ x2goserver (4.0.1.23-0x2go1) UNRELEASED; urgency=medium quotes on the lib path line. - x2goserver/bin/x2goresume-session: properly randomize first port, just like in x2gostartagent. + - x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport + instead of duplicating the same code everywhere. Fixes: #1230. Also, + rely on it returning a valid value and try at most 10 times to fetch a + usable port value, then error out and make the session startup or + resumption fail. * x2goserver.spec: - RPMify x2goserver-xsession description. - Remove qt4 stuff, we're not using the framework here.
Processing commands for control@bugs.x2go.org:
tag #1230 pending Bug #1230 [x2goserver] x2go fails unhelpfully when a session fails to start Ignoring request to alter tags of bug #1230 to the same tags previously set fixed #1230 4.0.1.23 Bug #1230 [x2goserver] x2go fails unhelpfully when a session fails to start There is no source info for the package 'x2goserver' at version '4.0.1.23' with architecture '' Unable to make a source version for version '4.0.1.23' Ignoring request to alter fixed versions of bug #1230 to the same values previously set thanks Stopping processing here.
1230: bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1230 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems
tag #1230 pending fixed #1230 4.0.1.23 thanks Hi! X2Go issue #1230 (src:x2goserver) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=7a76b291 The issue will most likely be fixed in src:x2goserver (4.0.1.23). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 7a76b291ed589775ee5d84c34b677fd621ce6d11 Author: Mihai Moldovan <ionic@ionic.de> Date: Thu Jan 4 06:16:51 2018 +0100 x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport instead of duplicating the same code everywhere. Fixes: #1230. Also, rely on it returning a valid value and try at most 10 times to fetch a usable port value, then error out and make the session startup or resumption fail. diff --git a/debian/changelog b/debian/changelog index 818e823e..f8582d47 100644 --- a/debian/changelog +++ b/debian/changelog @@ -51,6 +51,11 @@ x2goserver (4.0.1.23-0x2go1) UNRELEASED; urgency=medium quotes on the lib path line. - x2goserver/bin/x2goresume-session: properly randomize first port, just like in x2gostartagent. + - x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport + instead of duplicating the same code everywhere. Fixes: #1230. Also, + rely on it returning a valid value and try at most 10 times to fetch a + usable port value, then error out and make the session startup or + resumption fail. * x2goserver.spec: - RPMify x2goserver-xsession description. - Remove qt4 stuff, we're not using the framework here.
Processing commands for control@bugs.x2go.org:
tag #1230 pending Bug #1230 [x2goserver] x2go fails unhelpfully when a session fails to start Ignoring request to alter tags of bug #1230 to the same tags previously set fixed #1230 4.0.1.23 Bug #1230 [x2goserver] x2go fails unhelpfully when a session fails to start There is no source info for the package 'x2goserver' at version '4.0.1.23' with architecture '' Unable to make a source version for version '4.0.1.23' Ignoring request to alter fixed versions of bug #1230 to the same values previously set thanks Stopping processing here.
1230: bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1230 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems