Package: x2goclient Version: git master
Hi,
at Gentoo latest version of the dash shell doesn't support "echo -n" anymore[1]. The result is that x2gpath returns every path with a prefixed "-n " when dash is used as /bin/sh. Accoring to "man p1 echo" section "APPLICATION USAGE" applications should not rely on "echo -n" but use printf instead. The attached patch does exactly that.
Kind regards Lars
[1] https://bugs.gentoo.org/528452
-- Lars Wendler Gentoo package maintainer GPG: 4DD8 C47C CDFA 5295 E1A6 3FC8 F696 74AB 981C A6FC
Control: reassign -1 x2goserver Control: tag -1 patch Control: severity -1 important
Hi Lars,
On Fr 07 Nov 2014 16:51:42 CET, Lars Wendler wrote:
Package: x2goclient Version: git master
Hi,
at Gentoo latest version of the dash shell doesn't support "echo -n" anymore[1]. The result is that x2gpath returns every path with a prefixed "-n " when dash is used as /bin/sh. Accoring to "man p1 echo" section "APPLICATION USAGE" applications should not rely on "echo -n" but use printf instead. The attached patch does exactly that.
Kind regards Lars
I will apply your patch ASAP. You made a valid point!
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Processing control commands:
reassign -1 x2goserver Bug #668 [x2goclient] [Patch] Replace "echo -n" with printf Bug reassigned from package 'x2goclient' to 'x2goserver'. Ignoring request to alter found versions of bug #668 to the same values previously set Ignoring request to alter fixed versions of bug #668 to the same values previously set tag -1 patch Bug #668 [x2goserver] [Patch] Replace "echo -n" with printf Added tag(s) patch. severity -1 important Bug #668 [x2goserver] [Patch] Replace "echo -n" with printf Severity set to 'important' from 'normal'
-- 668: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=668 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems