Hi all
For the last couple of weeks, I've been working on the OS X side of X2Go Client, as some of you may or may not have noticed.
Part of that work was a restructuring of the x2goclient.git repository. I started forking master to features/cleanup, gradually moved files around into new sub-directories and adapted all files affected by these moves.
Additionally, macbuild.sh has been severely improved. It now supports multiple environment variables. A help message can be queried by (./)macbuild.sh -h or --help from any OS and will not be included here. x2goclient is now built in the client_build sub-directory to not pollute the main directory or overwrite the Makefile.
List of changes:
A visual representation of these changes can be seen when comparing
http://code.x2go.org/gitweb?p=x2goclient.git;a=tree and http://code.x2go.org/gitweb?p=x2goclient.git;a=tree;h=refs/heads/feature/cle...
The bugfix/osx branch is currently equivalent to features/cleanup. Subsequent OS X fixes will be published on bugfix/osx.
features/cleanup is scheduled to be merged into master (and thus become the X2Go Client 4.0.4.0 base) either shortly after this report, or after the upcoming X2Go Developer Meeting at the beginning of March.
What is YOUR opinion?
Best,
Mihai
On Do 19 Feb 2015 15:56:46 CET, Mihai Moldovan wrote:
features/cleanup is scheduled to be merged into master (and thus become the X2Go Client 4.0.4.0 base) either shortly after this report, or after the upcoming X2Go Developer Meeting at the beginning of March.
The features/cleanup branch looks great (by vision).
If it builds and does not break stuff, +1 from my side. If more
reviewing is required, please drag me in via IRC.
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
On 19.02.2015 03:56 PM, Mihai Moldovan wrote:
features/cleanup is scheduled to be merged into master (and thus become the X2Go Client 4.0.4.0 base) either shortly after this report, or after the upcoming X2Go Developer Meeting at the beginning of March.
I have merged the branch into master.
Mike#2: I had to obviously also change the Windows build scripts to make everything work. Those changes are now also merged to buildscripts.git's master branch. Please note that building is now done in the subdirectories client_build and plugin_build and does NOT clobber the whole main directory anymore. Testing would be appreciated. (I have only tested building, but not installing the .exe or anything else.)
Mihai