Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking
Package: x2goclient Version: 4.0.2.1 Severity: wishlist
Given the ease of use of Visual Studio's built-in debugger, the ability to compile X2GoClient in Visual Studio 2010 would be highly appreciated by developers eager to contribute in the evolution of X2GoClient for Windows.
Using the attached patch (also added config_win_vs.bat) I have only managed to compile x2gofree (with VS2010 nmake) on the command line. Despite my changes in x2goclient.pro, Qt4 Visual Studio Add-in cannot produce a working project file (x2goclient.vcxproj). Any help to enable building x2gofree in Visual Studio 2010 is welcome.
PS. The change in ONMainWindow::slotRetResumeSess is also mandatory for GCC 4.8.2 (i686-4.8.2-release-posix-dwarf-rt_v3-rev3).
George Trakatelis Department of Applied Informatics, School of Information Sciences University of Macedonia, Greece
Hi Alex, hi Mike#2,
On Mi 15 Okt 2014 16:45:54 CEST, George Trakatelis wrote:
Package: x2goclient Version: 4.0.2.1 Severity: wishlist
Given the ease of use of Visual Studio's built-in debugger, the ability to compile X2GoClient in Visual Studio 2010 would be highly appreciated by developers eager to contribute in the evolution of X2GoClient for Windows.
Using the attached patch (also added config_win_vs.bat) I have only managed to compile x2gofree (with VS2010 nmake) on the command line. Despite my changes in x2goclient.pro, Qt4 Visual Studio Add-in cannot produce a working project file (x2goclient.vcxproj). Any help to enable building x2gofree in Visual Studio 2010 is welcome.
PS. The change in ONMainWindow::slotRetResumeSess is also mandatory for GCC 4.8.2 (i686-4.8.2-release-posix-dwarf-rt_v3-rev3).
Please review George's patch. And possibly give support (if time
allows it and priority provides it).
Thanks! Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
patch is ok.
regards, Alex. Am 15.10.2014 22:33, schrieb Mike Gabriel:
Hi Alex, hi Mike#2,
On Mi 15 Okt 2014 16:45:54 CEST, George Trakatelis wrote:
Package: x2goclient Version: 4.0.2.1 Severity: wishlist
Given the ease of use of Visual Studio's built-in debugger, the ability to compile X2GoClient in Visual Studio 2010 would be highly appreciated by developers eager to contribute in the evolution of X2GoClient for Windows.
Using the attached patch (also added config_win_vs.bat) I have only managed to compile x2gofree (with VS2010 nmake) on the command line. Despite my changes in x2goclient.pro, Qt4 Visual Studio Add-in cannot produce a working project file (x2goclient.vcxproj). Any help to enable building x2gofree in Visual Studio 2010 is welcome.
PS. The change in ONMainWindow::slotRetResumeSess is also mandatory for GCC 4.8.2 (i686-4.8.2-release-posix-dwarf-rt_v3-rev3).
Please review George's patch. And possibly give support (if time allows it and priority provides it).
Thanks! Mike
--
Oleksandr Shneyder | Email: o.shneyder@phoca-gmbh.de phoca GmbH | Tel. : 0911 - 14870374 0 Ludwig-Feuerbach-str. 18 | Fax. : 0911 - 14870374 9 D-90489 Nürnberg | Mobil: 0163 - 49 64 461
Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder
Amtsgericht München | http://www.phoca-gmbh.de HRB 196 658 | http://www.x2go.org USt-IdNr.: DE281977973
I can merge it this evening. But should we merge it right before we release 4.0.3.0?
Sent from my Android Smartphone On Oct 16, 2014 5:05 AM, "Oleksandr Shneyder" <o.shneyder@phoca-gmbh.de> wrote:
patch is ok.
regards, Alex. Am 15.10.2014 22:33, schrieb Mike Gabriel:
Hi Alex, hi Mike#2,
On Mi 15 Okt 2014 16:45:54 CEST, George Trakatelis wrote:
Package: x2goclient Version: 4.0.2.1 Severity: wishlist
Given the ease of use of Visual Studio's built-in debugger, the ability to compile X2GoClient in Visual Studio 2010 would be highly appreciated by developers eager to contribute in the evolution of X2GoClient for Windows.
Using the attached patch (also added config_win_vs.bat) I have only managed to compile x2gofree (with VS2010 nmake) on the command line. Despite my changes in x2goclient.pro, Qt4 Visual Studio Add-in cannot produce a working project file (x2goclient.vcxproj). Any help to enable building x2gofree in Visual Studio 2010 is welcome.
PS. The change in ONMainWindow::slotRetResumeSess is also mandatory for GCC 4.8.2 (i686-4.8.2-release-posix-dwarf-rt_v3-rev3).
Please review George's patch. And possibly give support (if time allows it and priority provides it).
Thanks! Mike
--
Oleksandr Shneyder | Email: o.shneyder@phoca-gmbh.de phoca GmbH | Tel. : 0911 - 14870374 0 Ludwig-Feuerbach-str. 18 | Fax. : 0911 - 14870374 9 D-90489 Nürnberg | Mobil: 0163 - 49 64 461
Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder
Amtsgericht München | http://www.phoca-gmbh.de HRB 196 658 | http://www.x2go.org USt-IdNr.: DE281977973
x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
Hi Mike#2
On Do 16 Okt 2014 16:16:16 CEST, Michael DePaulo wrote:
I can merge it this evening. But should we merge it right before we release 4.0.3.0?
No, please wait till 4.0.3.0 is out.
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Dear Michael,
Please wait a little bit more before applying the patch as I will split it into 2 or 3 parts and give a word or two of explanation on each part.
George
-----Original Message----- From: Mike Gabriel [mailto:mike.gabriel@das-netzwerkteam.de] Sent: Thursday, October 16, 2014 5:30 PM To: Cc: 642@bugs.x2go.org; Oleksandr Shneyder; o.schneyder@phoca-gmbh.de; George Trakatelis Subject: Re: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking
Hi Mike#2
On Do 16 Okt 2014 16:16:16 CEST, Michael DePaulo wrote:
I can merge it this evening. But should we merge it right before we release 4.0.3.0?
No, please wait till 4.0.3.0 is out.
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Hi Michael,
Now that release 4.0.3.0 of x2goclient is out, I attach my proposed changes and comment on each one:
- conform-to-stricter-type-checking-mingw482.patch
Even mingw's debug build complains about this char * not having been declared as ought to be (const char *) and suggests using -fpermissive (not recommended).
- conform-to-stricter-type-checking-VS2010.patch
a. A type-cast to match one of pow's declarations {float pow(float x, int y);} b. In pure Windows there's no close() function to close a socket. So you have to use closesocket() instead. c. Include winsock2.h just before windows.h (also recommended by mingw).
- add-libraries-to-build-with-VS2010.patch
a. A new batch file to configure x2goclient for VS2010 build (config_win_vs.bat). I have just substituted nmake for mingw32-make. Please remember to also use 'nmake' or 'nmake debug' when building. b. Added necessary win32 libraries.
George
-----Original Message----- From: Mike Gabriel [mailto:mike.gabriel@das-netzwerkteam.de] Sent: Thursday, October 16, 2014 5:30 PM To: Michael DePaulo Cc: 642@bugs.x2go.org; Oleksandr Shneyder; o.schneyder@phoca-gmbh.de; George Trakatelis Subject: Re: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking
Hi Mike#2
On Do 16 Okt 2014 16:16:16 CEST, Michael DePaulo wrote:
I can merge it this evening. But should we merge it right before we release 4.0.3.0?
No, please wait till 4.0.3.0 is out.
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das- netzwerkteam.de.xfb
Hi George,
On Di 28 Okt 2014 06:15:54 CET, George Trakatelis wrote:
Hi Michael,
Now that release 4.0.3.0 of x2goclient is out, I attach my proposed changes and comment on each one:
- conform-to-stricter-type-checking-mingw482.patch
Even mingw's debug build complains about this char * not having been declared as ought to be (const char *) and suggests using -fpermissive (not recommended).
- conform-to-stricter-type-checking-VS2010.patch
a. A type-cast to match one of pow's declarations {float pow(float
x, int y);} b. In pure Windows there's no close() function to close a socket. So you have to use closesocket() instead. c. Include winsock2.h just before windows.h (also recommended by mingw).
- add-libraries-to-build-with-VS2010.patch
a. A new batch file to configure x2goclient for VS2010 build
(config_win_vs.bat). I have just substituted nmake for mingw32-make. Please remember to also use 'nmake' or 'nmake debug' when building. b. Added necessary win32 libraries.George
Thanks a lot for providing those patches.
Will applying all those patches provide enough reason/solution to
close this bug (#642)?
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Hi Mike,
My initial intention was to build X2GoClient for Windows using the VS2010 IDE, but that seems to be impossible for the time being due to a Qt4 Visual Studio Add-in limitation. The provided patches:
- 'conform-to-stricter-type-checking-mingw482.patch',
- 'conform-to-stricter-type-checking-VS2010.patch', and
- the now attached 'add-libraries-to-build-with-VS2010-command-line.patch' (which supersedes previously attached 'add-libraries-to-build-with-VS2010.patch')
make it possible to build X2GoClient for Windows 4.0.3.0 from the command line using Visual Studio's nmake (one has to install VS2010 and Qt 4.8.6 for VS2010). As this wishlist bug is actually resolved by applying the 3 patches, my answer is 'Yes, you can close it, provided that at least one volunteer confirms its validity'.
George
-----Original Message----- From: Mike Gabriel [mailto:mike.gabriel@das-netzwerkteam.de] Sent: Tuesday, October 28, 2014 9:55 AM To: George Trakatelis; 642@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking
Hi George,
On Di 28 Okt 2014 06:15:54 CET, George Trakatelis wrote:
Hi Michael,
Now that release 4.0.3.0 of x2goclient is out, I attach my proposed changes and comment on each one:
- conform-to-stricter-type-checking-mingw482.patch
Even mingw's debug build complains about this char * not having been declared as ought to be (const char *) and suggests using - fpermissive (not recommended).
- conform-to-stricter-type-checking-VS2010.patch
a. A type-cast to match one of pow's declarations {float pow(float x, int y);} b. In pure Windows there's no close() function to close a socket. So you have to use closesocket() instead. c. Include winsock2.h just before windows.h (also recommended by mingw).
- add-libraries-to-build-with-VS2010.patch
a. A new batch file to configure x2goclient for VS2010 build (config_win_vs.bat). I have just substituted nmake for mingw32-make. Please remember to also use 'nmake' or 'nmake debug' when building. b. Added necessary win32 libraries.
George
Thanks a lot for providing those patches.
Will applying all those patches provide enough reason/solution to close this bug (#642)?
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das- netzwerkteam.de.xfb
HI Mike#2
On Di 28 Okt 2014 17:55:52 CET, George Trakatelis wrote:
As this wishlist bug is actually resolved by applying the 3 patches,
my answer is 'Yes, you can close it, provided that at least one volunteer confirms its validity'. ^^^^^^^^^^^^^^^^^^^^^
@Mike#2: I fear, this is on you...
Mike#1
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 28.10.2014 um 18:49 schrieb Mike Gabriel:
@Mike#2: I fear, this is on you...
I'd wager a guess that he won't read that or at least he won't be able to test that until he arrives at X2Go: The Gathering ...
- -Stefan
BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32)
iQEcBAEBAgAGBQJUUBh/AAoJEG7d9BjNvlEZsKoH/RnQRjkNb1O6avuwUG6epiHl W+eLu/8wGb9Lv8x92V1YKUSdd2DYgIj0DPPOPJLQ7GbFfrw8zL14pkyvt3rjmBms 732oSHgSGHU0Dt8J1iDWL/69zJotvMl2KxD+U0igLjy8gv9ATM6EGBiFQnk42Ct8 aU3xcTcJs4L0EMsbCuI/QxLpZdkPub0trKIAN6AIe5ufXMuyAX/DZkFFy7Rs5OCl sD1+MKT6JqxsVviui/Go8WXFz90BxELdUEW0PO1tLkXo22qN/a7NhAP+RNAyblas IifS5+Yae9YoHAJo1rSljAoKSufJsjtEaYNSiQk8q1zGLpueWInDKOLe3j14Ua4= =Pf7B -----END PGP SIGNATURE-----
Hi Mikes,
I have just discovered an error in one of the previously provided patch files. Windows sockets cleanup is handled in SshProcess::~SshProcess() (as it should be), so I had to remove WSACleanup() from patched SshMasterConnection::finalize(int) which caused a connection error if someone -after logging out- tried to login to the same server.
To avoid any ambiguity I re-attach the correct patch files.
George
PS. I wish a constructive gathering to all participants.
-----Original Message----- From: Mike Gabriel [mailto:mike.gabriel@das-netzwerkteam.de] Sent: Tuesday, October 28, 2014 7:49 PM To: George Trakatelis Cc: 642@bugs.x2go.org; 'Mike DePaulo' Subject: Re: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking
HI Mike#2
On Di 28 Okt 2014 17:55:52 CET, George Trakatelis wrote:
As this wishlist bug is actually resolved by applying the 3 patches, my answer is 'Yes, you can close it, provided that at least one volunteer confirms its validity'. ^^^^^^^^^^^^^^^^^^^^^
@Mike#2: I fear, this is on you...
Mike#1
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das- netzwerkteam.de.xfb
On Thu, Oct 30, 2014 at 2:44 AM, George Trakatelis <trakatelis@uom.edu.gr> wrote: ...
To avoid any ambiguity I re-attach the correct patch files. ...
Sorry for the delay. I will test out the patches this weekend.
-Mike#2
-
George Trakatelis -
Michael DePaulo -
Mike Gabriel -
Oleksandr Shneyder -
Stefan Baur