Dear folks:
i'm trying to build a simple & cost efficiency internet devices for vulnerable children and group in taiwan. here is traditional chinese translation for x2goclient, please help me to find out if there has any problem if you have free time, thx.
because locale name for traditional chinese is zh_TW, so it need to comment out one line in ONMainWindow:: installTranslator() makes this function not to force translation resource name to lower case.
regards.
Dear Arlo,
Thank you so much for your contribution!!!
On Fr 30 Dez 2011 08:03:51 CET Arlo Liu wrote:
Dear folks:
i'm trying to build a simple & cost efficiency internet devices for vulnerable children and group in taiwan. here is traditional chinese translation for x2goclient, please help me to find out if there has any problem if you have free time, thx.
because locale name for traditional chinese is zh_TW, so it need to comment out one line in ONMainWindow:: installTranslator() makes this function not to force translation resource name to lower case.
regards.
The patch tarball has arrived in a broken state here. Could you resend
your file and check the tarball integrity before sending?
Thanks, Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Am 30.12.2011 12:05, Mike Gabriel schrieb:
The patch tarball has arrived in a broken state here. Could you resend your file and check the tarball integrity before sending?
Looks ok to me (I could open the .patch).
Cheers Morty
Hi Morty,
On Fr 30 Dez 2011 12:38:30 CET Moritz Strübe wrote:
Am 30.12.2011 12:05, Mike Gabriel schrieb:
The patch tarball has arrived in a broken state here. Could you resend your file and check the tarball integrity before sending?
Looks ok to me (I could open the .patch).
weird... Could you evaluate the patch then?
Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
On Fr, Dez 30, 2011 at 13:56:31 (CET), Mike Gabriel wrote:
Hi Morty,
On Fr 30 Dez 2011 12:38:30 CET Moritz Strübe wrote:
Am 30.12.2011 12:05, Mike Gabriel schrieb:
The patch tarball has arrived in a broken state here. Could you resend your file and check the tarball integrity before sending?
Looks ok to me (I could open the .patch).
weird... Could you evaluate the patch then?
This is the patch. diff --git a/onmainwindow.cpp b/onmainwindow.cpp index 81dce94..0295cae 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -438,7 +438,7 @@ void ONMainWindow::installTranslator() QTranslator* x2goclientTranslator=new QTranslator(); QString filename=QString ( ":/x2goclient_%1" ).arg ( QLocale::system().name() ); - filename=filename.toLower(); + //filename=filename.toLower(); if ( !x2goclientTranslator->load ( filename ) ) { qDebug ( "Can't load translator (%s) !\n", I think Alex needs to comment on that. Cheers, Reinhard -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4
Am 30.12.2011 21:21, Reinhard Tartler schrieb:
QString filename=QString ( ":/x2goclient_%1" ).arg ( QLocale::system().name() );
- filename=filename.toLower();
- //filename=filename.toLower(); if ( !x2goclientTranslator->load ( filename ) )
I think we're safe to use the patch:
"Returns the language and country of this locale as a string of the form "language_country", where language is a lowercase, two-letter ISO 639 language code, and country is an uppercase, two- or three-letter ISO 3166 country code." http://developer.qt.nokia.com/doc/qt-4.8/qlocale.html#name
Cheers Morty
Thanks for your help, many regions need both language and country code to identify the correct locale, due to the 50KB attachment limitation, i have repacked this patch to zip archive file as attached file.
regards. Arlo
2011/12/31 Moritz Strübe <Moritz.Struebe@informatik.uni-erlangen.de>
Am 30.12.2011 21:21, Reinhard Tartler schrieb:
QString filename=QString ( ":/x2goclient_%1" ).arg ( QLocale::system().name() );
- filename=filename.toLower();
- //filename=filename.toLower(); if ( !x2goclientTranslator->load ( filename ) )
I think we're safe to use the patch:
"Returns the language and country of this locale as a string of the form "language_country", where language is a lowercase, two-letter ISO 639 language code, and country is an uppercase, two- or three-letter ISO 3166 country code." http://developer.qt.nokia.com/doc/qt-4.8/qlocale.html#name
Cheers Morty
X2go-Dev mailing list X2go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
-- Arlo Liu Atrust Computer Corp. http://www.atrustcorp.com Tel: +886-3-3288837 ext.71 Fax: +886-3-3288973 3F., No.361, Fusing 1st Rd., Gueishan Township, Taoyuan County 333, Taiwan
Hi Alex, On Fr 30 Dez 2011 21:21:01 CET Reinhard Tartler wrote:
On Fr, Dez 30, 2011 at 13:56:31 (CET), Mike Gabriel wrote:
Hi Morty,
On Fr 30 Dez 2011 12:38:30 CET Moritz Strübe wrote:
Am 30.12.2011 12:05, Mike Gabriel schrieb:
The patch tarball has arrived in a broken state here. Could you resend your file and check the tarball integrity before sending?
Looks ok to me (I could open the .patch).
weird... Could you evaluate the patch then?
This is the patch.
diff --git a/onmainwindow.cpp b/onmainwindow.cpp index 81dce94..0295cae 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -438,7 +438,7 @@ void ONMainWindow::installTranslator() QTranslator* x2goclientTranslator=new QTranslator(); QString filename=QString ( ":/x2goclient_%1" ).arg ( QLocale::system().name() );
- filename=filename.toLower();
- //filename=filename.toLower(); if ( !x2goclientTranslator->load ( filename ) ) { qDebug ( "Can't load translator (%s) !\n",
I think Alex needs to comment on that.
Alex, I would like to make x2goclient available to zh_TW. Can you pick out the patch referred to in this mail (it was on the x2go-dev list) and commit if approved? Thanks, Mike -- DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419 GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Hi Mike, Am 27.01.2012 13:28, schrieb Mike Gabriel:
Hi Alex,
On Fr 30 Dez 2011 21:21:01 CET Reinhard Tartler wrote:
On Fr, Dez 30, 2011 at 13:56:31 (CET), Mike Gabriel wrote:
Hi Morty,
On Fr 30 Dez 2011 12:38:30 CET Moritz Strübe wrote:
Am 30.12.2011 12:05, Mike Gabriel schrieb:
The patch tarball has arrived in a broken state here. Could you resend your file and check the tarball integrity before sending?
Looks ok to me (I could open the .patch).
weird... Could you evaluate the patch then?
This is the patch.
diff --git a/onmainwindow.cpp b/onmainwindow.cpp index 81dce94..0295cae 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -438,7 +438,7 @@ void ONMainWindow::installTranslator() QTranslator* x2goclientTranslator=new QTranslator(); QString filename=QString ( ":/x2goclient_%1" ).arg ( QLocale::system().name() );
- filename=filename.toLower();
- //filename=filename.toLower(); if ( !x2goclientTranslator->load ( filename ) ) { qDebug ( "Can't load translator (%s) !\n",
I think Alex needs to comment on that.
Alex, I would like to make x2goclient available to zh_TW. Can you pick out the patch referred to in this mail (it was on the x2go-dev list) and commit if approved?
Thanks, Mike
There is no need to make such changes in X2goClient. It is common practice to create translation files in lower case. See Qt documentation: http://developer.qt.nokia.com/doc/qt-4.8/qtranslator.html#load All what you need to use zh_TW localisation is to create translation file "x2goclient_zh_tw.ts" (in lower case) and add this translation to project file "x2goclient.pro": TRANSLATIONS += x2goclient_zh_tw.ts and to resources file "resources.rcc": <file>x2goclient_zh_tw.qm</file> regards, Alex -- Oleksandr Shneyder Dipl. Informatik X2go Core Developer Team email: oleksandr.shneyder@obviously-nice.de web: www.obviously-nice.de --> X2go - everywhere@home
Hi Alex,
On Mo 30 Jan 2012 08:24:27 CET Oleksandr Shneyder wrote:
There is no need to make such changes in X2goClient. It is common practice to create translation files in lower case. See Qt documentation: http://developer.qt.nokia.com/doc/qt-4.8/qtranslator.html#load
All what you need to use zh_TW localisation is to create translation file "x2goclient_zh_tw.ts" (in lower case) and add this translation to project file "x2goclient.pro":
TRANSLATIONS += x2goclient_zh_tw.ts
and to resources file "resources.rcc":
<file>x2goclient_zh_tw.qm</file>
Please refer to this link... http://permalink.gmane.org/gmane.linux.terminal-server.x2go.devel/2948
It has a zip file attached that includes a modified resources.rcc and
x2goclient_zh_tw.ts with all the chinese translation.
My question was aiming at including the chinese translation itself.
Not only the patch to load it (which is obsolete with the information
you gave above).
Greets, Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Am 30.01.2012 09:03, schrieb Mike Gabriel:
Hi Alex,
On Mo 30 Jan 2012 08:24:27 CET Oleksandr Shneyder wrote:
There is no need to make such changes in X2goClient. It is common practice to create translation files in lower case. See Qt documentation: http://developer.qt.nokia.com/doc/qt-4.8/qtranslator.html#load
All what you need to use zh_TW localisation is to create translation file "x2goclient_zh_tw.ts" (in lower case) and add this translation to project file "x2goclient.pro":
TRANSLATIONS += x2goclient_zh_tw.ts
and to resources file "resources.rcc":
<file>x2goclient_zh_tw.qm</file>
Please refer to this link... http://permalink.gmane.org/gmane.linux.terminal-server.x2go.devel/2948
It has a zip file attached that includes a modified resources.rcc and x2goclient_zh_tw.ts with all the chinese translation.
My question was aiming at including the chinese translation itself. Not only the patch to load it (which is obsolete with the information you gave above).
Greets, Mike
X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
Sure, I have nothing against translation for x2goclient. I'll include this translation file in x2goclient and will push it in git
regards, Alex
Oleksandr Shneyder Dipl. Informatik X2go Core Developer Team
email: oleksandr.shneyder@obviously-nice.de web: www.obviously-nice.de
--> X2go - everywhere@home
Am 30.01.2012 09:39, schrieb Oleksandr Shneyder:
Am 30.01.2012 09:03, schrieb Mike Gabriel:
[............]
My question was aiming at including the chinese translation itself. Not only the patch to load it (which is obsolete with the information you gave above).
Greets, Mike
X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
Sure, I have nothing against translation for x2goclient. I'll include this translation file in x2goclient and will push it in git
regards, Alex
http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=cebb1bdee16a707e...
regards, Alex
Oleksandr Shneyder Dipl. Informatik X2go Core Developer Team
email: oleksandr.shneyder@obviously-nice.de web: www.obviously-nice.de
--> X2go - everywhere@home
-
Arlo Liu -
Mike Gabriel -
Moritz Strübe -
Oleksandr Shneyder -
Reinhard Tartler