Hi.
I like to know how to change the title of the window of the frontend of pyhoca, to show only the user and the ip address or server
Thank you so much
El hombre, así como el software, debe ser libre. GNU es libertad. Linux user #461462
Escuchad mi palabra, un nuevo mandamiento os doy: "Derribad las naciones, con tolerancia y golpes de amor"
Hi Edwin,
On Fr 25 Nov 2011 08:15:09 CET Edwin Hernán Hurtado Cruz wrote:
Hi.
I like to know how to change the title of the window of the frontend of pyhoca, to show only the user and the ip address or server
What exactly do you mean by ,,frontend''? The window of a running session?
In case you mean that: the session window title is set with the -name
option when x2goagent is launched from within the (server-side) script
x2gostartagent... The lines you have to look for are these:
if [ "$X2GO_STYPE" == "S" ]; then
LD_LIBRARY_PATH=$X2GO_LIB x2goagent $X2GODPIOPTION_
-$SESSION_TYPE -auth ~/.Xauthority -S -shadow $SHADOW_DESKTOP
-shadowmode $SHADOW_MODE -geometry ${X2GO_GEOMETRY} -name
"X2GO-${SESSION_NAME}" ${NX_AGENT} 2>${SESSION_DIR}/session.log &
else
LD_LIBRARY_PATH=$X2GO_LIB x2goagent $X2GODPIOPTION_ $XDMCPOPT
-$SESSION_TYPE -auth ~/.Xauthority -geometry ${X2GO_GEOMETRY} -name
"X2GO-${SESSION_NAME}" ${NX_AGENT} 2>${SESSION_DIR}/session.log &
fi
Thanks, Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Hi all, hi Edwin,
On Fr 25 Nov 2011 08:15:09 CET Edwin Hernán Hurtado Cruz wrote:
I like to know how to change the title of the window of the frontend of pyhoca, to show only the user and the ip address or server
I liked your question/idea so much that I have changed x2goserver's
x2gostartagent a little...
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=bf3d7a5a35acdf42...
The shadow session stuff needs another patch in the x2godesktopsharing
code as the user names show are not correct. This will come later today.
Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
That's Great!!!
That solution works perfect for me!!!!
Anyway, I was wondering If its possible to change it in the client-side...
Thanks!!!
El hombre, así como el software, debe ser libre. GNU es libertad. Linux user #461462
Escuchad mi palabra, un nuevo mandamiento os doy: "Derribad las naciones, con tolerancia y golpes de amor"
2011/11/25 Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Hi all, hi Edwin,
On Fr 25 Nov 2011 08:15:09 CET Edwin Hernán Hurtado Cruz wrote:
I like to know how to change the title of the window of the frontend of
pyhoca, to show only the user and the ip address or server
I liked your question/idea so much that I have changed x2goserver's x2gostartagent a little...
http://code.x2go.org/gitweb?p=**x2goserver.git;a=commitdiff;h=** bf3d7a5a35acdf42206e6b723ec902**22e1cb70f6<http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=bf3d7a5a35acdf42206e6b723ec90222e1cb70f6>
The shadow session stuff needs another patch in the x2godesktopsharing code as the user names show are not correct. This will come later today.
Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.**de<mike.gabriel@das-netzwerkteam.de>, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.**de/freebusy/m.gabriel%40das-** netzwerkteam.de.xfb<https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb>
X2go-Dev mailing list X2go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
Hi Alex, hi Edwin,
On Fr 25 Nov 2011 12:56:02 CET Edwin Hernán Hurtado Cruz wrote:
That's Great!!!
That solution works perfect for me!!!!
Anyway, I was wondering If its possible to change it in the client-side...
Thanks!!!
Today I have improved client-side session title renaming in
x2gostartagent (package: x2goserver).
And: I have added a session profile parameter to .x2goclient/sessions
when using pyhoca-gui (python-x2go).
The new session profile parameter's name is: sessiontitle.
If sessiontitle is set to a non-empty string, python-x2go will export
the env variable ,,X2GO_SESSION_WINDOW_TITLE before calling
x2gostartagent on the server-side.
The x2gostartagent script will notice that $X2GO_SESSION_WINDOW_TITLE
is defined and it will use this string as the session window title (+
X2GO-<session_id> in parentheses).
@Alex: could you please take a look at my latest x2goserver commits?
Maybe such a feature could be interesting for x2goclient itself. It
would be nice if we could use the same session profile parameter (i.e.
,,sessiontitle'').
Greets, Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Am 30.11.2011 10:00, schrieb Mike Gabriel:
Hi Alex, hi Edwin,
On Fr 25 Nov 2011 12:56:02 CET Edwin Hernán Hurtado Cruz wrote:
That's Great!!!
That solution works perfect for me!!!!
Anyway, I was wondering If its possible to change it in the client-side...
Thanks!!!
Today I have improved client-side session title renaming in x2gostartagent (package: x2goserver).
And: I have added a session profile parameter to .x2goclient/sessions when using pyhoca-gui (python-x2go).
The new session profile parameter's name is: sessiontitle.
If sessiontitle is set to a non-empty string, python-x2go will export the env variable ,,X2GO_SESSION_WINDOW_TITLE before calling x2gostartagent on the server-side.
The x2gostartagent script will notice that $X2GO_SESSION_WINDOW_TITLE is defined and it will use this string as the session window title (+ X2GO-<session_id> in parentheses).
@Alex: could you please take a look at my latest x2goserver commits? Maybe such a feature could be interesting for x2goclient itself. It would be nice if we could use the same session profile parameter (i.e. ,,sessiontitle'').
x2go client and plugin using window title for searching window with agent session. That will be needed if client should change parameters of such window, for example - hide window decorations, resize window or embed it in other window. Allowing user to change a window title can break functionality of x2go client and plugin.
Greets, Mike
X2go-Dev mailing list X2go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
-- Oleksandr Shneyder Dipl. Informatik X2go Core Developer Team
email: oleksandr.shneyder@obviously-nice.de web: www.obviously-nice.de
--> X2go - everywhere@home
Hi Alex, On Mi 30 Nov 2011 10:45:09 CET Oleksandr Shneyder wrote:
Am 30.11.2011 10:00, schrieb Mike Gabriel:
Hi Alex, hi Edwin,
On Fr 25 Nov 2011 12:56:02 CET Edwin Hernán Hurtado Cruz wrote:
That's Great!!!
That solution works perfect for me!!!!
Anyway, I was wondering If its possible to change it in the client-side...
Thanks!!!
Today I have improved client-side session title renaming in x2gostartagent (package: x2goserver).
And: I have added a session profile parameter to .x2goclient/sessions when using pyhoca-gui (python-x2go).
The new session profile parameter's name is: sessiontitle.
If sessiontitle is set to a non-empty string, python-x2go will export the env variable ,,X2GO_SESSION_WINDOW_TITLE before calling x2gostartagent on the server-side.
The x2gostartagent script will notice that $X2GO_SESSION_WINDOW_TITLE is defined and it will use this string as the session window title (+ X2GO-<session_id> in parentheses).
@Alex: could you please take a look at my latest x2goserver commits? Maybe such a feature could be interesting for x2goclient itself. It would be nice if we could use the same session profile parameter (i.e. ,,sessiontitle'').
x2go client and plugin using window title for searching window with agent session. That will be needed if client should change parameters of such window, for example - hide window decorations, resize window or embed it in other window. Allowing user to change a window title can break functionality of x2go client and plugin.
Ok, I did not know this... Sorry!!! Still, I think the feature would be nice. Couldn't we provide a change in x2goclient that allows to change the session window title as long as the identifier X2GO-<session_id> stays within the title? That could be assured on the server-side and currently (with the latest x2goserver commits) is the case anyway. For X11FindWindow a patch possibly could be this: <quote> diff --git a/onmainwindow_part4.cpp b/onmainwindow_part4.cpp index 76fd224..3db23e1 100644 --- a/onmainwindow_part4.cpp +++ b/onmainwindow_part4.cpp @@ -2359,7 +2359,7 @@ long ONMainWindow::X11FindWindow ( QString text, long rootWin ) { QString title ( wname ); XFree ( wname ); - if ( title==text ) + if ( title.indexOf(text) != -1 ) { proxyId=child_list[i]; break; </quote> But for Windows (wapiFindWindow function), I am not so sure... Mike (who would love to make the session window renaming feature and find a way how to handle that with x2goclient, including old x2goclient versions) -- DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419 GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Am 30.11.2011 12:19, schrieb Mike Gabriel:
Hi Alex,
On Mi 30 Nov 2011 10:45:09 CET Oleksandr Shneyder wrote:
Am 30.11.2011 10:00, schrieb Mike Gabriel:
Hi Alex, hi Edwin,
On Fr 25 Nov 2011 12:56:02 CET Edwin Hernán Hurtado Cruz wrote:
That's Great!!!
That solution works perfect for me!!!!
Anyway, I was wondering If its possible to change it in the client-side...
Thanks!!!
Today I have improved client-side session title renaming in x2gostartagent (package: x2goserver).
And: I have added a session profile parameter to .x2goclient/sessions when using pyhoca-gui (python-x2go).
The new session profile parameter's name is: sessiontitle.
If sessiontitle is set to a non-empty string, python-x2go will export the env variable ,,X2GO_SESSION_WINDOW_TITLE before calling x2gostartagent on the server-side.
The x2gostartagent script will notice that $X2GO_SESSION_WINDOW_TITLE is defined and it will use this string as the session window title (+ X2GO-<session_id> in parentheses).
@Alex: could you please take a look at my latest x2goserver commits? Maybe such a feature could be interesting for x2goclient itself. It would be nice if we could use the same session profile parameter (i.e. ,,sessiontitle'').
x2go client and plugin using window title for searching window with agent session. That will be needed if client should change parameters of such window, for example - hide window decorations, resize window or embed it in other window. Allowing user to change a window title can break functionality of x2go client and plugin.
Ok, I did not know this... Sorry!!!
Still, I think the feature would be nice. Couldn't we provide a change in x2goclient that allows to change the session window title as long as the identifier X2GO-<session_id> stays within the title? That could be assured on the server-side and currently (with the latest x2goserver commits) is the case anyway.
For X11FindWindow a patch possibly could be this:
<quote> diff --git a/onmainwindow_part4.cpp b/onmainwindow_part4.cpp index 76fd224..3db23e1 100644 --- a/onmainwindow_part4.cpp +++ b/onmainwindow_part4.cpp @@ -2359,7 +2359,7 @@ long ONMainWindow::X11FindWindow ( QString text, long rootWin ) { QString title ( wname ); XFree ( wname );
if ( title==text )
if ( title.indexOf(text) != -1 ) { proxyId=child_list[i]; break;
I don't like it. As result you can get a wrong behaviour of a client, if you starting a session with new client and resuming it with old one. I don't think, that this feature is important enough to break compatibility with old versions of clients.
But for Windows (wapiFindWindow function), I am not so sure...
Mike (who would love to make the session window renaming feature and find a way how to handle that with x2goclient, including old x2goclient versions)
X2go-Dev mailing list X2go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
-- Oleksandr Shneyder Dipl. Informatik X2go Core Developer Team email: oleksandr.shneyder@obviously-nice.de web: www.obviously-nice.de --> X2go - everywhere@home
Hi Alex,
On Mi 30 Nov 2011 13:15:19 CET Oleksandr Shneyder wrote:
I don't like it. As result you can get a wrong behaviour of a client, if you starting a session with new client and resuming it with old one. I don't think, that this feature is important enough to break compatibility with old versions of clients.
I have reverted the server-side changes in x2gostartagent. Instead, I
have changed x2gostartagent in a way that it will check for the
x2gofeature X2GO_FEATURE_SESSIONTITLE and if that is available it will
call a subscript.
This feature X2GO_FEATURE_SESSIONTITL and the corresponding subscript
,,x2gosessiontitle'' are part of a new extension package I have added
to x2goserver and called: x2goserver-pyhoca, an add-on package to
improve functionality of pyhoca-gui and pyhoca-cli. This package will
only be suggested by the core x2goserver package, so it will not be
installed if people do not actively select it for installation.
This package currently contains two scripts only used by pyhoca:
x2gosessiontitle x2gosetkeyboard
The x2gosessiontitle subscript will then only generate a custom
session title if the env var X2GO_FEATURE_SESSIONTITLE is set to
,,enabled''. This has to be done from the client when launching
x2gostartagent.
I hope this approach allows us to keep the session title functionality
and stay also compatible with old client implementations and between
pyhoca and x2goclient.
Let me know what you think, Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
Am 30.11.2011 13:30, schrieb Mike Gabriel:
Hi Alex,
On Mi 30 Nov 2011 13:15:19 CET Oleksandr Shneyder wrote:
I don't like it. As result you can get a wrong behaviour of a client, if you starting a session with new client and resuming it with old one. I don't think, that this feature is important enough to break compatibility with old versions of clients.
I have reverted the server-side changes in x2gostartagent. Instead, I have changed x2gostartagent in a way that it will check for the x2gofeature X2GO_FEATURE_SESSIONTITLE and if that is available it will call a subscript.
This feature X2GO_FEATURE_SESSIONTITL and the corresponding subscript ,,x2gosessiontitle'' are part of a new extension package I have added to x2goserver and called: x2goserver-pyhoca, an add-on package to improve functionality of pyhoca-gui and pyhoca-cli. This package will only be suggested by the core x2goserver package, so it will not be installed if people do not actively select it for installation.
This package currently contains two scripts only used by pyhoca:
x2gosessiontitle x2gosetkeyboard
The x2gosessiontitle subscript will then only generate a custom session title if the env var X2GO_FEATURE_SESSIONTITLE is set to ,,enabled''. This has to be done from the client when launching x2gostartagent.
I hope this approach allows us to keep the session title functionality and stay also compatible with old client implementations and between pyhoca and x2goclient.
Let me know what you think, Mike
it sounds ok for me.
regards, alex
Oleksandr Shneyder Dipl. Informatik X2go Core Developer Team
email: oleksandr.shneyder@obviously-nice.de web: www.obviously-nice.de
--> X2go - everywhere@home
Hi Alex,
On Mi 30 Nov 2011 13:35:38 CET Oleksandr Shneyder wrote:
Am 30.11.2011 13:30, schrieb Mike Gabriel:
Hi Alex,
On Mi 30 Nov 2011 13:15:19 CET Oleksandr Shneyder wrote:
I don't like it. As result you can get a wrong behaviour of a client, if you starting a session with new client and resuming it with old one. I don't think, that this feature is important enough to break compatibility with old versions of clients.
I have reverted the server-side changes in x2gostartagent. Instead, I have changed x2gostartagent in a way that it will check for the x2gofeature X2GO_FEATURE_SESSIONTITLE and if that is available it will call a subscript.
This feature X2GO_FEATURE_SESSIONTITL and the corresponding subscript ,,x2gosessiontitle'' are part of a new extension package I have added to x2goserver and called: x2goserver-pyhoca, an add-on package to improve functionality of pyhoca-gui and pyhoca-cli. This package will only be suggested by the core x2goserver package, so it will not be installed if people do not actively select it for installation.
This package currently contains two scripts only used by pyhoca:
x2gosessiontitle x2gosetkeyboard
The x2gosessiontitle subscript will then only generate a custom session title if the env var X2GO_FEATURE_SESSIONTITLE is set to ,,enabled''. This has to be done from the client when launching x2gostartagent.
I hope this approach allows us to keep the session title functionality and stay also compatible with old client implementations and between pyhoca and x2goclient.
Let me know what you think, Mike
it sounds ok for me.
That's cool! Ok... I need to do some more testing... I'll let you know
once the code in Git HEAD is stable again.
Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
On 2011-11-30 13:37, Mike Gabriel wrote:
That's cool! Ok... I need to do some more testing... I'll let you know once the code in Git HEAD is stable again.
Mike
Why not branch?
Cheers Morty
-- Dipl.-Ing. Moritz 'Morty' Struebe (Wissenschaftlicher Mitarbeiter) Lehrstuhl für Informatik 4 (Verteilte Systeme und Betriebssysteme) Friedrich-Alexander-Universität Erlangen-Nürnberg Martensstr. 1 91058 Erlangen
Tel : +49 9131 85-25419 Fax : +49 9131 85-28732 eMail : struebe@informatik.uni-erlangen.de WWW : http://www4.informatik.uni-erlangen.de/~morty
Hi all,
On Mi 30 Nov 2011 13:37:45 CET Mike Gabriel wrote:
That's cool! Ok... I need to do some more testing... I'll let you
know once the code in Git HEAD is stable again.
Looks like the x2goserver package from the nightly builds is working
fine again...
Greets, Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
On Wed, 2011-11-30 at 10:45 +0100, Oleksandr Shneyder wrote: <snip>
x2go client and plugin using window title for searching window with agent session. That will be needed if client should change parameters of such window, for example - hide window decorations, resize window or embed it in other window. Allowing user to change a window title can break functionality of x2go client and plugin. <snip> Hello, all. I'm not a developer so take this with a very large grain of salt but, isn't that a strange place to put an important piece of logic unrelated to user interaction? User's don't need the information; it can be confusing to them; it displaces potentially more useful user information. Can that information simply be stashed in a class attribute rather than part of the UI? - John
On Wed, Nov 30, 2011 at 6:20 AM, John A. Sullivan III <jsullivan@opensourcedevel.com> wrote:
Hello, all. I'm not a developer so take this with a very large grain of salt but, isn't that a strange place to put an important piece of logic unrelated to user interaction? User's don't need the information; it can be confusing to them; it displaces potentially more useful user information. Can that information simply be stashed in a class attribute rather than part of the UI? - John
I agree that it seems odd.
Also, one feature that nomachine has had for a long time that I have missed with x2go is that I can have multiple sessions open or suspended, and each one can have a name that I assign. It makes it much easier to keep track of which session I want when I am suspending and resuming multiple sessions from different client computers.
Hi John+John, hi Alex,
On Mi 30 Nov 2011 22:14:35 CET John Williams wrote:
On Wed, Nov 30, 2011 at 6:20 AM, John A. Sullivan III <jsullivan@opensourcedevel.com> wrote:
Hello, all. I'm not a developer so take this with a very large grain of salt but, isn't that a strange place to put an important piece of logic unrelated to user interaction? User's don't need the information; it can be confusing to them; it displaces potentially more useful user information. Can that information simply be stashed in a class attribute rather than part of the UI? - John
I agree that it seems odd.
Is it possible to long-term-find another mechanism for this? The
server code surely needs a fallback in case old clients are
connecting, but for newer clients could there be a change in this?
What people also requested from me is a custom icon for rootless
session window (i.e. if firefox is launch in a rootless window then
there should be a firefox icon in the window frame (and taskbar), not
an X2Go icon... But that's already another cup of tea...
Also, one feature that nomachine has had for a long time that I have missed with x2go is that I can have multiple sessions open or suspended, and each one can have a name that I assign. It makes it much easier to keep track of which session I want when I am suspending and resuming multiple sessions from different client computers.
This would require to store the session window title in the X2Go
database... (I think).
Greets, Mike
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...
-
Edwin Hernán Hurtado Cruz -
John A. Sullivan III -
John Williams -
Mike Gabriel -
Moritz Struebe -
Oleksandr Shneyder