On Fri, May 17, 2019 at 9:31 PM Ulrich Sibiller <ulrich.sibiller@gmail.com> wrote:
Alternatively we could add a hack: if the proxy hostname has some special form, e.g. "!hostname", that very check will be skipped. As proxy and normal hosts are both controlled via the same code in SshmasterConnection this way the user could configure that for both connections independently.
I have just implemented that, see attached patch 0001. It makes my setup work. What do you think of this approach?
Originally, I thought that this would conflict with ssh_config support (because such host names need not be valid DNS names), but I guess it's fine, since the characters *, ?, "," and ! are special in this context and used for pattern matching, so they cannot be used in such host names directly. Since ! is part of that set, I guess we're free to use it for such a purpose.
Applied.
While doing that I also noticed that checkLogin() is missing some cleanup code, see attached patch 0002.
Applied that one, too.
Mihai