HI Orion,
I re-include x2go-dev, I hope that's ok.
On Fr 30 Aug 2013 00:51:18 CEST Orion Poplawski wrote:
So:
- Why split out -compat? Doesn't seem to add any dependencies.
Not necessarily needed. /me thinks about removing the compat commands
completely, as they have been obsolete for more then 3 years now.
- Why split out -extensions? Okay, does pull x11-xkb-utils which
isn't otherwise required, but it appears to be recommended that you
have it. rpm doesn't have the concept of "Recommends" or
"Suggests", just hard dependencies.
In some setups, the site admin may decide to leave it uninstalled. (Or
rather: to uninstall it after it got pulled in via Recommends: field
in /debian/control).
Also, removing x2goserver-extensions may ease the X2Go Server
debugging in some occasions.
- Why split out -xsession? Adds dep on x11-common which appears to
not be otherwise required. Only suggested.
The -xsession package is only necessary for people providing a full
screen desktop shell. For people providing SaaS the -xsession package
is not needed.
And x11-common is normally not needed for X2Go functionality. We hook
into the system's Xsession scripts (via symlinking), so that's why we
depend on x11-common here.
- Why split out -fmbindings? Adds deps on xdg-utils,
desktop-file-utils (although for Fedora, this is not required, but
xdg-utils requires it). Although it seems nearly impossible to
install almost any desktop without xdg-utils (lxde and xfce seem to
require it), and it is tiny and has few dependencies.
Instead of x2goserver-fmbindings people can use x2go*bindings. Also
site admins may not want to add desktop icon support for locally
shared folders.
- Why split out -pyhoca? Does not appear to add any dependencies.
Doesn't appear to do anything as far as I can see.
The -pyhoca package is deprecated. It stems from a time when I was to
shy to add functionalty to the x2goserver core package when I needed
it for pyhoca-gui. This shyness is obviously gone...
I will remove the x2goserver-pyhoca package in some future release
completely. So ignore it.
I already split out -printing, although I'm not sure that added much
(perl(File::Basename), perl(File::Copy)), so that might have been
silly. So, I guess I could see splitting out -xsession and possibly
-fmbindings, but that's about it.
Splitting out printing is a must IMHO as it creates a separate
user:group (x2goprint:x2goprint).
Looking at dependencies:
- lsof - from x2goshowblocks:
my @outp=dbsys_getmounts( $id); for (my $i=0;$i<@outp;$i++) { my $path=(split("\|",@outp[$i]))[1]; print
su $uname -c "lsof 2>/dev/null | grep $path"; }Hmm, it's inefficient if there are more than one mount entries, but
otherwise I don't see a better way of doing it off hand. But this I
could actually imagine going into a utils/debug package. Unless it
is used for something else?
Yeah. This can surely be improved.
- bc - from x2goruncommand
echo "$DISTRIB_RELEASE >= 11.10" | bc
Actually, not that much on my machine depends on bc. Since
x2goserver already depends on perl, I'd be tempted to use that
instead:perl -e "print $DISTRIB_RELEASE >= 11.10"
As the x2goruncommand should be turned into Perl at some time later, I
will be happy to accept a tested patch for this.
Mike
--
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148
GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...