1 Sep
2014
1 Sep
'14
11:23 p.m.
On Mon, Sep 1, 2014 at 3:51 PM, Mike Gabriel <mike.gabriel@das-netzwerkteam.de> wrote:
Hi Mike#2,
On Mo 01 Sep 2014 19:28:50 CEST, George Trakatelis wrote:
A suggested patch is to substitute the Qt4 toAscii() function with toLocal8Bit() in two specific places of SshMasterConnection::run(). A git diff is as follows:
$ diff /c/a/sshmasterconnection.cpp /c/b/sshmasterconnection.cpp 521c521 < ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, (mainWnd->getHomeDirectory()+"/ssh").toAscii());
ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,(mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());
630c630 < ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, (mainWnd->getHomeDirectory()+"/ssh").toAscii());
ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,(mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());
The change affects only Windows builds and was tested in Windows 8.1 Pro and Windows 7 Professional.
G. Trakatelis
Can you review these changes and if appropriate commit them to the master branch of x2goclient.git?
Thanks! Mike
[...]
Sure. I'm busy today, but I'll do so within the next few/several days.
-Mike