What is the rationale for the extra group? Is there a good reason for disallowing someone to share his/her desktop? Cheers Morty On 2011-08-02 15:24, Mike Gabriel wrote:
Hi all,
I have had another look at x2godesktopsharing and I would propose a change of group membership for users who are allowed to use x2godesktopsharing. Formerly, this was group ,,x2gousers''. I would like to propose a rename to ,,x2godesktopsharing''.
A patch for this is attached below.
A possible question is if we want to migrate users in group x2gousers to this group during package upgrade.
Greets, Mike
commit 4cf4a0b2dad35e92ddaac712c9d2b6f513cd4a46 Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de> Date: Tue Aug 2 15:18:54 2011 +0200
System group for x2godesktopsharing change from x2gousers ->x2godesktopsharing.
diff --git a/debian/changelog b/debian/changelog index b8c5bf1..7d7a7eb 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,6 +1,8 @@ x2godesktopsharing (3.0.1.3-0~x2go1) UNRELEASED; urgency=low
- Fix incomplete DENY statement in main.cpp.
- System group for x2godesktopsharing change from x2gousers ->
- x2godesktopsharing.
-- Mike Gabriel <mike.gabriel@das-netzwerkteam.de> Mon, 13 Jun 2011 20:39:33 +0200
diff --git a/debian/x2godesktopsharing.postinst b/debian/x2godesktopsharing.postinst index 2f7b721..1d55fba 100755 --- a/debian/x2godesktopsharing.postinst +++ b/debian/x2godesktopsharing.postinst @@ -22,10 +22,10 @@ set -e
case "$1" in configure)
- X2GOGRP=`getent group | grep x2gousers`
- X2GOGRP=`getent group | grep x2godesktopsharing` if [ "x$X2GOGRP"="x" ] then
addgroup --system x2gousers
addgroup --system x2godesktopsharingdiff --git a/sharetray.cpp b/sharetray.cpp index 7fe23f0..9f42997 100644 --- a/sharetray.cpp +++ b/sharetray.cpp @@ -215,7 +215,7 @@ void ShareTray::slotStartSharing() if ( serverSocket->listen ( socketFname ) ) {
chown ( socketFname.toAscii(),getuid(),getgrnam ( "x2gousers"
chown ( socketFname.toAscii(),getuid(),getgrnam (QFile::ReadOwner|QFile::WriteOwner|QFile::ReadGroup|QFile::WriteGroup ); connect ( serverSocket,SIGNAL ( newConnection() ),
X2go-Dev mailing list X2go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
-- Dipl.-Ing. Moritz 'Morty' Struebe (Wissenschaftlicher Mitarbeiter) Lehrstuhl für Informatik 4 (Verteilte Systeme und Betriebssysteme) Friedrich-Alexander-Universität Erlangen-Nürnberg Martensstr. 1 91058 Erlangen Tel : +49 9131 85-25419 Fax : +49 9131 85-28732 eMail : struebe@informatik.uni-erlangen.de WWW : http://www4.informatik.uni-erlangen.de/~morty