On Wednesday 2013-01-09 15:21, Reinhard Tartler wrote:
+++ nx-libs-3.5.0.17/nxcomp/Makefile.in @@ -36,8 +36,7 @@ LIBVERSION=@LIBVERSION@ #
CXX = @CXX@ -CXXFLAGS = @CXXFLAGS@ @X_CFLAGS@ @DEFS@ \
-Wall -Wpointer-arithAFAIUI, this is not a fix. Instead of replacing the hardcoded values, this patch ensures that all options end behind the hardcoded values. This makes it impossible to drop compiler flags that are specified within.
This may be fair when your goal is to only change the optimization level, but may be insufficient when the goal is a hardened build.
I don't care about the "hardened" because that is just another case of "user wants to specify his own CFLAGS". I had hoped that @CXXFLAGS@ would be those user-specific ones, but alas, no. *Total dismay at Makefile authors who still squat on CXXFLAGS*