On 21.03.2016 05:28 PM, Oleksandr Shneyder wrote:
it looks fine for me.
I have one big comment which I want to discuss in a separate mail. Otherwise looks fine to me, too, or I have already fixed smaller issues on my side.
@Mihai, Mike DePaulo: Can we update our build environment to build x2goclient with Qt5 on platforms where Qt5 is available?
The build environment as such is already good to go, only the distribution-specific build scripts/files (i.e., x2goclient.spec, debian/*) need to be updated to correctly depend upon Qt5 and prefer Qt5's qmake when possible. This is mostly also true for OS X.
I can do this after the actual patch is applied.
Mihai