On 2011-09-30 09:08, Mike Gabriel wrote:
- what happens to stdout and stderr? What is propagated to the client/logfile/</dev/null>?
The x2goserver-run-extensions script silence the sub-scripts complete. Just committed to Git. Thanks.
IS this a good idea? That is no fun debugging - and maybe those scripts want to output to the session log.
- Why always return 0? At least for pre-* it might be nice if something can fail.
Hmmmm... Really depends on the use case. On the one hand you are right on the other hand failing extensions scare me. Hmmm...
Well, actually I was mainly thinking of pre-start. It can be abused to implement access-control. Or you might not want to allow a new session if some service fails to start. We have fail-* to clean up already started services
- What about the environment? What information do I get (client-string/version/username/remote ip)?
You have the SESSION_NAME (as $1). With that the subscripts can obtain the rest (from x2golistsessions etc.).
Ah ok. Maybe a pointer to that wouldn't be too bad.
Another thing came to mind: What about turning around the naming-sceme: start-pre start-post start-fail That way things that belong together are listed together (also thinking of tab-compleation). I am happy with the current solution, too, though.
And yet another idea: What about passing "pre-start" etc as first parameter. (similar to intit.d) That way every service only needs one script and can use symlinks.
Cheers Morty
-- Dipl.-Ing. Moritz 'Morty' Struebe (Wissenschaftlicher Mitarbeiter) Lehrstuhl für Informatik 4 (Verteilte Systeme und Betriebssysteme) Friedrich-Alexander-Universität Erlangen-Nürnberg Martensstr. 1 91058 Erlangen
Tel : +49 9131 85-25419 Fax : +49 9131 85-28732 eMail : struebe@informatik.uni-erlangen.de WWW : http://www4.informatik.uni-erlangen.de/~morty