Hi all,
yesterday I have been working on the C++ code in x2godesktopsharing.
To make sure that x2godesktopsharing really gets shutdown on
x2goterminate-session, I have added a script to the x2godesktopsharing
package that detects the corresponding x2godesktopsharing process for
a given session $X2GO_SESSION. This script
,,x2godesktopsharing-terminate" will be exectuted by
,,x2goterminate-session".
This brought up the next question: how do we want to handle
x2godesktopsharing while a session is suspended. This older versions
of X2go (I think) this has been possible. I consider this as a
security problem and something that most users do not want. Imagine
the scenario:
o start x2go session o start x2godesktopsharing o allow user foo to share your desktop and remember this setting permanently (via .x2godesktopsharing/settings) o suspend your session (and x2godesktopsharing continues to offer desktop sharing... :-( ) o user foo tries to connect to your desktop while you are away (while your session is suspended o -> this is YUK!
So what I have done is this:
o on session suspend, terminate x2godesktopsharing and remember that it was running, place a server-side empty file ,,resume-desktopsharing'' into
$HOME/.x2go/C-$X2GO_SESSION/o on session resume, check if that file is there and if so, launch a new instance of x2godesktopsharing, with sharing mode set to disabled.
Feedback, comments?
Mike
PS: I have just looked at my commits from yesterday and it feels like
I should rename the provided scripts in this way:
x2godesktopsharing-terminate -> x2goterminate-desktopsharing x2godesktopsharing-suspend -> x2gosuspend-desktopsharing etc.
--
DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419
GnuPG Key ID 0xB588399B mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xf...